Activity OpenACS/

2:17 pm

antoniop

Fix query in oacs_dav::children_have_permission_p

- -1
- +1
/openacs-4/packages/oacs-dav/tcl/oacs-dav-procs-postgresql.xql
- History
- Source
- Diff
/openacs-4/.../oacs-dav-procs-postgresql.xql

2:16 pm

antoniop

Test oacs_dav::children_have_permission_p: this test exposes a bug in the api

- -1
- +108
/openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../oacs-dav-procs.tcl

2:24 pm

antoniop

Modernize tcl

- -14
- +22
/openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../oacs-dav-procs.tcl
- -28
- +1
/openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.xql
- History
- Source
- Diff
/openacs-4/packages/.../oacs-dav-procs.xql

2:16 pm

antoniop

Make service contract implementation private and replace foreign occurrences

- -10
- +37
/openacs-4/packages/file-storage/tcl/file-storage-dav-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-dav-procs.tcl
- -21
- +25
/openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../oacs-dav-procs.tcl

2:07 pm

trenner

produce error message in the error log, if the parameter value_array_list is not well formed

- -1
- +5
/openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
- History
- Source
- Diff
/openacs-4/.../lang-message-procs.tcl

2:00 pm

antoniop

Whitespace changes

- -17
- +17
/openacs-4/packages/file-storage/tcl/file-storage-dav-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-dav-procs.tcl

1:28 pm

trenner

show the amount of questions only if the no_position parameter is not provided

-) the no_position parameter is provided for the composite question form

- -1
- +6
/openacs-4/packages/xowf/tcl/test-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-item-procs.tcl

10:54 am

antoniop

Prefer the classical procedural api in the installation callbacks for these two packages:

- currently, acs-service-contract (among others) defines database functions with the same number of arguments, but different argument types. The acs::dc facility won't be able to distinguish which is the correct one to pick in this case

- a cicken/egg problem arises when one installs xowiki-portlet alongside the new-portal package, because before a restart the acs::dc methods won't be created yet

- -39
- +11
/openacs-4/packages/dotlrn-xowiki/tcl/xowiki-applet-procs.tcl
- History
- Source
- Diff
/openacs-4/.../xowiki-applet-procs.tcl
- -36
- +20
/openacs-4/packages/xowiki-portlet/tcl/xowiki-admin-portlet-procs.tcl
- History
- Source
- Diff
/openacs-4/.../xowiki-admin-portlet-procs.tcl
- -37
- +21
/openacs-4/packages/xowiki-portlet/tcl/xowiki-portlet-procs.tcl
- History
- Source
- Diff
/openacs-4/.../xowiki-portlet-procs.tcl

8:40 am

antoniop

Fix typo in test

- -1
- +1
/openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/local-procs.tcl

6:44 pm

antoniop

Complete coverage for the ACS Service Contract 'auth_user_info'

- -0
- +47
/openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/local-procs.tcl

6:29 pm

antoniop

Complete coverage of ACS Service Contract 'auth_sync_retrieve' implementations

- -2
- +35
/openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../sync-test-procs.tcl

6:14 pm

antoniop

Test IMS_Enterprise_v_1p1 implementation of the auth_sync_process Service Contract

- -1
- +213
/openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../sync-test-procs.tcl

3:24 pm

antoniop

Rework parameter check:

the way the if was construed would allow e.g.:

1. a value for EmailRegistrationConfirmationToUserP = 'nottrue' to pass the first if, but fail the second.

2. a value EmailRegistrationConfirmationToUserP = 'false' to be "true" in the first if, but not in the second

In fact, if EmailRegistrationConfirmationToUserP should be a boolean, there is no need to further check the other parameters and variables in the second if. This change is not 100% equivalent to the previous code, but makes it clear that EmailRegistrationConfirmationToUserP should be interpreted as a boolean and fixes these inconsistencies.

- -26
- +18
/openacs-4/packages/acs-authentication/tcl/local-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/local-procs.tcl

2:57 pm

antoniop

Make clear that parameters come from the same subsite

- -7
- +12
/openacs-4/packages/acs-authentication/tcl/local-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/local-procs.tcl

2:55 pm

antoniop

Test implementations of ACS Service Contract 'auth_registration'

This exposes a bug in auth::local::registration::Register where the acs-subsite parameter NotifyAdminOfNewRegistrationsP is fetched from the ad_conn package_id, rather than the subsite_id

- -0
- +296
/openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/local-procs.tcl

5:16 pm

antoniop

Fix signature of service contract implementation, that is defined with 3 and not 4 arguments, complete coverage of the auth_password contract local implementation