OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 11
Total Committers: 145
Last Commit: 09:40
Commits this week: 11
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 19 Sep 2022
6:14 pm

antoniop

Test IMS_Enterprise_v_1p1 implementation of the auth_sync_process Service Contract

Options
    • -1
    • +213
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
3:24 pm

antoniop

Rework parameter check:

the way the if was construed would allow e.g.:

1. a value for EmailRegistrationConfirmationToUserP = 'nottrue' to pass the first if, but fail the second.

2. a value EmailRegistrationConfirmationToUserP = 'false' to be "true" in the first if, but not in the second

In fact, if EmailRegistrationConfirmationToUserP should be a boolean, there is no need to further check the other parameters and variables in the second if. This change is not 100% equivalent to the previous code, but makes it clear that EmailRegistrationConfirmationToUserP should be interpreted as a boolean and fixes these inconsistencies.

Options
    • -26
    • +18
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
2:57 pm

antoniop

Make clear that parameters come from the same subsite

Options
    • -7
    • +12
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
2:55 pm

antoniop

Test implementations of ACS Service Contract 'auth_registration'

This exposes a bug in auth::local::registration::Register where the acs-subsite parameter NotifyAdminOfNewRegistrationsP is fetched from the ad_conn package_id, rather than the subsite_id

Options
    • -0
    • +296
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
Friday 16 Sep 2022
5:16 pm

antoniop

Fix signature of service contract implementation, that is defined with 3 and not 4 arguments, complete coverage of the auth_password contract local implementation

Options
    • -7
    • +2
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
    • -0
    • +98
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
4:31 pm

antoniop

Complete coverage of the auth_authentication contract 'local' implementation

Options
    • -0
    • +48
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
4:31 pm

antoniop

file local-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
3:56 pm

antoniop

Make service contract implementations private, test them

Options
    • -2
    • +2
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
    • -1
    • +44
    /openacs-4/packages/categories/tcl/test/categories-procs.tcl
1:53 pm

antoniop

Whitespace cleanup

Options
    • -4
    • +4
    /openacs-4/packages/acs-service-contract/tcl/test/acs-service-contract-procs.tcl
Thursday 15 Sep 2022
1:10 pm

antoniop

Whitespace changes

Options
    • -22
    • +22
    /openacs-4/packages/assessment/tcl/test/twt-procs.tcl
1:09 pm

antoniop

Kill hamfisted test that might end up deleting unrelated test users

Options
    • -17
    • +0
    /openacs-4/packages/assessment/tcl/test/twt-procs.tcl
Wednesday 14 Sep 2022
4:16 pm

antoniop

Distinguish between procs defined via plain Tcl and NSF, when querying for the command arguments

Options
    • -2
    • +11
    /openacs-4/packages/acs-service-contract/www/binding-display.tcl
3:11 pm

antoniop

Whitespace cleanup

Options
    • -16
    • +14
    /openacs-4/packages/dotlrn-news-aggregator/tcl/dotlrn-news-aggregator-procs.tcl
    • -4
    • +4
    /openacs-4/packages/dotlrn-news-aggregator/tcl/apm-callback-procs.tcl
2:33 pm

antoniop

Prefer acs::try_cache where the cache existance cannot be taken for granted (e.g. at upgrade)

Options
    • -6
    • +5
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
2:29 pm

antoniop

Make acs::try_cache more robust to transitional situations during instance upgrade, where the object might exist, but not the method

Options
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
2:15 pm

antoniop

Update italian localization

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +4
    /openacs-4/packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml
1:18 pm

antoniop

Update italian localization

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +1
    /openacs-4/packages/acs-templating/catalog/acs-templating.it_IT.ISO-8859-1.xml
1:07 pm

antoniop

Improve doc

Options
    • -3
    • +4
    /openacs-4/packages/dotlrn-news-aggregator/tcl/dotlrn-news-aggregator-procs.tcl
1:05 pm

antoniop

Whitespace cleanup

Options
    • -17
    • +15
    /openacs-4/packages/dotlrn-news-aggregator/tcl/dotlrn-news-aggregator-procs.tcl
1:05 pm

antoniop

Add doc

Options
    • -1
    • +2
    /openacs-4/packages/chat-portlet/tcl/chat-admin-portlet-procs.tcl
    • -0
    • +1
    /openacs-4/packages/chat-portlet/tcl/chat-portlet-procs.tcl
12:45 pm

antoniop

Ignore also class definitions in the ignored namespaces

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
12:16 pm

antoniop

Apply the deprecated flag to the methods documentation

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
Tuesday 13 Sep 2022
7:22 pm

hectorr

Whitespace changes

Options
    • -40
    • +40
    /openacs-4/packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
6:55 pm

gernst

ns_quotehtml user submitted value inside error message to prevent potential XSS attack

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
6:52 pm

hectorr

Whitespace changes

Options
    • -8
    • +8
    /openacs-4/packages/assessment/tcl/as-export-procs.tcl
4:40 pm

antoniop

Ignore the ::nsshell namespace: this is a NaviServer module, hence outside the OpenACS source tree

Options
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
4:06 pm

antoniop

Add doc

Options
    • -1
    • +2
    /openacs-4/packages/xowiki-portlet/tcl/xowiki-portlet-procs.tcl
4:00 pm

antoniop

Fix doc

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn-assessment/tcl/dotlrn-assessment-procs.tcl
3:59 pm

antoniop

Add doc to public api

Options
    • -1
    • +2
    /openacs-4/packages/dotlrn-dotlrn/tcl/dotlrn-dotlrn-procs.tcl
3:58 pm

antoniop

Document public api, formatting changes

Options
    • -16
    • +17
    /openacs-4/packages/new-portal/tcl/datasource-procs.tcl