OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 145
Last Commit: 19:04
Commits this week: 3
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 01 Sep 2022
5:03 pm

antoniop

Make template::head::prepare_multirows a private interface: its stated purpose is to be used inside of the blank-master and it has no practical use otherwise

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
4:50 pm

antoniop

Make adp_parse_ad_conn_file a private interface: its stated purpose is to be registered via rp_register_extension_handler in acs-templating/tcl/acs-integration-init.tcl and it has no practical use otherwise

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/acs-integration-procs.tcl
2:58 pm

antoniop

Test ad_return_template

Options
    • -5
    • +76
    /openacs-4/packages/acs-templating/tcl/test/acs-integration-procs.tcl
2:33 pm

antoniop

Reuse computation

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
2:31 pm

antoniop

Avoid catch where a more appropriate idiom exists

Options
    • -8
    • +10
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
2:28 pm

antoniop

Improve documentation

Options
    • -1
    • +6
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
2:21 pm

antoniop

Cleanup case

Options
    • -4
    • +0
    /openacs-4/packages/acs-subsite/www/user/portrait/index.adp
2:17 pm

antoniop

Whitespace cleanup

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
2:17 pm

antoniop

Harden page contract

Options
    • -10
    • +2
    /openacs-4/packages/acs-subsite/www/user/portrait/index.tcl
11:50 am

antoniop

Extend regression test

Options
    • -5
    • +64
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
9:21 am

trenner

if truncate_len is provided we have to call util_close_html_tags for truncating the string

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
12:41 am

antoniop

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

Options
    • -17
    • +21
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
    • -0
    • +59
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
    • -1
    • +1
    /openacs-4/packages/file-storage/tcl/test/webtest-procs.tcl
Wednesday 31 Aug 2022
2:55 pm

antoniop

Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

Options
    • -9
    • +19
    /openacs-4/packages/file-storage/tcl/test/webtest-procs.tcl
2:51 pm

antoniop

Extend util::http::post_payload and util::http::post to receive form varaibles also in dict form, update documentation

Options
    • -22
    • +58
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
12:18 pm

antoniop

Cleanup leftover arguments

Options
    • -8
    • +0
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
12:18 pm

antoniop

Test ad_return_exception_template

Options
    • -0
    • +76
    /openacs-4/packages/acs-templating/tcl/test/acs-integration-procs.tcl
12:18 pm

antoniop

file acs-integration-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-templating/tcl/test/acs-integration-procs.tcl
11:44 am

antoniop

Deprecate acs-subsite/www/shared/db-error and move a copy to acs-subsite/lib/shared/db-error, replace occurrences, adjust dependencies

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -0
    • +20
    /openacs-4/packages/acs-subsite/lib/shared/db-error.adp
    • -0
    • +1
    /openacs-4/packages/acs-subsite/www/shared/db-error.adp
    • -0
    • +1
    /openacs-4/packages/dotlrn-homework/dotlrn-homework.info
    • -1
    • +1
    /openacs-4/packages/dotlrn-homework/www/file-add.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn-homework/www/file-move-2.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn-homework/www/folder-create.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn-homework/www/version-add.tcl
11:44 am

antoniop

file db-error.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-subsite/lib/shared/db-error.adp
11:35 am

antoniop

Make this template more robust to the casual invocation from the outside

This should actually be moved to the lib directory, as it is intended as an include

Options
    • -5
    • +7
    /openacs-4/packages/acs-subsite/www/shared/db-error.adp
11:32 am

antoniop

Whitespace changes

Options
    • -14
    • +15
    /openacs-4/packages/acs-subsite/www/shared/db-error.adp
Tuesday 30 Aug 2022
6:07 pm

antoniop

Test ad_dimensional_sql

Options
    • -0
    • +45
    /openacs-4/packages/acs-templating/tcl/test/dimensional-procs.tcl
5:53 pm

antoniop

Test ad_dimensional

Options
    • -0
    • +69
    /openacs-4/packages/acs-templating/tcl/test/dimensional-procs.tcl
5:53 pm

antoniop

file dimensional-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-templating/tcl/test/dimensional-procs.tcl
5:40 pm

hectorr

Make spelling consistent

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
5:16 pm

antoniop

Quote unallowed HTML according to acs-tcl.documentation__check_proc_doc

Options
    • -2
    • +2
    /openacs-4/packages/xml-rpc/tcl/xml-rpc-procs.tcl
4:48 pm

antoniop

Rename proc according to convention enforced in acs-tcl: naming__proc_naming

Options
    • -5
    • +4
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
3:08 pm

antoniop

Reinstate the notnull validation constraint where missing

Options
    • -2
    • +2
    /openacs-4/packages/forums/lib/message/post.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/message/threads-chunk.tcl
    • -2
    • +2
    /openacs-4/packages/forums/lib/user/post-history-chunk.tcl
    • -1
    • +1
    /openacs-4/packages/forums/www/forum-view-statistic.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/forum-view.tcl
    • -1
    • +1
    /openacs-4/packages/forums/www/load-message-content.tcl
    • -1
    • +1
    /openacs-4/packages/forums/www/mark-all-read.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/message-email.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/user-history.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/admin/forum-disable.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/admin/forum-edit.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/admin/forum-enable.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/admin/permissions-user-add.tcl
    • -5
    • +5
    /openacs-4/packages/forums/www/admin/subscribe-others-2.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/admin/subscribe-others.tcl
  16. … 10 more files in changeset.
2:22 pm

gustafn

re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Options
    • -2
    • +2
    /openacs-4/packages/forums/www/message-view.tcl
2:03 pm

gustafn

handle clases, where "nt_load_end" is not provided

Options
    • -2
    • +6
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl