OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 19
Total Committers: 145
Last Commit: 02 May
Commits this week: 19
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Feb 2022
3:30 pm

antoniop

Various changes on the proctoring artifacts users list:

- display some statistics on the collected artifacts for each user: count, number of reviewed, number of flagged, plus a colored progress bar indicating the review status, orange when in progress, red when completed with flags and green when everything is ok

- switched to a template::list to avoid too much handcrafting

- removed the red delete button from the top of the page, redundant, since we have the bulk actions on the list

- refined the behavior of the bulk-action delete button: it will be disabled when nothing is selected

- now we always trigger a reload when new artifacts are received for this object, but we cap it to 60 seconds

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -0
    • +5
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +5
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +5
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -102
    • +75
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -20
    • +89
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
2:10 pm

antoniop

Store the string "false", not the boolean false

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/www/review.tcl
12:24 pm

gustafn

Improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-db-00-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
12:24 pm

gustafn

Fine-tuning the new db function interface

#

# Check, wether we have to regenerate the database function interface.

#

# - During initial setup, there are no db-functions, so nothing has to

# be done.

#

# - During regular startup of the server, the generation of the stub

# interface happens in the *init procs (hopefully this is always

# sufficient, but seems so)

#

# - During reloads of acs-db-*-procs, the base classes are interface

# objects are recreated and cleaned up from all prior definitons,

# which means that in this situations, we have to regeneate the

# interface.

#

# - One might call manually the regeneration, when database functions

# have been altered and no restart is desired.

#

Options
    • -10
    • +41
    /openacs-4/packages/acs-tcl/tcl/acs-db-12-procs.tcl
10:01 am

antoniop

Use a full join so that in case of (normally minimal) unalignment between camera and desktop, we still display every artifact

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
10:00 am

gustafn

avoid dead operations

Options
    • -3
    • +6
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
9:51 am

antoniop

Keep making sure permission exists

Options
    • -1
    • +2
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
Monday 21 Feb 2022
9:35 pm

gustafn

Reform of site-nodes-procs

- made XOTcl2 based implementation of site-nodes usable during

initial bootstrap

- made new site-node cache implementation working for Oracle

- now, the same code works during bootstrap, for PostgreSQL and Oracle

and independent of xotcl-core being installed or not.

- removed old and broken nsv-based site-node cache

- reduced need of .xql files (removed query for delete.delete_site_node)

- moved deprecated calls to deprecated-procs.tcl

This change make the code much clearer and eases maintenance and debugging.

Options
    • -327
    • +499
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -6
    • +0
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs-oracle.xql
    • -6
    • +0
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs-postgresql.xql
    • -1587
    • +777
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
9:27 pm

gustafn

Update of SQL function calling interface to make it usable during initial bootstrap

- add sanity checks and produce error messages,

when function args are incorrect.

- do not throw errors in case it is called before the

table acs_function_args was created (during boot)

- added preliminary "list" call to acs::dc

- added first *-init.tcl to be called after loading

the *-proc.tcl files.

- removed all references to the ::xo::* namespace

Options
    • -0
    • +9
    /openacs-4/packages/acs-tcl/tcl/00-acs-tcl-init.tcl
    • -1
    • +0
    /openacs-4/packages/acs-tcl/tcl/20-memoize-init.tcl
    • -3
    • +29
    /openacs-4/packages/acs-tcl/tcl/acs-db-00-procs.tcl
    • -7
    • +50
    /openacs-4/packages/acs-tcl/tcl/acs-db-12-procs.tcl
9:27 pm

gustafn

file 00-acs-tcl-init.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-acs-tcl-init.tcl
9:13 pm

gustafn

Make parameter::get_from_package_key usable during inital boot

This change makes parameter::get_from_package_key usable during

initial boot, i.e. before the table apm_parameters is created.

In these cases, the function returns just the default value.

Options
    • -55
    • +71
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
9:11 pm

gustafn

Support memory units as default of the cache sizes

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
8:42 pm

gustafn

update questionable test slightly

Options
    • -11
    • +5
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
7:20 pm

gustafn

Fixes for Oracle 19c: made set_live_revision compatible with postgres version

Options
    • -14
    • +24
    /openacs-4/packages/acs-content-repository/sql/oracle/content-item.sql
    • -2
    • +3
    /openacs-4/packages/acs-content-repository/sql/oracle/packages-create.sql
7:14 pm

antoniop

Fix expression

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
7:09 pm

antoniop

Allow to filters also by timestamp, start or end

Options
    • -34
    • +68
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
6:57 pm

gustafn

file upgrade-5.10.1d5-5.10.1d6.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d5-5.10.1d6.sql
6:55 pm

gustafn

improve wording

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
6:53 pm

gustafn

fix broken function_args definition

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -6
    • +2
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-keyword.sql
    • -0
    • +1
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/postgresql/security-create.sql
    • -0
    • +2
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d5-5.10.1d6.sql
6:53 pm

gustafn

file upgrade-5.10.1d2-5.10.1d3.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
4:56 pm

antoniop

Provide an own translation for "All" that considers the specific item (e.g. for gendering)

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -0
    • +1
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -1
    • +2
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
4:36 pm

antoniop

Changes after review with downstream stakeholders:

- switch "Confirm OK" and "Flag" buttons

- put the two buttons after the comment section

Bonus change: mark unflagged artifacts with comments with a green border

Options
    • -22
    • +30
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
3:45 pm

antoniop

Normalize the way the flag is represented in the JSON

Options
    • -0
    • +4
    /openacs-4/packages/proctoring-support/www/review.tcl
3:03 pm

antoniop

Use a trash can icon, instead of all that yellow

Options
    • -4
    • +4
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
3:01 pm

antoniop

Fix expression again

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
2:40 pm

antoniop

The flag coming from the ajax endpoint is an actual boolean

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
2:31 pm

antoniop

Make the position for the fullscreen preview sticky, and ensure the fullscreen element is positioned as the first body child, so it is put on top and can get as big as possible

Options
    • -4
    • +3
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
1:05 pm

gustafn

Added support for www-toggle-publish-status

This is needed to avoid a bad interaction with [ad_return_url] as it

is used in www-toggle-publish-status in xowiki, since the workflow

definition unsets the actual return_url, which causes ad_return_url to

use the URL leading to this call (m=toggle-publish-status), causing a

redirection loop.

Version number bumped to 5.10.1d28

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +18
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
12:53 pm

gustafn

Added the option to parameterize www-delete and www-toggle-publish-status with return_url

In cases, these www* methods are called programmatically, these can be

now parameterized with an "-return_url" parameter to achieve

e.g. workflow-specific behavior.

Many thanks to Thomas Renner for the analysis on

www-toggle-publish-status.

Version number bumped to 5.10.1d18

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -6
    • +13
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -6
    • +17
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
9:58 am

gustafn

set arguments to type integer to avoid strange variable names

Options
    • -4
    • +4
    /openacs-4/packages/general-comments/tcl/general-comments-procs.tcl