OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 145
Last Commit: 02 May
Commits this week: 18
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Feb 2022
9:27 pm

gustafn

Update of SQL function calling interface to make it usable during initial bootstrap

- add sanity checks and produce error messages,

when function args are incorrect.

- do not throw errors in case it is called before the

table acs_function_args was created (during boot)

- added preliminary "list" call to acs::dc

- added first *-init.tcl to be called after loading

the *-proc.tcl files.

- removed all references to the ::xo::* namespace

Options
    • -0
    • +9
    /openacs-4/packages/acs-tcl/tcl/00-acs-tcl-init.tcl
    • -1
    • +0
    /openacs-4/packages/acs-tcl/tcl/20-memoize-init.tcl
    • -3
    • +29
    /openacs-4/packages/acs-tcl/tcl/acs-db-00-procs.tcl
    • -7
    • +50
    /openacs-4/packages/acs-tcl/tcl/acs-db-12-procs.tcl
9:27 pm

gustafn

file 00-acs-tcl-init.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-acs-tcl-init.tcl
9:13 pm

gustafn

Make parameter::get_from_package_key usable during inital boot

This change makes parameter::get_from_package_key usable during

initial boot, i.e. before the table apm_parameters is created.

In these cases, the function returns just the default value.

Options
    • -55
    • +71
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
9:11 pm

gustafn

Support memory units as default of the cache sizes

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
8:42 pm

gustafn

update questionable test slightly

Options
    • -11
    • +5
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
7:20 pm

gustafn

Fixes for Oracle 19c: made set_live_revision compatible with postgres version

Options
    • -14
    • +24
    /openacs-4/packages/acs-content-repository/sql/oracle/content-item.sql
    • -2
    • +3
    /openacs-4/packages/acs-content-repository/sql/oracle/packages-create.sql
7:14 pm

antoniop

Fix expression

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
7:09 pm

antoniop

Allow to filters also by timestamp, start or end

Options
    • -34
    • +68
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
6:57 pm

gustafn

file upgrade-5.10.1d5-5.10.1d6.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d5-5.10.1d6.sql
6:55 pm

gustafn

improve wording

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
6:53 pm

gustafn

fix broken function_args definition

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -6
    • +2
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-keyword.sql
    • -0
    • +1
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/postgresql/security-create.sql
    • -0
    • +2
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d5-5.10.1d6.sql
6:53 pm

gustafn

file upgrade-5.10.1d2-5.10.1d3.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
4:56 pm

antoniop

Provide an own translation for "All" that considers the specific item (e.g. for gendering)

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -0
    • +1
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -1
    • +2
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
4:36 pm

antoniop

Changes after review with downstream stakeholders:

- switch "Confirm OK" and "Flag" buttons

- put the two buttons after the comment section

Bonus change: mark unflagged artifacts with comments with a green border

Options
    • -22
    • +30
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
3:45 pm

antoniop

Normalize the way the flag is represented in the JSON

Options
    • -0
    • +4
    /openacs-4/packages/proctoring-support/www/review.tcl
3:03 pm

antoniop

Use a trash can icon, instead of all that yellow

Options
    • -4
    • +4
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
3:01 pm

antoniop

Fix expression again

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
2:40 pm

antoniop

The flag coming from the ajax endpoint is an actual boolean

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
2:31 pm

antoniop

Make the position for the fullscreen preview sticky, and ensure the fullscreen element is positioned as the first body child, so it is put on top and can get as big as possible

Options
    • -4
    • +3
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
1:05 pm

gustafn

Added support for www-toggle-publish-status

This is needed to avoid a bad interaction with [ad_return_url] as it

is used in www-toggle-publish-status in xowiki, since the workflow

definition unsets the actual return_url, which causes ad_return_url to

use the URL leading to this call (m=toggle-publish-status), causing a

redirection loop.

Version number bumped to 5.10.1d28

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +18
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
12:53 pm

gustafn

Added the option to parameterize www-delete and www-toggle-publish-status with return_url

In cases, these www* methods are called programmatically, these can be

now parameterized with an "-return_url" parameter to achieve

e.g. workflow-specific behavior.

Many thanks to Thomas Renner for the analysis on

www-toggle-publish-status.

Version number bumped to 5.10.1d18

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -6
    • +13
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -6
    • +17
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
9:58 am

gustafn

set arguments to type integer to avoid strange variable names

Options
    • -4
    • +4
    /openacs-4/packages/general-comments/tcl/general-comments-procs.tcl
9:49 am

gustafn

improve spelling and formulations

Options
    • -9
    • +10
    /openacs-4/packages/acs-tcl/tcl/acs-db-12-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Sunday 20 Feb 2022
8:45 pm

gustafn

Added new interface for calling database functions

This is tested for PostgreSQL and Oracle and the drivers nsdb and nsdbi.

For details, see https://openacs.org/xowiki/calling-database-functions

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -0
    • +179
    /openacs-4/packages/acs-tcl/tcl/acs-db-00-procs.tcl
    • -0
    • +561
    /openacs-4/packages/acs-tcl/tcl/acs-db-12-procs.tcl
8:45 pm

gustafn

file acs-db-00-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/acs-db-00-procs.tcl
8:45 pm

gustafn

file acs-db-12-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/acs-db-12-procs.tcl
6:24 pm

gustafn

Fixes for Oracle 19c: boolean and timestamp handling, *lobs

- fix boolean permission query

- function "now()" does not exist, use "CURRENT_TIMESTAMP" instead

- revived blob and clob handling in "xo::dc dml" since this is needed

for updating

- modernize Oracle offset/limit handling

- added missing "-dbn" attributes for Oracle xo::dc calls

Options
    • -14
    • +14
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
    • -11
    • +12
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
6:09 pm

gustafn

Modernize code

- use dict instead of Tcl array

- prefer char operations instead of match operations

Options
    • -6
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
6:06 pm

gustafn

Fixes for Oracle 19c: boolean and timestamp handling

- a clause "true" is invalid in Oracle SQL (using "1=1" is fine).

- function "now()" does not exist, use "CURRENT_TIMESTAMP" instead

- addressing all attributes in a join via "*" is not allowed, when other

attributes are used as well. Using e.g., "bt.*" is OK.

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -7
    • +7
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
2:18 pm

gustafn

minor cleanup to make code more consistent

Options
    • -17
    • +7
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl