• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reinstate retrieval of the package_id from the connection context in child-resources, the problem was that, when we required a connection context in create_form_page_instance, we did with no information whatsoever, which was then retrieved by e.g. ns_conn, sometimes wrongly (e.g. when one is running under the test package)

    • -0
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Cleanup after each individual test

child-resources has already a package_id, getting it from the connection context makes the includelet susceptible to e.g. package initializations from the outside (see e.g. xowiki link_tests automated test)

    • -1
    • +0
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
Remove 'check_xotcl_xocc' test case, as it has served its purpose already

Ensure a minimal connection context before checking for user_id

    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Cleanup temporary XOTcl objects after test run

Add 'package_id' for tests so it does not need to be guessed

Add 'package_id' for tests so it does not need to be guessed

Add 'check_xotcl_xocc' test case, checking for 'xo::cc'.

The intention of this test is to expose the destruction of the '::xo::cc' object, as a side effect of the 'check_xotcl' test. The test will fail if executed after it, and succeed otherwise.

The object destruction affects other tests executed in the same batch, and breaks in particular xowf's 'create_folder_with_page'.

The 'check_xotcl' test runs the 'Serializer all' method, which is calling 'xo::at_cleanup', destroying the '::xo::cc' object.

- added detailed proctoring options

- accordeon style exam options

- allwo restart in "done" state only for SWAs

    • -3
    • +24
    /openacs-4/packages/xowf/lib/inclass-exam.wf
show action "view" only, when user is swa

show "view" button only, when workflow instance with the current name was already created.

revert escaped change

make proxy exec more compatible with tcl exec: support flags "-ignorestderr" and "--"

    • -2
    • +10
    /openacs-4/packages/acs-tcl/tcl/proxy-procs.tcl
fix bug in javascript, when only the screen-stream should be recorded

improve spelling

Do rollback after test run

stay closer to QTI, use more appropriate labels

fix error message generation

    • -2
    • +2
    /openacs-4/packages/xowf/lib/inclass-exam.wf
improve styling of nested repeated fields (less frames)

Use usual delete symbol for deleting repeat elements

    • -4
    • +5
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
added NSF version to reported version numbers

Prefer 'namespace which' over 'info commands'

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 44 more files in changeset.
Reuse computations

Fix message key for SC/MC question alternatives. Many thanks to Stephan Adelsberger

remove the view action - for the moment we do not need it

Add 'package_id' for tests so it does not need to be guessed

Fix overquoting in english message key

added preview/testrun to edit item workflow

    • -10
    • +57
    /openacs-4/packages/xowf/lib/edit-interaction.wf
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl