OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 28 Nov
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 14 Mar 2019
11:41 am

antoniop

Trim padding from column to be sure

Options
    • -0
    • +3
    /openacs-4/packages/acs-lang/sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
11:23 am

antoniop

Redefine ad_locales.language table column as varchar to avoid Oracle idiosyncrasies when comparing a char(n) with other string datatypes when using bind variables (following insightful LARS's remark)

char(n) in Oracle are automatically padded to be n characters long. Apparently, comparing char(n) -> char(n) is "blanks insensitive", while comparing char(n) -> varchar2(n) will account for such automatically inserted blanks. When using bind variables, one should carefully specify the type to use to avoid surprises with char(n) (for this we should touch the oracle driver), normalize the value via trim/pad all the time or replace every char(n) datatype with varchar2. ...are there other places where this is happening?

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/acs-lang.info
    • -2
    • +2
    /openacs-4/packages/acs-lang/sql/oracle/ad-locales.sql
    • -0
    • +11
    /openacs-4/packages/acs-lang/sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -2
    • +2
    /openacs-4/packages/acs-lang/sql/postgresql/ad-locales.sql
    • -0
    • +11
    /openacs-4/packages/acs-lang/sql/postgresql/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -5
    • +1
    /openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl
11:23 am

antoniop

file upgrade-5.10.0d2-5.10.0d3.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-lang/sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -0
    • +0
    /openacs-4/packages/acs-lang/sql/postgresql/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
Wednesday 13 Mar 2019
11:56 pm

gustafn

fix for issue #3380

Respect production_mode in cases, where pages are created via www-create-new

and a name is provided via query parameter.

Options
    • -1
    • +17
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
6:06 pm

hectorr

Fix message key + bump version number

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -2
    • +2
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
2:37 pm

antoniop

Rewrite the query to leverage transparent variable quoting, replace count with quicker existance check, bring sql inline

Options
    • -2
    • +10
    /openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl
    • -14
    • +0
    /openacs-4/packages/acs-lang/tcl/lang-util-procs.xql
12:51 pm

antoniop

Add remarks about "correct" usage of ad_decode in proc doc

Options
    • -2
    • +15
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
12:36 pm

antoniop

Replace ad_decode idioms, improve legibility

Options
    • -4
    • +5
    /openacs-4/packages/acs-subsite/www/admin/rel-types/new-2.tcl
12:33 pm

antoniop

Replace ad_decode idioms

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/applications/application-add.tcl
12:30 pm

antoniop

Replace ad_decode idiom

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/applications/application-delete.tcl
12:22 pm

antoniop

Replace ad_decode idioms

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/admin/group-types/new.tcl
    • -8
    • +8
    /openacs-4/packages/acs-subsite/www/admin/object-types/one.tcl
12:11 pm

antoniop

Replace ad_decode idioms

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/acs-subsite/lib/login.tcl
    • -2
    • +3
    /openacs-4/packages/acs-subsite/lib/user-info.tcl
12:07 pm

antoniop

Bring back to life edit-history page:

- fix oracle-only limit idiom

- link the page to the UI (again?). Will be in acs-lang/admin

- provide message key for the UI

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/acs-lang.info
    • -0
    • +1
    /openacs-4/packages/acs-lang/catalog/acs-lang.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/acs-lang/catalog/acs-lang.it_IT.ISO-8859-1.xml
    • -10
    • +7
    /openacs-4/packages/acs-lang/www/admin/edit-history.tcl
    • -0
    • +1
    /openacs-4/packages/acs-lang/www/admin/index.adp
11:20 am

antoniop

Replace ad_decode idioms

Options
    • -2
    • +2
    /openacs-4/packages/acs-developer-support/www/request-info.tcl
    • -16
    • +16
    /openacs-4/packages/acs-developer-support/www/index.tcl
11:18 am

antoniop

Whitespace cleanup

Options
    • -14
    • +14
    /openacs-4/packages/acs-content-repository/tcl/publish-procs-oracle.xql
    • -17
    • +17
    /openacs-4/packages/acs-content-repository/tcl/publish-procs-postgresql.xql
11:18 am

antoniop

Prefer db quoting

Options
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/tcl/publish-procs-postgresql.xql
11:17 am

antoniop

Replace ad_decode idiom, prefer db quoting

Options
    • -3
    • +2
    /openacs-4/packages/acs-content-repository/tcl/publish-procs-oracle.xql
11:11 am

antoniop

Replace ad_decode idiom with plain sql

Options
    • -6
    • +7
    /openacs-4/packages/acs-content-repository/tcl/content-keyword-procs.tcl
11:06 am

antoniop

Whitespace cleanup

Options
    • -8
    • +8
    /openacs-4/packages/acs-bootstrap-installer/installer.tcl
11:06 am

antoniop

Replace ad_decode idioms

Options
    • -1
    • +1
    /openacs-4/packages/acs-bootstrap-installer/installer.tcl
11:04 am

antoniop

Replace ad_decode idiom (and keep pleasing Oracle)

Options
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/sync-procs.tcl
10:47 am

antoniop

Whitespace cleanup

Options
    • -6
    • +6
    /openacs-4/packages/acs-admin/www/apm/version-i18n.tcl
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/apm/version-dependencies.tcl
10:45 am

antoniop

Replace ad_decode idioms

Options
    • -7
    • +7
    /openacs-4/packages/acs-admin/www/apm/version-edit.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-i18n.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-i18n-process.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-dependencies.tcl
10:37 am

antoniop

Whitespace cleanup

Options
    • -7
    • +7
    /openacs-4/packages/acs-admin/www/apm/index.tcl
    • -7
    • +7
    /openacs-4/packages/acs-admin/www/apm/version-callback-add-edit.tcl
10:36 am

antoniop

Normalize indentation

Options
    • -8
    • +8
    /openacs-4/packages/acs-admin/www/apm/index.tcl
10:35 am

antoniop

Replace ad_decode idioms

Options
    • -4
    • +3
    /openacs-4/packages/acs-admin/www/apm/index.tcl
    • -2
    • +4
    /openacs-4/packages/acs-admin/www/apm/version-callback-add-edit.tcl
10:32 am

antoniop

Use cached api, bring sql inline, leverage db quoting

Options
    • -8
    • +8
    /openacs-4/packages/acs-admin/www/apm/index.tcl
    • -16
    • +0
    /openacs-4/packages/acs-admin/www/apm/index.xql
10:16 am

antoniop

Replace ad_decode idioms

Options
    • -8
    • +8
    /openacs-4/packages/acs-admin/www/apm/version-view.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-reload.tcl
10:04 am

antoniop

Replace ad_decode idioms

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-callbacks.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-view.tcl
10:00 am

antoniop

Replace ad_decode idioms, improve localization

Options
    • -5
    • +5
    /openacs-4/packages/acs-admin/www/install/install.tcl