• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Subst language before feeding it to the workflow machinery (fixes test)

Validation on 'get_instance_from_db' only

Switch to a sql-only approach (fixes regression)

Move validation block into page contract

    • -9
    • +11
    /openacs-4/packages/chat/www/chat.tcl
Right way to override the fetching of an object is thorugh the fetch query

This would not be necessary once we add acs_object attributes to ::xo::db::Object slots, but as side-effects of this are not clear we leave it for some other time

Chat Redesign: clicking in your own name points to '/pvt/home' instead of '/shared/community-member'

Fix upgrade script

Fix typo

fix site issues #136 and #140

  1. … 317 more files in changeset.
fix site issue #139

Replace old procedural api with OO idioms and deprecate it

    • -11
    • +12
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -2
    • +2
    /openacs-4/packages/chat/tcl/chat-init.tcl
    • -35
    • +25
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -100
    • +0
    /openacs-4/packages/chat/tcl/chat-procs.xql
    • -2
    • +5
    /openacs-4/packages/chat/www/room-delete-2.tcl
    • -2
    • +3
    /openacs-4/packages/chat/www/room-delete.tcl
  1. … 12 more files in changeset.
file upgrade-6.0.0d1-6.0.0d2.sql was initially added on branch oacs-5-10.

Chat Reform: reduce complexity by removing the 'chat_avatar_allow' privilege, 'chat_room_edit' should suffice.

file xotcl-chat-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
Major reform in the chat backend: use xotcl-core ORM to define all the relevant objects and data model

This greatly converges oracle and postgres codebase and will make easier to apply incremental updates to the data model in the future. It will also automatically update the acs_object_type metadata automatically

TODO: remove legacy procs, temporarly reimplemented using the new backend

    • -212
    • +101
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -0
    • +336
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
Remove old commented-out code

    • -221
    • +1
    /openacs-4/packages/chat/tcl/chat-procs.tcl
Replace ad_decode idioms

Replace ad_decode idioms

No need for ad_decode and also no need to count all swas, we just want to know if there is one

Replace ad_decode idioms

Replace ad_decode idiom

Replace ad_decode idioms

Replace ad_decode idioms

Replace ad_decode idioms

Replace ad_decode idioms

Replace ad_decode idioms

    • -2
    • +4
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
Replace ad_decode idiom and unnest expr

Replace ad_decode idiom

Replace ad_decode idioms

Replace ad_decode idiom