• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
strengthen boolean parameters in page contracts

  1. … 28 more files in changeset.
bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
provide hint for the potential source of the problem

In error cases, sometimes code is executed, although there is no connection

to the client open. In such cases, this code should probable not executed.

fix typo in message key

  1. … 15 more files in changeset.
Prefer cached api

fixed misleading documentation

Exploit page contract, rework idioms

Whitespace changes

Replace deprecated api

added "button" class for activity links (port from downstream)

use downstream idiom

Simple fixes pointing to insufficient test cases

Many thanks to Franz Penz for the fixes

Fix/modernize boolean syntax in adp

Deprecate bulk_mail::parameter, which implements a global parameter logic

For now, the occurrences have just been inlined (fixing also the inconsistent naming PrettyName vs pretty_name). A future reform might create a proper global parameter for this.

  1. … 3 more files in changeset.
Whitespace changes

Remove leftover call tpo deprecated api

Deprecate acs_privacy:: api and inline the few usages in the dotlrn packages

See https://openacs.org/forums/message-view?message_id=5672076

  1. … 4 more files in changeset.
Whitespace cleanup

make use of "prevent-double-click"

prefer adp:icon over old-style .gif images, whitespace changes

Quote user provided value in error message to eliminate potential XSS attack vector

harden page contract for referer parameter to avoid hard error from ad_returnredirect

    • -2
    • +2
    ./www/admin/add-edit-site-template.tcl
  1. … 16 more files in changeset.
Cleanup of acs_object_context_index' and friends in creation scripts

This change completes the commit [1] from 2019, where the cleanup was performed

acs_object_context_index and its maintenance functions just as an update script.

This change addresses this also in the creation scripts and in packages, still

depending on the old functions.

[1] https://fisheye.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Ahectorr%3A20190708160122

    • -43
    • +44
    ./sql/postgresql/custom-permissions.sql
  1. … 9 more files in changeset.
Delete obsolete file, which is in fact a universal downloader

Replace deprecated api

Replace deprecated api

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

  1. … 11 more files in changeset.
Deprecate util_commify_number, replace occurrences and translate automated tests

  1. … 9 more files in changeset.
Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
Added comment to clarify what the issue with this code ist