• last updated 13 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Whitespace changes

Remove leftover call tpo deprecated api

Deprecate acs_privacy:: api and inline the few usages in the dotlrn packages

See https://openacs.org/forums/message-view?message_id=5672076

  1. … 4 more files in changeset.
Whitespace cleanup

make use of "prevent-double-click"

prefer adp:icon over old-style .gif images, whitespace changes

Quote user provided value in error message to eliminate potential XSS attack vector

harden page contract for referer parameter to avoid hard error from ad_returnredirect

    • -2
    • +2
  1. … 16 more files in changeset.
Cleanup of acs_object_context_index' and friends in creation scripts

This change completes the commit [1] from 2019, where the cleanup was performed

acs_object_context_index and its maintenance functions just as an update script.

This change addresses this also in the creation scripts and in packages, still

depending on the old functions.

[1] https://fisheye.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Ahectorr%3A20190708160122

    • -43
    • +44
  1. … 9 more files in changeset.
Delete obsolete file, which is in fact a universal downloader

Replace deprecated api

Replace deprecated api

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

  1. … 11 more files in changeset.
Deprecate util_commify_number, replace occurrences and translate automated tests

  1. … 9 more files in changeset.
Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
Added comment to clarify what the issue with this code ist

Fix typo

Handle the case, happening e.g. when installing from repositores, that the cache does not exist yet

Revent experimental change and document it

Fix proc signature

  1. … 6 more files in changeset.
Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

  1. … 6 more files in changeset.
Deprecate notification::get_interval_id, duplicated by notification::interval::get_id_from_name which appears to be more established

  1. … 4 more files in changeset.
make dependency on new try-cache function explicit, bump version to 2.10.1d2

added try_cache (not sure we want this on the longer range)

Harden page contract; Prefer redirect url created via "export_vars" over handcrafted one

tighten page contract

harden page contract

harden page contract

Allow empty anchor

Validate the portal_id via the page contract, keep passing the whole form down as before