antoniop in OpenACS

About

2,163 commits
  • Committer is not mapped to a user
  • First commit: 20 November 2006
  • Last commit: 03 March 2021
Last Week All Time
Commits: 0 2,163
Files changed: 0 3,708
Change in LOC: 0 19,512

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 03 Mar
4:06 pm

antoniop

Port of downstream logic: do not use a hardcoded list of local authorities, but rather check if the authority implementation is local, which would handle also other downstream local authorities

Rework the idiom to perform cheap checks first and improve documentation

Options
    • -9
    • +20
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
3:04 pm

antoniop

Piggyback some more api to existing tests

Options
    • -0
    • +44
    /openacs-4/packages/acs-content-repository/tcl/test/content-search-procs.tcl
2:04 pm

antoniop

Whitespace cleanup

Options
    • -8
    • +8
    /openacs-4/packages/acs-content-repository/tcl/test/content-search-procs.tcl
1:35 pm

antoniop

Fix var name

Options
    • -5
    • +5
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
12:25 pm

antoniop

Creating a user without a username is possible if the authority is local, include the test authority among those for which we generate a username, as it is also local as in "hosted locally"

Fixes acs-authentication.auth_use_email_for_login_p automated test

Options
    • -2
    • +6
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
Thursday 25 Feb
1:30 pm

antoniop

Make api public

Options
    • -2
    • +3
    /openacs-4/packages/dotlrn-portlet/tcl/dotlrn-members-staff-portlet-procs.tcl
11:37 am

antoniop

Add a new subsite::parameter_changed implementation for xowiki, reacting to the switching of the use_hstore parameter

This way it won't be necessary for other packages to generate the hstore manually using private api

Options
    • -11
    • +24
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +22
    /openacs-4/packages/xowiki/tcl/xowiki-callback-procs.tcl
11:35 am

antoniop

Add documentation

Options
    • -2
    • +3
    /openacs-4/packages/dotlrn-portlet/tcl/dotlrn-members-portlet-procs.tcl
11:01 am

antoniop

Reinstate api as private, downstream cases need to be adapted

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl
Wednesday 24 Feb
5:45 pm

antoniop

Make api public: uses public api internally and downstream packages use it

Options
    • -3
    • +7
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
4:52 pm

antoniop

Make api public: downstream xowiki-like packages use it to extend uninstantiation logics

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-callback-procs.tcl
4:47 pm

antoniop

Make proc public: many downstream packages use it e.g. in their upgrade scripts

Options
    • -9
    • +11
    /openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl
4:38 pm

antoniop

Make api public

Options
    • -7
    • +1
    /openacs-4/packages/assessment/tcl/as-item-procs.tcl
3:29 pm

antoniop

Make api public

Options
    • -2
    • +2
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn-portlet/tcl/dotlrn-members-portlet-procs.tcl
Tuesday 23 Feb
5:22 pm

antoniop

We cannot use bind variables here, as the query is not executed at this time, but later at bulk mail sweeping

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/spam.xql
5:18 pm

antoniop

Provide a public general-comments solution to empty messages from a specific package: other xowiki-like packages downstream would otherwise need to call a xowiki private api

Options
    • -1
    • +17
    /openacs-4/packages/general-comments/tcl/general-comments-procs.tcl
    • -23
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-callback-procs.tcl
4:49 pm

antoniop

Formatting changes

Options
    • -8
    • +6
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs-oracle.xql
    • -5
    • +5
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs-postgresql.xql
4:36 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -10
    • +0
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs-oracle.xql
    • -6
    • +0
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs-postgresql.xql
    • -2
    • +5
    /openacs-4/packages/acs-messaging/tcl/acs-messaging-procs.tcl
4:19 pm

antoniop

Whitespace cleanup

Options
    • -24
    • +24
    /openacs-4/packages/general-comments/tcl/general-comments-procs.tcl
4:08 pm

antoniop

Make api public as other packages might need to retrieve the portlet name

Options
    • -2
    • +3
    /openacs-4/packages/calendar-portlet/tcl/calendar-full-portlet-procs.tcl
    • -2
    • +3
    /openacs-4/packages/calendar-portlet/tcl/calendar-list-portlet-procs.tcl
    • -2
    • +3
    /openacs-4/packages/dotlrn-portlet/tcl/dotlrn-portlet-procs.tcl
3:42 pm

antoniop

Flush also the threaded cache whenever we flush the permission cache, so that one does not need to call this private api directly

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
2:16 pm

antoniop

Reinstate get_portal_id_not_cached as private, replace occurrences with public api

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn-static/tcl/dotlrn-static-procs.tcl
2:08 pm

antoniop

Reinstate get_portal_id_not_cached as private, flush the cache before calling public api instead

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
    • -3
    • +4
    /openacs-4/packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
    • -3
    • +4
    /openacs-4/packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -3
    • +4
    /openacs-4/packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl
2:02 pm

antoniop

Fix api:

upstream dotlrn mounts dotlrn-forums at /dotlrn/forums/, but testcase dotlrn_forums__applet_portlet (dotlrn-forums) deletes such node and replaces it with a new one at /dotlrn/applets/forums/. As site_node::get_package_url does not get flushed, the api will expect to find the mounted instance at the old URL, which now resolves to the parent dotlrn instead! Fix this by not relying on the cache to retrieve the applet node id.

Options
    • -4
    • +9
    /openacs-4/packages/dotlrn-forums/tcl/dotlrn-forums-procs.tcl
11:14 am

antoniop

Provide a cached public api, reinstate uncached api as private, replace occurrences

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn-homework/tcl/test/dotlrn-homework-procs.tcl
    • -3
    • +11
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
10:37 am

antoniop

Do not invoke service contract implementations directly, use the public interface

Options
    • -13
    • +18
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
10:35 am

antoniop

Replace deprecated api

Options
    • -3
    • +3
    /openacs-4/packages/feed-parser/tcl/feed-parser-procs.tcl
Monday 22 Feb
8:00 pm

antoniop

- Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK

- Reinstate authentication service contracts as private

- Move test authority implementation to acs-authentication to remove intra-package dependency

acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued

Options
    • -1
    • +16
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
    • -6
    • +6
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
    • -0
    • +133
    /openacs-4/packages/acs-authentication/tcl/test-authority-procs.tcl
    • -133
    • +0
    /openacs-4/packages/acs-automated-testing/tcl/authority-procs.tcl
8:00 pm

antoniop

file test-authority-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-authentication/tcl/test-authority-procs.tcl
7:26 pm

antoniop

Reinstate apis as public, as they hold the current definition of an all-day event

Options
    • -15
    • +9
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-2-procs.tcl