antoniop in OpenACS

About

1,847 commits
  • Committer is not mapped to a user
  • First commit: 20 November 2006
  • Last commit: 31 July 2020
Last Week All Time
Commits: 0 1,847
Files changed: 16 3,580
Change in LOC: 146 19,508

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 31 Jul
7:12 pm

antoniop

Comply with acs-tcl.naming__proc_naming automated test

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/resource-init.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/www/sitewide-admin/download.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/www/sitewide-admin/index.tcl
2:53 pm

antoniop

Whitespace changes

Options
    • -15
    • +2
    /openacs-4/packages/news-aggregator-portlet/tcl/news-aggregator-admin-portlet-procs.tcl
    • -15
    • +3
    /openacs-4/packages/news-aggregator-portlet/tcl/news-aggregator-portlet-procs.tcl
2:49 pm

antoniop

Add basic doc to public api

Options
    • -2
    • +6
    /openacs-4/packages/news-aggregator-portlet/tcl/news-aggregator-admin-portlet-procs.tcl
    • -2
    • +6
    /openacs-4/packages/news-aggregator-portlet/tcl/news-aggregator-portlet-procs.tcl
2:07 pm

antoniop

Redefine foreign key constraints on the na_aggregators table so that there won't be need for package uninstantiation callbacks (as found downstream)

Options
    • -2
    • +2
    /openacs-4/packages/news-aggregator/news-aggregator.info
    • -29
    • +6
    /openacs-4/packages/news-aggregator/sql/postgresql/news-aggregator-packages-create.sql
    • -2
    • +7
    /openacs-4/packages/news-aggregator/sql/postgresql/news-aggregator-tables-create.sql
    • -0
    • +33
    /openacs-4/packages/news-aggregator/sql/postgresql/upgrade/upgrade-0.10d-0.11d.sql
2:05 pm

antoniop

No need to explicitly delete permissions

Options
    • -12
    • +0
    /openacs-4/packages/news-aggregator/sql/postgresql/news-aggregator-packages-drop.sql
2:02 pm

antoniop

Fix typo in drop script

Options
    • -1
    • +1
    /openacs-4/packages/news-aggregator/sql/postgresql/news-aggregator-packages-drop.sql
1:33 pm

antoniop

Move upgrade scripts in the proper directory

Options
    • -84
    • +0
    /openacs-4/packages/news-aggregator/sql/postgresql/upgrade-0.7d-0.8d.sql
    • -5
    • +0
    /openacs-4/packages/news-aggregator/sql/postgresql/upgrade-0.9d-0.10d.sql
    • -0
    • +84
    /openacs-4/packages/news-aggregator/sql/postgresql/upgrade/upgrade-0.7d-0.8d.sql
    • -0
    • +5
    /openacs-4/packages/news-aggregator/sql/postgresql/upgrade/upgrade-0.9d-0.10d.sql
Thursday 30 Jul
6:36 pm

antoniop

Redefine foreign keys as on delete cascade to avoid having callbacks around to delete bulk mail messages on package deletion

Options
    • -2
    • +2
    /openacs-4/packages/bulk-mail/bulk-mail.info
    • -3
    • +3
    /openacs-4/packages/bulk-mail/sql/oracle/bulk-mail-create.sql
    • -0
    • +11
    /openacs-4/packages/bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d1-2.10.0d2.sql
    • -3
    • +3
    /openacs-4/packages/bulk-mail/sql/postgresql/bulk-mail-create.sql
    • -0
    • +9
    /openacs-4/packages/bulk-mail/sql/postgresql/upgrade/upgrade-2.10.0d1-2.10.0d2.sql
6:36 pm

antoniop

file upgrade-2.10.0d1-2.10.0d2.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d1-2.10.0d2.sql
    • -0
    • +0
    /openacs-4/packages/bulk-mail/sql/postgresql/upgrade/upgrade-2.10.0d1-2.10.0d2.sql
4:44 pm

antoniop

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
4:23 pm

antoniop

Port of downstream feature: cleanup properly everything related with a calendar package instance before deleting (e.g. calendar item types)

This might be superseded by just plain referential integrity, taking care also of the oracle part, in a future moment

Options
    • -2
    • +3
    /openacs-4/packages/calendar/calendar.info
    • -3
    • +31
    /openacs-4/packages/calendar/tcl/apm-callback-procs.tcl
3:54 pm

antoniop

Look for the truth

Options
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
Wednesday 29 Jul
1:27 pm

antoniop

Cleanup broken tests from the old good days, timezone features in acs-lang are already tested in lang_test__lc_procs

Options
    • -2
    • +0
    /openacs-4/packages/acs-lang/www/admin/test/index.html
    • -59
    • +0
    /openacs-4/packages/acs-lang/www/admin/test/timezone.adp
    • -75
    • +0
    /openacs-4/packages/acs-lang/www/admin/test/timezone.tcl
    • -11
    • +0
    /openacs-4/packages/acs-lang/www/admin/test/timezone.xql
Friday 24 Jul
2:36 pm

antoniop

Basic automated test for acs_admin::require_site_wide_subsite and acs_admin::require_site_wide_package

Options
    • -1
    • +35
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
2:19 pm

antoniop

Move deprecated stuff in util-procs to deprecated-procs

This has the advantage that their loading can be disabled in the settings

Options
    • -2
    • +669
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -667
    • +1
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
2:10 pm

antoniop

Reduce acs-tcl.documentation__check_deprecated_see test warnings

Options
    • -1
    • +6
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
2:06 pm

antoniop

Reduce acs-tcl.documentation__check_deprecated_see test warnings

Options
    • -3
    • +5
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
1:50 pm

antoniop

Reduce acs-tcl.documentation__check_deprecated_see test warnings

Options
    • -1
    • +5
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -2
    • +11
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -1
    • +5
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
1:46 pm

antoniop

Unset the right nsv in the test or leftover dummy proc names will make acs-tcl.naming__proc_naming test fail

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
Wednesday 22 Jul
2:34 pm

antoniop

Provide doc for ns_dbquotelist when is tcl implemented as fallback (fixes documentation__check_proc_doc automated test)

Options
    • -5
    • +10
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
2:28 pm

antoniop

Implement a flush method for ::acs::acs::LockfreeCache and use it to reimplement permission::permission_thread_cache_flush

This fixes ad_proc_permission_grant_and_revoke test case

Options
    • -0
    • +8
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
1:49 pm

antoniop

Keep using ad_conn in lang::conn::timezone as set_get_timezone needs to simulate lack of connection and ad_conn allows to override the "real" value

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/locale-procs.tcl
1:31 pm

antoniop

Comment debug code working only on latest Naviserver

Options
    • -5
    • +5
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
Monday 06 Jul
3:55 pm

antoniop

Document current preferred idiom to quote database lists, without official deprecation, for the time being

Options
    • -1
    • +7
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
Wednesday 17 Jun
5:33 pm

antoniop

Comment out seemingly useless computation which has been detected running > 18s in some case on the live system

Options
    • -4
    • +10
    /openacs-4/packages/assessment/tcl/as-checks-procs.tcl
5:16 pm

antoniop

Whitespace cleanup

Options
    • -88
    • +88
    /openacs-4/packages/assessment/tcl/as-checks-procs.tcl
Wednesday 10 Jun
10:56 am

antoniop

Reinstate check, add a note why

Options
    • -5
    • +8
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Wednesday 03 Jun
8:41 pm

antoniop

ad_urlencode_url: add a slash to the path when this is not empty, fix test case

Options
    • -5
    • +9
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
8:14 pm

antoniop

Extend test

Options
    • -0
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
8:02 pm

antoniop

Avoid useless check

Options
    • -7
    • +5
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl