antoniop in OpenACS

About

4,233 commits
  • Committer is not mapped to a user
  • First commit: 20 November 2006
  • Last commit: 20 December 2024
Last Week All Time
Commits: 0 4,233
Files changed: 0 4,748
Change in LOC: 0 30,271

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 20 Dec 2024
1:14 pm

antoniop

Cleanup stale sse connections

Options
    • -1
    • +1
    /openacs-4/packages/notifications/tcl/notification-sse-procs.tcl
    • -1
    • +6
    /openacs-4/packages/notifications/tcl/sweep-init.tcl
    • -1
    • +16
    /openacs-4/packages/notifications/tcl/sweep-procs.tcl
Thursday 19 Dec 2024
5:59 pm

antoniop

Introduce a new delivery method for notifications based on Server Sent events

By subscribing to /notifications/sse/subscribe one will receive notifications as JSON messages. This can be used e.g. to update a UI in real time based on events on the system.

Options
    • -2
    • +2
    /openacs-4/packages/notifications/notifications.info
    • -1
    • +63
    /openacs-4/packages/notifications/tcl/apm-callback-procs.tcl
    • -0
    • +245
    /openacs-4/packages/notifications/tcl/notification-sse-procs.tcl
    • -0
    • +10
    /openacs-4/packages/notifications/www/sse/subscribe.tcl
Tuesday 17 Dec 2024
6:32 pm

antoniop

Retrieving the datasource should not depend on the fact that a driver is configured

Options
    • -2
    • +2
    /openacs-4/packages/search/search.info
    • -8
    • +6
    /openacs-4/packages/search/tcl/search-procs.tcl
Thursday 05 Dec 2024
5:13 pm

antoniop

Compute the columns as weel when creating a multirow from a list

Options
    • -2
    • +6
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
5:12 pm

antoniop

Test converting to and from a multirow and a list

The test reveals that when converting a list into a multirow, the columns will not be set correctly

Options
    • -1
    • +53
    /openacs-4/packages/acs-templating/tcl/test/util-procs.tcl
4:34 pm

antoniop

title always exists now, ensure it is not empty instead

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-sc-procs.tcl
Tuesday 03 Dec 2024
9:51 am

antoniop

Fix possible typo

See https://openacs.org/forums/message-view?message_id=7236544

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/groups-body-create.sql
Thursday 28 Nov 2024
12:28 pm

antoniop

Introduce the toolbar parameter at the richtext superclass level, so

that formpages created with editors expecting this spec, like ckeditor4,

will not fail to load using other editors that do not expect it

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
Wednesday 27 Nov 2024
4:55 pm

antoniop

db quote via the api

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
Tuesday 26 Nov 2024
11:40 am

antoniop

Do not omit line breaks when rendering text interactions as textareas, e.g. in exam protocols

Many thanks to Markus Moser

Options
    • -0
    • +1
    /openacs-4/packages/xowf/www/resources/test-item.css
Monday 25 Nov 2024
5:24 pm

antoniop

Initializing a formfield with an invalid spec fails as expected, however, it appears to leave behind the formfield object, which many automated tests will now consider a failure

Ensure the formfield object is destroyed when reading the spec fails

Options
    • -2
    • +11
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
5:22 pm

antoniop

Make the search datasource callback more robust in case pages are broken or otherwise invalid (but complain about it)

Options
    • -9
    • +28
    /openacs-4/packages/xowiki/tcl/xowiki-sc-procs.tcl
3:46 pm

antoniop

Cast to correct datatypes, delete broken placeholder query

Options
    • -3
    • +3
    /openacs-4/packages/new-portal/tcl/portal-callback-procs.tcl
3:28 pm

antoniop

Better initialize the datasource for those object that won't return the full set of expected fields

Options
    • -1
    • +4
    /openacs-4/packages/search/tcl/search-procs.tcl
3:16 pm

antoniop

Add missing return

Options
    • -1
    • +2
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
3:16 pm

antoniop

Tolerate non-existing files, but throw a warning

Options
    • -1
    • +5
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
Thursday 21 Nov 2024
5:34 pm

antoniop

Allow HTML in the default value for parameters, as this could contain markup, e.g. , if the value is some kind of snippet.

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/parameter-edit-2.tcl
3:51 pm

antoniop

Further collect callback logics into procs and test them

Options
    • -2
    • +2
    /openacs-4/packages/search/search.info
    • -4
    • +44
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -1
    • +18
    /openacs-4/packages/search/tcl/test/search-procs.tcl
    • -21
    • +13
    /openacs-4/packages/search/www/search.tcl
2:27 pm

antoniop

Further cleanup of the indexer logics

- unindexing an object in an own proc

- clarified idioms

- cleanup redundant operations

Options
    • -56
    • +60
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -0
    • +5
    /openacs-4/packages/search/tcl/test/search-procs.tcl
1:49 pm

antoniop

Claim coverage, bump version number

Options
    • -2
    • +2
    /openacs-4/packages/search/search.info
    • -2
    • +2
    /openacs-4/packages/search/tcl/test/search-procs.tcl
1:47 pm

antoniop

Factor some of the logic in the indexer into own procs for the purpose of:

- being able to tell programmatically if an object can be indexed

- being able to index an object programmatically using a simpler api

- better test operations

Options
    • -87
    • +126
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -0
    • +42
    /openacs-4/packages/search/tcl/test/search-procs.tcl
Wednesday 20 Nov 2024
4:33 pm

antoniop

Rework file-to-text conversion with the goal of:

- also for LibreOffice documents, strip the XML from extracted content

- handle errors all at once outside the switch, as the behavior would always be the same

- avoid creating a tempfile

Options
    • -142
    • +125
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
Thursday 14 Nov 2024
6:01 pm

antoniop

Fix more confusion

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
5:54 pm

antoniop

Fix rather confusing name of javascript library file

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
1:02 pm

antoniop

Ensure the namespace exists for template::form::export

Options
    • -1
    • +4
    /openacs-4/packages/acs-templating/tcl/deprecated-procs.tcl
Thursday 07 Nov 2024
12:54 pm

antoniop

Extend user_message feature so that a "severity" information can be passed alongside the message

This allows theme templates to color code messages according to their severity. Severity follows the Bootstrap nomenclature of "info", "success", "warning" and "danger".

Default severity has been set to "success" consistent with styling applied so far by OpenACS to the user messages.

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -4
    • +14
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -5
    • +4
    /openacs-4/packages/openacs-bootstrap3-theme/openacs-bootstrap3-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/masters/plain-master.adp
    • -5
    • +4
    /openacs-4/packages/openacs-bootstrap5-theme/openacs-bootstrap5-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/plain-master.adp
    • -3
    • +4
    /openacs-4/packages/openacs-default-theme/openacs-default-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-default-theme/lib/plain-master.adp
    • -10
    • +27
    /openacs-4/packages/openacs-default-theme/www/resources/styles/default-master.css
Wednesday 06 Nov 2024
4:51 pm

antoniop

Bring existing doc into the object's documentation, so that tests would not fail...

Options
    • -8
    • +9
    /openacs-4/packages/acs-subsite/tcl/group-init.tcl
    • -16
    • +20
    /openacs-4/packages/xowf/tcl/iprange-init.tcl
1:59 pm

antoniop

Deprecate template::list::csv_quote and replace its usages in packages that we have been supporting

Options
    • -2
    • +6
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -16
    • +14
    /openacs-4/packages/contacts/www/admin/full-organizations.tcl
    • -15
    • +14
    /openacs-4/packages/contacts/www/admin/full-people.tcl
    • -12
    • +10
    /openacs-4/packages/contacts/www/admin/full-rels.tcl
1:37 pm

antoniop

Introduce a new "label_headers" flag for template::list::write_csv that allows to revert to behavior before https://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20080908165252, e.g. use the column names as headers rather than the labels

For some use cases is in fact more useful to have machine-readable headers, e.g. when processing the csv via software

Options
    • -2
    • +11
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
1:18 pm

antoniop

Rely on the csv Tcllib package to generate a csv from a template::list

Options
    • -7
    • +12
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl