antoniop in OpenACS

4:03 pm

antoniop

Make sure a non-empty return URL is always provided when downloading a zipfile, or the javascript idiom implementing the redirect would return to the page itself and restart the archiving from scratch

- -1
- +11
/openacs-4/packages/file-storage/www/download-zip.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/download-zip.tcl
- -4
- +7
/openacs-4/packages/file-storage/www/folder-chunk.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/folder-chunk.tcl

3:48 pm

antoniop

Fix typo, increase api coverage

- -1
- +1
/openacs-4/packages/file-storage/tcl/file-storage-procs.xql
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.xql
- -1
- +5
/openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.tcl

5:32 pm

antoniop

Improve doc

- -2
- +6
/openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/05-db-procs.tcl

5:27 pm

antoniop

"timestamp with time zone" is the name of a DBMS datatype, needs to be spelled this way

- -2
- +2
/openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/05-db-procs.tcl

4:52 pm

antoniop

Add explicit level to uplevel occurrences

- -5
- +5
/openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/aa-test-procs.tcl

4:11 pm

antoniop

Make sorting more robust to invalid sorting criteria: instead of failing, ignore them and report the condition as a warning

- -8
- +14
/openacs-4/packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl
- History
- Source
- Diff
/openacs-4/.../20-Ordered-Composite-procs.tcl

2:23 pm

antoniop

Extend page contract, modernize tcl

- -5
- +6
/openacs-4/packages/dotlrn-homework/www/master.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/master.tcl

2:16 pm

antoniop

Add page contract

- -7
- +6
/openacs-4/packages/new-portal/www/themes/kelp-theme/site-master-kelp.tcl
- History
- Source
- Diff
/openacs-4/packages/.../site-master-kelp.tcl
- -0
- +6
/openacs-4/packages/dotlrn-homework/www/master.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/master.tcl

2:13 pm

antoniop

Improve doc

- -0
- +2
/openacs-4/packages/acs-templating/lib/body_scripts.tcl
- History
- Source
- Diff
/openacs-4/packages/.../lib/body_scripts.tcl

2:12 pm

antoniop

Add include contract

- -0
- +4
/openacs-4/packages/acs-templating/lib/body_scripts.tcl
- History
- Source
- Diff
/openacs-4/packages/.../lib/body_scripts.tcl

2:05 pm

antoniop

change_locale is actually a property of this master that is supplied by the slaves, not a part of the page contract

- -1
- +4
/openacs-4/packages/categories/www/cadmin/master.tcl
- History
- Source
- Diff
/openacs-4/packages/.../cadmin/master.tcl

1:47 pm

antoniop

Add page contract

- -6
- +5
/openacs-4/packages/categories/lib/categorize.tcl
- History
- Source
- Diff
/openacs-4/packages/.../lib/categorize.tcl

1:39 pm

antoniop

Fix typo

- -1
- +1
/openacs-4/packages/proctoring-support/tcl/safe-exam-browser-procs.tcl
- History
- Source
- Diff
/openacs-4/.../safe-exam-browser-procs.tcl

6:56 pm

antoniop

Unwrap fake oneliners

- -8
- +30
/openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../text-html-procs.tcl

6:51 pm

antoniop

Fix typo

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../text-html-procs.tcl

6:46 pm

antoniop

Whitespace cleanup

- -9
- +9
/openacs-4/packages/xowiki/tcl/package-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/package-procs.tcl

6:46 pm

antoniop

State dependecny from package-procs, or ::xowiki::CSS class won't be available to this library at boot

- -1
- +3
/openacs-4/packages/xowiki/tcl/form-field-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../form-field-procs.tcl

7:10 pm

antoniop

Cache the information about a package being a singleton and expose into a private api, use the api in parameter::get_from_package_key, called quite often in our downstream pages