OpenACS / openacs-4 / packages / acs-templating

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 46
Last Commit: 16:56
Commits this week: 1
Total Lines of Code (LoC): 24,955
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 Apr 2022
10:43 am

gustafn

Generalized ADP compilation caching, simplified handling of ad_init

Generalized adp-compilation caching

* since the result of ADP compilation can depend on the icon set

(and maybe more factors in the future), and the icon set

can be switched freely, either one needs more ADP compilation

at runtime (page rendering time) or caching had to be generalized.

* generalization of caching leads to better scalability, and

since the number of icon sets concurrently active at one

site is limited, this option seems favorable.

* The only potential incompatibility might be from installations

doing "manual" incantations of "template::adp_init" followed by

direct calls of the stub. The only packages (out of the 365

packages in CVS) effected by this are "diagram" and

"workflow". Both have been fixed in the repository. This

incantation can be simplified as followed.

Simplified handling of adp_init

* old:

template::adp_init adp $file_stub

template::code::adp::$file_stub

* new

[template::adp_init adp $file_stub]

Bumped version to 5.10.1d8

Options
    • -8
    • +7
    ./form-procs.tcl
    • -29
    • +26
    ./list-procs.tcl
    • -46
    • +103
    ./parse-procs.tcl
  4. … 1 more file in changeset.
Monday 11 Apr 2022
3:58 pm

hectorr

Make 'template::adp_compile_chunk' public, as it is used by the new 'xowiki::adp_parse_tags'

Options
    • -2
    • +2
    ./parse-procs.tcl
3:19 pm

gustafn

in case an icon name is mapped to the empty string in some iconset, use the title text instead of an icon

Options
    • -0
    • +5
    ./style-procs.tcl
    • -5
    • +12
    ./tag-init.tcl
Saturday 09 Apr 2022
5:18 pm

gustafn

extend registered names for adp:icons

Options
    • -1
    • +9
    ./tag-init.tcl
Friday 08 Apr 2022
12:36 pm

gustafn

added "form-info-sign" and "download" icon to gyphicon/bi compatibility mapping

Options
    • -1
    • +4
    ./tag-init.tcl
Thursday 07 Apr 2022
2:39 pm

gustafn

separating naviserver and aolserver specific files

Options
    • -0
    • +20
    ./parse-procs-aolserver.tcl
    • -0
    • +20
    ./parse-procs-naviserver.tcl
    • -11
    • +5
    ./parse-procs.tcl
2:39 pm

gustafn

file parse-procs-aolserver.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./parse-procs-aolserver.tcl
2:39 pm

gustafn

file parse-procs-naviserver.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./parse-procs-naviserver.tcl
2:38 pm

gustafn

Improved toolkit support for homogeneous theming and appearance

This change included new tags for rendering icons and toggles. The

change makes it possible that an unchanged markup of icons can be

adapt itself according to a theme or a manual configuration. One can

use e.g. for Bootstrap 3 glyphicons, and when changing the theme to

Bootstrap 5, then bootstrap icons are used.

Furthermore, the new markup eases maintenance and helps to achieve a

consistent look-and-feel also, when design decisions are altered.

Both, bootstrap-icons and glyphicons are font-based. This leads as

well to a better user experience, since the number of requests are

substantially lower than with the previous approach based on .gif and

.png files. When the iconset is set to "classic" (package parameter in

acs-subsite), the old image files are used.

- new tag: <adp:icon name="NAME" title="..." style="..." class="...">

Icon-names available for all iconsets:

edit

trash

radio-checked

radio-unchecked

checkbox-checked

checkbox-unchecked

arrow-down

arrow-up

The page acs-admin/package/bootstrap-icons/sample contains more

detailed information, including the names which are identical

between bootstrap 3 and 5.

- bumped version number of acs-templating to 5.10.1d6

Options
    • -0
    • +110
    ./style-procs.tcl
    • -1
    • +63
    ./tag-init.tcl
  3. … 1 more file in changeset.
2:38 pm

gustafn

file style-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./style-procs.tcl
Thursday 31 Mar 2022
6:36 pm

antoniop

Improve doc

Options
    • -6
    • +7
    ./element-procs.tcl
6:33 pm

antoniop

Replace the lame template::util::get_opts with some homemade utility that will parse arguments reliably, adjust the one upstream use case where arguments other than those documented might be passed to the element creation, introduce a warning when this happens somewhere else

Options
    • -2
    • +82
    ./element-procs.tcl
  2. … 1 more file in changeset.
6:23 pm

antoniop

Fix test, the proc behaves as documented (and IMO, it should go away at some point)

Options
    • -2
    • +7
    ./test/util-procs.tcl
2:59 pm

antoniop

New test for template::util::get_opts

This will expose a bug when an argument in an even position is specified that starts with a "-" character

Options
    • -1
    • +32
    ./test/util-procs.tcl
Wednesday 30 Mar 2022
10:34 am

trenner

not necessary to check if format is a list

Options
    • -1
    • +1
    ./richtext-procs.tcl
9:59 am

trenner

move the check for the provided format on richtext level

Options
    • -0
    • +4
    ./richtext-procs.tcl
    • -4
    • +2
    ./widget-procs.tcl
Tuesday 29 Mar 2022
1:01 pm

trenner

increase robustness

Options
    • -2
    • +4
    ./widget-procs.tcl
Monday 07 Feb 2022
5:12 pm

antoniop

Be stricter when validating widgets with restricted options: when no options are specified, treat it as automatic failure

Options
    • -5
    • +11
    ./data-procs.tcl
Monday 31 Jan 2022
12:13 pm

antoniop

Compute amplitude and wavelength explicitly in pixels and make it stable with respect to the captcha size, introduce a random offset for the wave instead

Fixes acs-templating.tesseract_cannot_crack_catpcha automated test

Options
    • -3
    • +8
    ./captcha-procs.tcl
Sunday 30 Jan 2022
3:38 pm

gustafn

Minor modernization

- use atomic stack operations to reduce locks and avoid race conditions

- improve spelling

- break overlong lines

- better align comments with actual code

Options
    • -3
    • +3
    ./date-procs.tcl
    • -36
    • +61
    ./parse-procs.tcl
    • -1
    • +1
    ./test/captcha-procs.tcl
Friday 28 Jan 2022
10:28 am

antoniop

Drop the pointsize parameter, use size instead, yielding more predictable results across Imagemagik versions and more controllable in general, make the wavelength randomized in the distortion

Options
    • -10
    • +12
    ./captcha-procs.tcl
    • -3
    • +13
    ./test/captcha-procs.tcl
Thursday 27 Jan 2022
10:23 am

antoniop

Deprecate template::util::tcl_to_sql_list, completely replaced by ns_dbquotelist, a native NaviServer command

Options
    • -1
    • +23
    ./deprecated-procs.tcl
    • -24
    • +1
    ./util-procs.tcl
    • -32
    • +1
    ./test/parse-test-procs.tcl
  4. … 15 more files in changeset.
9:22 am

antoniop

Improve test portability

Options
    • -1
    • +1
    ./test/captcha-procs.tcl
9:20 am

antoniop

Baseline test of captcha robustness: challenge the captcha using tesseract, also applying basic normalizations

Options
    • -0
    • +48
    ./test/captcha-procs.tcl
9:18 am

antoniop

Fail when no value is specified

Options
    • -4
    • +3
    ./captcha-procs.tcl
9:12 am

antoniop

Fix tests according to new behavior

Options
    • -6
    • +15
    ./test/captcha-procs.tcl
8:26 am

antoniop

Improve behavior: invalidate the captcha when the check fails, cleanup expired captcha also when a new one is generated

Options
    • -10
    • +22
    ./captcha-procs.tcl
Wednesday 26 Jan 2022
6:28 pm

antoniop

Test newly introduced api

Options
    • -0
    • +94
    ./test/captcha-procs.tcl
6:28 pm

antoniop

file captcha-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/captcha-procs.tcl
5:06 pm

antoniop

A simple image captcha implementation:

a random text is converted to a distorted image, its checksum, together with the expected text are stored in a lookup table. Upon validation, the text input by the user is matched against the checksum to determine if the captcha is correct.

Plan is to use it downstream on certain publicly available contact forms.

Options
    • -0
    • +207
    ./captcha-procs.tcl
  2. … 8 more files in changeset.