OpenACS / openacs-4 / packages / acs-templating

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 46
Last Commit: 16:56
Commits this week: 1
Total Lines of Code (LoC): 24,955
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 27 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 Aug 2022
10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

Options
    • -19
    • +4
    ./file-procs.tcl
  2. … 2 more files in changeset.
Tuesday 23 Aug 2022
5:39 pm

antoniop

Incorporate feedback from downstream penetration tests:

do not skip basic validation in the file widget when a tmpfile is not found in the request.

Options
    • -47
    • +54
    ./file-procs.tcl
Sunday 14 Aug 2022
10:05 am

gustafn

extended adp:icon handling

Added support for multiple classes,

Added more potentially reusabel icon names,

bumped version to 5.10.1d13

Options
    • -3
    • +4
    ./style-procs.tcl
    • -2
    • +6
    ./tag-init.tcl
  3. … 1 more file in changeset.
Saturday 13 Aug 2022
3:55 pm

gustafn

extended generic names by "user" and "list-alt"

Options
    • -1
    • +9
    ./tag-init.tcl
Thursday 11 Aug 2022
1:05 pm

gustafn

whitespace changes

Options
    • -50
    • +50
    ./tag-init.tcl
1:01 pm

gustafn

added new generic icon name: add-new-item

Options
    • -1
    • +5
    ./tag-init.tcl
1:00 pm

gustafn

prefer parameter::get_from_package_key over fetching package_id first

Options
    • -7
    • +9
    ./template-init.tcl
Sunday 26 Jun 2022
9:30 pm

gustafn

fix false positive of regression test

Options
    • -1
    • +1
    ./richtext-procs.tcl
1:06 pm

gustafn

removed code factored out to the separate "captcha" package

Options
    • -353
    • +0
    ./captcha-procs.tcl
    • -163
    • +0
    ./test/captcha-procs.tcl
  3. … 10 more files in changeset.
Saturday 25 Jun 2022
2:05 pm

gustafn

improve comments, such that is is clear what command to use instead

Options
    • -4
    • +4
    ./deprecated-procs.tcl
2:05 pm

gustafn

deactivate captcha test for the time being

Options
    • -0
    • +1
    ./test/captcha-procs.tcl
Wednesday 22 Jun 2022
10:42 am

antoniop

Constrain captcha width to 100% of its parent's size

Options
    • -1
    • +1
    ./captcha-procs.tcl
Wednesday 15 Jun 2022
8:54 pm

gustafn

whitespace changes

Options
    • -8
    • +8
    ./parse-procs.tcl
8:48 pm

gustafn

reduce useless warnings for template::adp_parse_tags

The problem was that template::adp_compile_chunk produces no output, when the parsed chunk contains only whitespace,

causing an error message in this case. The changed method shortcuts the behavior.

Options
    • -4
    • +7
    ./parse-procs.tcl
Monday 02 May 2022
2:03 pm

antoniop

Fix missing variable

Options
    • -1
    • +1
    ./captcha-procs.tcl
Thursday 28 Apr 2022
12:59 pm

antoniop

Fix typo

Options
    • -2
    • +1
    ./captcha-procs.tcl
Wednesday 27 Apr 2022
6:43 pm

antoniop

Provide an alternative exec-free captcha implementation using libgd and its Tcl wrapper https://github.com/flightaware/tcl.gd

This implementation will be preferred to the one using convert, when available.

Options
    • -23
    • +152
    ./captcha-procs.tcl
  2. … 1 more file in changeset.
Thursday 21 Apr 2022
1:34 pm

antoniop

Cleanup dummy commands and objects to avoid cross interactions between tests

Options
    • -0
    • +1
    ./test/captcha-procs.tcl
  2. … 1 more file in changeset.
Wednesday 20 Apr 2022
3:49 pm

antoniop

Go back supporting arbitrary options, potentially from custom user-defined widgets: these will be assumed to be expressed as name-value pairs and we will keep notifying such cases in the logfile

Options
    • -8
    • +44
    ./element-procs.tcl
11:58 am

gustafn

whitespace changes

Options
    • -61
    • +71
    ./test/parse-test-procs.tcl
10:51 am

gustafn

revive delete regression test (was formerly in xowiki)

Options
    • -1
    • +25
    ./test/parse-test-procs.tcl
9:16 am

antoniop

Keep supporting also the htmlarea_p option

Options
    • -1
    • +7
    ./element-procs.tcl
8:52 am

antoniop

Fix doc

Options
    • -2
    • +2
    ./element-procs.tcl
8:51 am

antoniop

Keep handling also the section option

Options
    • -1
    • +5
    ./element-procs.tcl
8:09 am

antoniop

Keep recognizing "format" template::element property, which was never documented

Options
    • -1
    • +8
    ./element-procs.tcl
Tuesday 19 Apr 2022
7:35 pm

gustafn

completed generic icon tables

Options
    • -2
    • +2
    ./style-procs.tcl
    • -4
    • +14
    ./tag-init.tcl
2:49 pm

gustafn

added filetype-csv to generic icon names

Options
    • -1
    • +5
    ./tag-init.tcl
  2. … 1 more file in changeset.
1:55 pm

gustafn

reduce verbosity and inprove spelling

Options
    • -3
    • +3
    ./parse-procs.tcl
    • -1
    • +1
    ./style-procs.tcl
Monday 18 Apr 2022
10:56 am

gustafn

Added support for fa-icons to the generic names for adp:icon

Added new options "iconset" and "alt" to adp:icon, updated

documentation in API browser

Bumped version to 5.10.1d9

Options
    • -9
    • +38
    ./style-procs.tcl
    • -22
    • +42
    ./tag-init.tcl
  3. … 1 more file in changeset.
10:43 am

gustafn

Generalized ADP compilation caching, simplified handling of ad_init

Generalized adp-compilation caching

* since the result of ADP compilation can depend on the icon set

(and maybe more factors in the future), and the icon set

can be switched freely, either one needs more ADP compilation

at runtime (page rendering time) or caching had to be generalized.

* generalization of caching leads to better scalability, and

since the number of icon sets concurrently active at one

site is limited, this option seems favorable.

* The only potential incompatibility might be from installations

doing "manual" incantations of "template::adp_init" followed by

direct calls of the stub. The only packages (out of the 365

packages in CVS) effected by this are "diagram" and

"workflow". Both have been fixed in the repository. This

incantation can be simplified as followed.

Simplified handling of adp_init

* old:

template::adp_init adp $file_stub

template::code::adp::$file_stub

* new

[template::adp_init adp $file_stub]

Bumped version to 5.10.1d8

Options
    • -8
    • +7
    ./form-procs.tcl
    • -29
    • +26
    ./list-procs.tcl
    • -46
    • +103
    ./parse-procs.tcl
  4. … 1 more file in changeset.