OpenACS / openacs-4 / packages / acs-templating

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 46
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 24,955
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 27 Oct
7:19 pm

gustafn

map in adp:button fro bootstrap5 only selectively data attribute names

Options
    • -5
    • +8
    ./tag-init.tcl
  2. … 1 more file in changeset.
12:38 pm

gustafn

This change intruduces <adp:button>, which avoids adp:* markup inside

HTML attribute values, which we had before. One can now use

<adp:button type="submit" class="btn btn-outline-secondary">Filter</adp:button>

instead of

<button type="submit" class="btn <adp:class name='btn-outline-secondary'>">Filter</button>

One should probably provide in the future more adp:* tags for

providing a clean mapping of CSS class attributes.

<adp:class> was deactivated for the time being

Options
    • -10
    • +46
    ./tag-init.tcl
  2. … 3 more files in changeset.
Friday 25 Oct
11:50 am

gustafn

factor out some w3css styling and make it available via template::CSS

Options
    • -37
    • +50
    ./style-procs.tcl
    • -1
    • +13
    ./tag-init.tcl
  3. … 1 more file in changeset.
Thursday 24 Oct
7:02 pm

gustafn

Move functionality of xowiki::CSS to tempate::CSS

template CSS provides an abstraction for CSS class names and other

styling elements depending on user preferences or on the current theme

Backwards compatibility for xowiki::CSS was provided via a stub function

Options
    • -4
    • +262
    ./style-procs.tcl
  2. … 22 more files in changeset.
Wednesday 16 Oct
11:21 am

gustafn

Added code to skip suspicious looking query variables

On openacs.org, we are experiencing numerous requests with

multiply very long and strange query variables like in the example

below. So far, it is not clear, whether these requests are the

consequence of a double encoding or a deliberate attack. Many (most)

of the requests contain the query variable names containing the

(decoded) pattern "*amp;*".

This is a relatively new phenomenon. I cannot exclude that this is a

bug introduced lately in OpenACS, or a bug in an external bot, or

whatever. The problem with these query variables is that OpenACS

propagates these further, e.g., when updating query variables in

ad_dimensional, via export_vars, or return_urls.

Since OpenACS never uses these query-variables, these can be safely

skipped, without loosing functionality in OpenACS. It is possible to

construct examples, where skipping such variables can change the

semantics. Therefore, the change introduces a single function

util::suspicious_query_variable where in case of problems, the

skipping feature can be deactivated.

GET /api-doc/proc-browse?amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp;type=All&amp;amp%3btype=All&amp;amp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=Private&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp;amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All HTTP/1.1" 200 62378 "" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/605.1.15 (KHTML, like Gecko; compatible; FriendlyCrawler/1.0) Chrome/120.0.6099.216 Safari/605.1.15" "1729029614.331581 0.109805 0.000434 0.004026 0.215927

Options
    • -1
    • +8
    ./dimensional-procs.tcl
  2. … 6 more files in changeset.
Tuesday 08 Oct
4:26 pm

antoniop

Modernize tcl idioms

Options
    • -11
    • +8
    ./query-procs.tcl
4:20 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -7
    • +7
    ./head-procs.tcl
    • -2
    • +2
    ./list-procs.tcl
    • -3
    • +3
    ./query-procs.tcl
  4. … 1 more file in changeset.
Tuesday 01 Oct
2:44 pm

gustafn

tcl9 changes: "string bytelength" does not exist in tcl9

Options
    • -2
    • +7
    ./element-procs.tcl
  2. … 1 more file in changeset.
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./0-acs-templating-procs.tcl
    • -0
    • +0
    ./acs-integration-procs.tcl
    • -0
    • +0
    ./data-procs.tcl
    • -0
    • +0
    ./date-procs.tcl
    • -0
    • +0
    ./deprecated-procs.tcl
    • -0
    • +0
    ./dimensional-procs.tcl
    • -0
    • +0
    ./doc-procs.tcl
    • -0
    • +0
    ./doc-tcl-procs.tcl
    • -0
    • +0
    ./element-procs.tcl
    • -0
    • +0
    ./filter-procs.tcl
    • -0
    • +0
    ./form-procs.tcl
    • -0
    • +0
    ./list-procs.tcl
    • -0
    • +0
    ./paginator-procs.tcl
    • -0
    • +0
    ./parse-procs.tcl
    • -0
    • +0
    ./query-procs.tcl
  16. … 1450 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -14
    • +26
    ./0-acs-templating-procs.tcl
    • -17
    • +40
    ./acs-integration-procs.tcl
    • -2
    • +2
    ./currency-procs.tcl
    • -288
    • +391
    ./data-procs.tcl
    • -946
    • +1441
    ./date-procs.tcl
    • -35
    • +0
    ./debug-procs.tcl
    • -6
    • +107
    ./deprecated-procs.tcl
    • -3
    • +3
    ./dimensional-procs.tcl
    • -3
    • +3
    ./doc-procs.tcl
    • -22
    • +22
    ./doc-tcl-procs.tcl
    • -390
    • +591
    ./element-procs.tcl
    • -16
    • +104
    ./file-procs.tcl
    • -23
    • +19
    ./filter-procs.tcl
    • -40
    • +34
    ./form-procs.tcl
    • -0
    • +44
    ./head-init.tcl
  16. … 8085 more files in changeset.
Tuesday 27 Aug
4:50 pm

gustafn

fixed race condition and silence regression test

Options
    • -16
    • +26
    ./test/file-procs.tcl
Sunday 25 Aug
2:30 pm

gustafn

silences log entries during regression test

Options
    • -3
    • +6
    ./test/acs-integration-procs.tcl
    • -3
    • +5
    ./test/data-procs.tcl
  3. … 1 more file in changeset.
1:53 pm

gustafn

fixed incorrect message key

Options
    • -1
    • +1
    ./file-procs.tcl
Tuesday 20 Aug
11:29 am

gustafn

avoided duplicated loading of procs

Options
    • -0
    • +3
    ./parse-procs-aolserver.tcl
    • -0
    • +3
    ./parse-procs-naviserver.tcl
Thursday 08 Aug
2:55 pm

gustafn

added generic icon for "mount" operations

Options
    • -1
    • +6
    ./style-procs.tcl
  2. … 1 more file in changeset.
Tuesday 06 Aug
11:43 am

gustafn

spell "site-wide" consistently with a dash

Options
    • -4
    • +4
    ./head-procs.tcl
  2. … 34 more files in changeset.
Monday 15 Jul
2:04 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./spellcheck-init.tcl
  2. … 14 more files in changeset.
Friday 21 Jun
4:17 pm

antoniop

Make "standard" the default preset we apply to richtext editors

This is needed to have consistent site-wide default settings coming from the tcl level, such as connection context information and more.

Options
    • -5
    • +13
    ./richtext-procs.tcl
  2. … 1 more file in changeset.
Friday 31 May
2:00 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./list-procs.tcl
  2. … 5 more files in changeset.
Tuesday 07 May
8:59 am

antoniop

Fallback to the editor from parameter in the generic api, rather than the widget, so fallback will work also outside of ad_form

Options
    • -6
    • +13
    ./richtext-procs.tcl
Monday 06 May
4:47 pm

antoniop

Introduce for richtext editors the concept of "preset"

A preset is an abstract set configurations designed to address a specific use case.

An example could be a preset for a "minimal" richtext editor, used in those forms where we want to limit the features a user should have access to. Other presets could address specific usages or applications.

Downstream developers can provide a set of ::richtext::$editor::preset::$preset procs, returning an options dict. This set of options will be merged other local configurations.

The same approach works in ad_forms and xowiki forms.

This also enables the use-case of switching to a different editor maintaining the existing application-specific configurations consistent.

Options
    • -0
    • +21
    ./richtext-procs.tcl
  2. … 1 more file in changeset.
Thursday 08 Feb
7:14 pm

gustafn

improved spelling

Options
    • -1
    • +1
    ./currency-procs.tcl
    • -1
    • +2
    ./test/acs-integration-procs.tcl
    • -2
    • +2
    ./test/date-procs.tcl
Thursday 25 Jan
1:25 pm

antoniop

Move custom calendar widget javascript implementation out of the core.js and into a separate file

In core/maintained packages, this widget is used only by template::widget::textdate (which in turn is used nowhere). For this widget, we can include the relevant code on-demand.

Direct usages found in unsupported packages have been adapted by adding the extra requirement on the fly.

It is unclear if we should keep maintaining a calendar widget in our codebase, however, as the current one still works (kudos to the original author), we do not deprecate it for the time being.

It is also true that a custom widget provides a way to customize the look and feel of date fields, which is otherwise completely delegated to the browser.

Various packages, including the core, provide custom css styling for the current widget.

Options
    • -1
    • +4
    ./date-procs.tcl
  2. … 2 more files in changeset.
Monday 22 Jan
2:30 pm

antoniop

Factor richtext-or-file javascript outside of the core.js

This may or not be a step on the road to deprecating this widget, which still sports inline event handlers and is used only by unmaintained packages.

Options
    • -1
    • +3
    ./richtext-or-file-procs.tcl
  2. … 2 more files in changeset.
Monday 04 Dec 2023
3:19 pm

antoniop

template::widget::merge_tag_attributes has to be public already, as it is used by template::widget::select_locales

Options
    • -3
    • +3
    ./widget-procs.tcl
Thursday 30 Nov 2023
4:21 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./widget-procs.tcl
4:13 pm

antoniop

Form widget attributes reform:

- consolidate the logics to merge tag attributes coming from the adp and the tcl definitions of widgets into a private api

- change the previous behavior of having attributes coming from the adp (aka the tag_attributes argument) take over attributes coming from the element

See https://openacs.org/forums/message-view?message_id=5799349

Options
    • -26
    • +7
    ./date-procs.tcl
    • -8
    • +8
    ./form-procs.tcl
    • -6
    • +3
    ./richtext-or-file-procs.tcl
    • -5
    • +2
    ./richtext-procs.tcl
    • -5
    • +2
    ./tab-procs.tcl
    • -47
    • +47
    ./widget-procs.tcl
  7. … 1 more file in changeset.
3:14 pm

antoniop

Revert in order to provide a meaningful log message

Options
    • -35
    • +12
    ./widget-procs.tcl
3:13 pm

antoniop

*** empty log message ***

Options
    • -13
    • +36
    ./widget-procs.tcl
Thursday 23 Nov 2023
5:47 pm

antoniop

Do not override existing classes on the submit button

Many thanks to Jonathan Kelley for reporting the issue

Options
    • -2
    • +3
    ./widget-procs.tcl