OpenACS / openacs-4 / packages / acs-templating

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 46
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 24,955
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 May
2:00 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./list-procs.tcl
  2. … 5 more files in changeset.
Tuesday 07 May
8:59 am

antoniop

Fallback to the editor from parameter in the generic api, rather than the widget, so fallback will work also outside of ad_form

Options
    • -6
    • +13
    ./richtext-procs.tcl
Monday 06 May
4:47 pm

antoniop

Introduce for richtext editors the concept of "preset"

A preset is an abstract set configurations designed to address a specific use case.

An example could be a preset for a "minimal" richtext editor, used in those forms where we want to limit the features a user should have access to. Other presets could address specific usages or applications.

Downstream developers can provide a set of ::richtext::$editor::preset::$preset procs, returning an options dict. This set of options will be merged other local configurations.

The same approach works in ad_forms and xowiki forms.

This also enables the use-case of switching to a different editor maintaining the existing application-specific configurations consistent.

Options
    • -0
    • +21
    ./richtext-procs.tcl
  2. … 1 more file in changeset.
Thursday 08 Feb
7:14 pm

gustafn

improved spelling

Options
    • -1
    • +1
    ./currency-procs.tcl
    • -1
    • +2
    ./test/acs-integration-procs.tcl
    • -2
    • +2
    ./test/date-procs.tcl
Thursday 25 Jan
1:25 pm

antoniop

Move custom calendar widget javascript implementation out of the core.js and into a separate file

In core/maintained packages, this widget is used only by template::widget::textdate (which in turn is used nowhere). For this widget, we can include the relevant code on-demand.

Direct usages found in unsupported packages have been adapted by adding the extra requirement on the fly.

It is unclear if we should keep maintaining a calendar widget in our codebase, however, as the current one still works (kudos to the original author), we do not deprecate it for the time being.

It is also true that a custom widget provides a way to customize the look and feel of date fields, which is otherwise completely delegated to the browser.

Various packages, including the core, provide custom css styling for the current widget.

Options
    • -1
    • +4
    ./date-procs.tcl
  2. … 2 more files in changeset.
Monday 22 Jan
2:30 pm

antoniop

Factor richtext-or-file javascript outside of the core.js

This may or not be a step on the road to deprecating this widget, which still sports inline event handlers and is used only by unmaintained packages.

Options
    • -1
    • +3
    ./richtext-or-file-procs.tcl
  2. … 2 more files in changeset.
Monday 04 Dec 2023
3:19 pm

antoniop

template::widget::merge_tag_attributes has to be public already, as it is used by template::widget::select_locales

Options
    • -3
    • +3
    ./widget-procs.tcl
Thursday 30 Nov 2023
4:21 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./widget-procs.tcl
4:13 pm

antoniop

Form widget attributes reform:

- consolidate the logics to merge tag attributes coming from the adp and the tcl definitions of widgets into a private api

- change the previous behavior of having attributes coming from the adp (aka the tag_attributes argument) take over attributes coming from the element

See https://openacs.org/forums/message-view?message_id=5799349

Options
    • -26
    • +7
    ./date-procs.tcl
    • -8
    • +8
    ./form-procs.tcl
    • -6
    • +3
    ./richtext-or-file-procs.tcl
    • -5
    • +2
    ./richtext-procs.tcl
    • -5
    • +2
    ./tab-procs.tcl
    • -47
    • +47
    ./widget-procs.tcl
  7. … 1 more file in changeset.
3:14 pm

antoniop

Revert in order to provide a meaningful log message

Options
    • -35
    • +12
    ./widget-procs.tcl
3:13 pm

antoniop

*** empty log message ***

Options
    • -13
    • +36
    ./widget-procs.tcl
Thursday 23 Nov 2023
5:47 pm

antoniop

Do not override existing classes on the submit button

Many thanks to Jonathan Kelley for reporting the issue

Options
    • -2
    • +3
    ./widget-procs.tcl
Friday 27 Oct 2023
1:08 pm

antoniop

Reinstate behavior:

behave again that when a date fragment value is empty, the padded value will also be empty and not a sequence of zeroes

See https://openacs.org/forums/message-view?message_id=5798230

Options
    • -3
    • +9
    ./date-procs.tcl
Thursday 31 Aug 2023
3:13 pm

antoniop

Improve fix: if any other click handler would take longer than the timeout (e.g. an alert) don't wait again

Options
    • -6
    • +2
    ./head-procs.tcl
3:01 pm

antoniop

Make sure disabling the button always happens before re-enabling the button and that both happen after all other click handlers have completed

Options
    • -6
    • +11
    ./head-procs.tcl
Saturday 29 Jul 2023
2:26 pm

gustafn

adp:toggle_button: added "id" attribute

Options
    • -5
    • +8
    ./tag-init.tcl
Monday 24 Jul 2023
2:59 pm

gustafn

skip "-url" in "export_vars -url" since it is the default

Options
    • -2
    • +2
    ./dimensional-procs.tcl
  2. … 11 more files in changeset.
Tuesday 18 Jul 2023
12:27 pm

gustafn

fix cut&paste error

Options
    • -2
    • +2
    ./tag-init.tcl
11:24 am

antoniop

Cleanup debug statements, re-instate safe tmpfile check

Fixes acs-templating automated tests

Options
    • -5
    • +1
    ./file-procs.tcl
Monday 17 Jul 2023
7:26 pm

gustafn

adp:toggle_button: add "href" (default "#") for use when ... tag="a" ...

Options
    • -5
    • +7
    ./tag-init.tcl
Tuesday 11 Jul 2023
3:18 pm

gustafn

Added attributes "tag" and "type" to "adp:toggle_button" to increase applicability

- Bootstrap3 is picky and allows just "<a>" tags for the navigation

buttons, whereas Bootstrap4 and 5 would also allow <button> with

appropriate classes for nav-items and nav-links.

So, use <... tag="a"... > for use of nav buttons with potential

Dropdowns with Bootstrap 3.

- Potential attributes for this tag are:

- "tag" (default "button")

- "toggle"

- "target"

- "type" (default "button")

The attribute "type" is just valid when "tag" is "button".

- Many thanks to Monika Andergassen for the suggestion.

Options
    • -22
    • +30
    ./tag-init.tcl
Monday 10 Jul 2023
11:16 am

gustafn

improved spelling

Options
    • -2
    • +2
    ./list-procs.tcl
  2. … 2 more files in changeset.
Thursday 06 Jul 2023
10:58 am

gustafn

minor changes: fixed typo, ease debugging, ...

Options
    • -3
    • +3
    ./element-procs.tcl
    • -1
    • +5
    ./file-procs.tcl
    • -1
    • +1
    ./head-procs.tcl
    • -4
    • +6
    ./parse-procs.tcl
Wednesday 29 Mar 2023
3:35 pm

antoniop

Use modern api

Options
    • -12
    • +7
    ./table-procs.tcl
3:23 pm

antoniop

Update api to streamline idiom

Options
    • -15
    • +4
    ./form-procs.tcl
2:38 pm

antoniop

Update api

Options
    • -3
    • +2
    ./list-procs.tcl
  2. … 1 more file in changeset.
Thursday 23 Mar 2023
4:22 pm

antoniop

Localize error message

Options
    • -3
    • +8
    ./data-procs.tcl
4:13 pm

antoniop

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

Options
    • -1
    • +20
    ./data-procs.tcl
  2. … 1 more file in changeset.
Thursday 02 Mar 2023
6:16 pm

antoniop

Gracefully reject invalid lists supplied as a file triple instead of failing and log the occurrence

Options
    • -0
    • +8
    ./file-procs.tcl
Tuesday 28 Feb 2023
8:26 am

antoniop

Do not introduce extra newline in the content when writing to file

Options
    • -2
    • +2
    ./util-procs.tcl