• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- Add lots more documentation to ad_proc. Even old-time #openacs'ers

(myself included) didn't know how the (formerly undocumented) :boolean

attribute for name parameters worked (thanks Til!).

- Added example to ad_proc's docstring.

Merge of all changes from oacs-4-6 to HEAD. All changes up to tag jcd-merge-2

on oacs-4-6 are included.

  1. … 33 more files in changeset.
adding the Message Catalog APM file type to the TCL API

if there is no full query for a db statement and the default query in the tcl file is empty, raise an error and inform the developer about this (crash early)

merge from oacs-4-6

  1. … 109 more files in changeset.
When query dispatcher lookup fails and the default SQL is empty, bomb.

tone down QD messages bug 1772/patch 473 Bart Teeuwisse

ad_find_all_files was broken for files with spaces

make some procs -public (like empty_string_p)

- Patch by Michael Cleverly for the APM to throw warnings if it's skipping

files in the .tcl directory of packages because they are not -procs or

-init

documentation cleanup

  1. … 1 more file in changeset.
fix calls with literals instead of variables

  1. … 3 more files in changeset.
added ad_proc docs to procs and an ad_proc stub for if ad_proc absent

    • -80
    • +171
    ./40-db-query-dispatcher-procs.tcl
cleanup javadoc tags (eg @cvs_id @cvs @cvs-id: instead if @cvs-id)

  1. … 692 more files in changeset.
reduced debug output by setting db_qd_log level to QDDebug in most log stmts

    • -45
    • +56
    ./40-db-query-dispatcher-procs.tcl
don't make assumptions about what namespace we are upleveling to, when upleveling we must fully qualify the procs we are calling, for example we should say "set foo [uplevel {::set bar greble}]"

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

  1. … 74 more files in changeset.
fixed version checking error

1. Fixed a boneheaded error in the bootstrapper: "AvailablePool" was being

submitted to a case-sensitive check. Of course AOLserver parameters are

case-insensitive.

2. A recently submitted patch to the db routine that PSQL's source broke

the code if you haven't started postmaster with the "-i" option.

3. Bboard was very, very slow in PG. It is now much faster.

  1. … 3 more files in changeset.

1. changed db_qd_log to use the passed-in level rather than gluing things

to "Debug" for convenience. I then changed all the "Notice" calls to

"Debug". Then my one "Error" call I added worked! :) If a query file

has a syntax error in it now, an error is logged to the server log but

bootstrapping continues.

2. Lots and lots or etp oracle fixes and some PG version clean-ups

3. Some file-storage files were unconventionally named.

    • -42
    • +44
    ./40-db-query-dispatcher-procs.tcl
  1. … 17 more files in changeset.

Applied patch #73

slight change to db_qd_get_fullname that compensates for procs that are called with the global namespace qualifier - ::foo versus foo.

A bunch of "ACS"->"OpenACS" and similar changes

  1. … 28 more files in changeset.

1. Fixed a bug in the oracle version of acs-mail-nt-create.sql

2. Fixed a bug in the oracle version of the APM - a standard SQL92

left join was being executed rather than the nasty Oracle-specific

notation.

3. Futzed with the APM a bit - you can now only set "watch" commands on

those .xql files which are used by the current installation, you can

only install packages supported by the current installation's RDBMS.

  1. … 8 more files in changeset.

Fixed a few spelling mistakes

Ported a bunch more of acs-subsite

Fixed a few small, acs-subsite related bugs

  1. … 41 more files in changeset.

1. Added a check that PG was initdb's with the collation order for

characters that we expect.

2. Jon added a "sql/common" directory for the insert statements which

load data for acs-references, so I added a new datamodel type "common"

to the APM.

3. Created a new db API routine that returns true if a given db_type is

compatible with the current RDBMS.

4. Added a workaround for a PL/pgSQL "execute" bug in acs-workflow (other

cases had been fixed previously by others but this one was missed)

5. Diddled a couple of .info files using the APM.

  1. … 10 more files in changeset.
Fix APM to allow for LSB-compliant Paths. It didn't allow "www" in the

path of packages.

- changed the XML parsing throughout to go through a simplified API to later upgrade XML parsing in a central place.

- updated support for ns_xml 1.4, and added work-arounds for previous versions.

- added installer check for ns_xml compatibility at boot time.

    • -18
    • +22
    ./40-db-query-dispatcher-procs.tcl
  1. … 3 more files in changeset.

fixed logging to be more configurable within the QD and default to not so verbose.

    • -42
    • +49
    ./40-db-query-dispatcher-procs.tcl
  1. … 2 more files in changeset.

1. Fixed a couple of .info files

2. Got rid of Ben's hack to always reload query files before doing a query

mapping. He did this so you wouldn't have to reboot AOLserver every

time you change query files. It was a short-term hack but unfortunately

it looped virgin installs.

3. Added code to the APM to make the "watch" feature work with query files

as well as library files. This makes Ben's hack mentioned above

unnecessary.

  1. … 8 more files in changeset.