jeffd in OpenACS

About

1,699 commits
  • Committer is not mapped to a user
  • First commit: 03 July 2002
  • Last commit: 06 December 2010
Last Week All Time
Commits: 0 1,699
Files changed: 0 32,612
Change in LOC: -31 225,450

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 06 Dec 2010
4:18 pm

jeffd

be a bit more graceful on missing requests.

Options
    • -17
    • +18
    /openacs-4/packages/acs-developer-support/www/request-info.adp
    • -1
    • +3
    /openacs-4/packages/acs-developer-support/www/request-info.tcl
Sunday 05 Dec 2010
2:45 pm

jeffd

content_type css_file does not exist, require admin permission to do this, read file all at once instead of line by line

Options
    • -13
    • +7
    /openacs-4/packages/acs-developer-support/www/css-edit.tcl
    • -1
    • +3
    /openacs-4/packages/acs-developer-support/www/css-list.tcl
    • -1
    • +2
    /openacs-4/packages/acs-developer-support/www/css-make-live.tcl
    • -1
    • +3
    /openacs-4/packages/acs-developer-support/www/search.tcl
Thursday 02 Dec 2010
5:03 pm

jeffd

case fold before checking if column exists

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/datamodel-test-procs.tcl
Tuesday 30 Nov 2010
7:58 pm

jeffd

dont give table and id columns for tables that do not exist; maybe there should be an upgrade to fix this as well

Options
    • -4
    • +4
    /openacs-4/packages/categories/sql/postgresql/categories-relation.sql
6:35 pm

jeffd

make created view with : use _ instead (fix for xowiki object types)

Options
    • -2
    • +2
    /openacs-4/packages/acs-object-management/sql/postgresql/acs-kernel-changes-create.sql
3:44 pm

jeffd

you need to flush the package id to package_key map on update otherwise parameter updates and other things depending on package key fail until server restart. no attempt made to fix teh xotcl-core cached version. also misnamed query fixed

Options
    • -2
    • +3
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
2:40 pm

jeffd

accept pkey, fkey, and key as constraint suffixes since the pg automatic names use them and are good

Options
    • -2
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/datamodel-test-procs.tcl
2:14 pm

jeffd

fix typos and xml in query file

Options
    • -4
    • +8
    /openacs-4/packages/lorsm/www/admin/reorder-items-oracle.xql
Wednesday 25 Feb 2009
3:45 pm

jeffd

improve error messages from a variety of other malformed list things

Options
    • -6
    • +15
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
2:47 pm

jeffd

make the invalid orderby spec message more informative since it can be hard to identify a malformed orderby spec

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
Monday 23 Feb 2009
9:53 pm

jeffd

remove the Huh? here I am notice

Options
    • -2
    • +1
    /openacs-4/packages/openacs-default-theme/lib/plain-master.tcl
Friday 13 Feb 2009
11:26 pm

jeffd

typo

Options
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/tcl/item-procs.tcl
11:13 pm

jeffd

use content::extlink instead of the deprecated content_extlink:: api, add content::extlink::edit function

Options
    • -1
    • +29
    /openacs-4/packages/acs-content-repository/tcl/content-extlink-procs.tcl
    • -0
    • +25
    /openacs-4/packages/acs-content-repository/tcl/content-extlink-procs.xql
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/extlink-procs.tcl
    • -1
    • +1
    /openacs-4/packages/ajax-filestorage-ui/www/xmlhttp/add-url.tcl
    • -1
    • +1
    /openacs-4/packages/ajax-filestorage-ui/www/xmlhttp/edit-name.tcl
    • -1
    • +1
    /openacs-4/packages/ajax-filestorage-ui/www/xmlhttp/rename-fsitem.tcl
    • -5
    • +5
    /openacs-4/packages/attachments/tcl/attachments-procs.tcl
    • -2
    • +2
    /openacs-4/packages/attachments/www/simple-add-2.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/www/simple-add-2.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/www/simple-add.tcl
    • -3
    • +3
    /openacs-4/packages/file-storage/www/simple-delete.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/www/simple-edit.tcl
10:35 pm

jeffd

the arg is -paramter not -name to parameter::get_from_package_key, not sure how this ever worked...

Options
    • -6
    • +6
    /openacs-4/packages/acs-mail-lite/tcl/bounce-procs.tcl
10:26 pm

jeffd

use parameter::get rather than ad_parameter

Options
    • -2
    • +2
    /openacs-4/packages/search/lib/navbar.tcl
    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -1
    • +1
    /openacs-4/packages/search/www/advanced-search.tcl
    • -6
    • +6
    /openacs-4/packages/search/www/search.tcl
9:40 pm

jeffd

get rid of the rest of the proc_doc calls

Options
    • -1
    • +1
    /openacs-4/contrib/misc/db-cache-procs.tcl
    • -20
    • +20
    /openacs-4/contrib/obsolete-packages/library/tcl/km-00-defs-procs.tcl
    • -2
    • +2
    /openacs-4/contrib/obsolete-packages/library/tcl/km-access-procs.tcl
    • -4
    • +4
    /openacs-4/contrib/obsolete-packages/library/tcl/km-admin-lib-procs.tcl
    • -9
    • +9
    /openacs-4/contrib/obsolete-packages/library/tcl/km-branch-procs.tcl
    • -4
    • +4
    /openacs-4/contrib/obsolete-packages/library/tcl/km-browse-procs.tcl
    • -10
    • +10
    /openacs-4/contrib/obsolete-packages/library/tcl/km-categories-procs.tcl
    • -15
    • +15
    /openacs-4/contrib/obsolete-packages/library/tcl/km-display-procs.tcl
    • -1
    • +1
    /openacs-4/contrib/obsolete-packages/library/tcl/km-feedback-procs.tcl
    • -9
    • +9
    /openacs-4/contrib/obsolete-packages/library/tcl/km-links-procs.tcl
    • -13
    • +13
    /openacs-4/contrib/obsolete-packages/library/tcl/km-object-data-procs.tcl
    • -4
    • +4
    /openacs-4/contrib/obsolete-packages/library/tcl/km-users-procs.tcl
    • -2
    • +2
    /openacs-4/contrib/obsolete-packages/library/tcl/library-init.tcl
    • -3
    • +3
    /openacs-4/contrib/obsolete-packages/photo-album-lite/tcl/photo-album-lite-init.tcl
    • -3
    • +3
    /openacs-4/contrib/obsolete-packages/ticket-tracker-lite/tcl/ticket-tracker-lite-procs.tcl
  16. … 5 more files in changeset.
9:28 pm

jeffd

change all core proc_doc calls to ad_proc calls

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -12
    • +12
    /openacs-4/packages/acs-tcl/tcl/document-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/server-cluster-procs.tcl
    • -19
    • +19
    /openacs-4/packages/acs-tcl/tcl/table-display-procs.tcl
    • -15
    • +15
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -15
    • +15
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
9:12 pm

jeffd

print a call stack when emitting a deprecated/warn message

Options
    • -2
    • +10
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
9:10 pm

jeffd

use template::multirow foreach rather that the deprecated version; fix template::multirow so it works when adp_level is undefined

Options
    • -3
    • +3
    /openacs-4/packages/acs-lang/tcl/lang-catalog-procs.tcl
    • -3
    • +6
    /openacs-4/packages/acs-templating/tcl/query-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/www/doc/exercise/list-and-var-sample.tcl
6:43 pm

jeffd

remove duplicate procs bounce_prefix and address_domain which live in incoming-mail-procs.tcl and bounce-procs.tcl

Options
    • -17
    • +1
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
Thursday 12 Feb 2009
4:51 pm

jeffd

remove old debug statement

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl
4:38 pm

jeffd

OCD repair of the hard coded @cvs-id strings

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/ad-functional-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/admin-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/aolserver-3-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/deprecated-utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/memoize-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/request-processor-init.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/set-operation-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/table-display-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
Tuesday 10 Feb 2009
9:42 pm

jeffd

specify tclwebtest dependency for tests

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/navigation-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/whos-online-procs.tcl
7:31 pm

jeffd

switch foo_id_seq.netval to nextval('t_foo_id_seq') calls to placate postgresql 8.

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-create.sql
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-extlink.sql
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-revision.sql
    • -5
    • +5
    /openacs-4/packages/acs-kernel/sql/postgresql/acs-logs-create.sql
    • -3
    • +3
    /openacs-4/packages/acs-kernel/sql/postgresql/groups-create.sql
    • -2
    • +2
    /openacs-4/packages/acs-messaging/sql/postgresql/acs-messaging-packages.sql
    • -4
    • +4
    /openacs-4/packages/acs-subsite/sql/postgresql/application-groups-create.sql
    • -2
    • +2
    /openacs-4/packages/acs-subsite/sql/postgresql/subsite-callbacks-create.sql
    • -2
    • +2
    /openacs-4/packages/acs-subsite/sql/postgresql/user-profiles-create.sql
7:27 pm

jeffd

stub acs_mail_lite::send since ns_sendmail is not always the ultimate transport. (the second one)

Options
    • -3
    • +5
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
6:13 pm

jeffd

stub acs_mail_lite::send since ns_sendmail is not always the ultimate transport.

Options
    • -3
    • +5
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
4:20 pm

jeffd

make test case a bit more informative about failure mode

Options
    • -4
    • +4
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
Friday 19 Aug 2005
8:34 pm

jeffd

fix the define_function_args thing for content_item__set_live_revision reported by Peter Alberer

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -0
    • +1
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.2.0d17-5.2.0d18.sql
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.2.0d4-5.2.0d5.sql
Friday 08 Jul 2005
3:09 pm

jeffd

doh forgot to init err1

Options
    • -0
    • +1
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
12:19 pm

jeffd

need to catch close since if close fails you could send message over and over

Options
    • -2
    • +5
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl