OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 28 Nov
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 24 Mar 2022
9:06 am

gustafn

Prefer "... orderby ... -type ..." over mixin for sorting

Options
    • -4
    • +3
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -6
    • +6
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
Wednesday 23 Mar 2022
9:40 pm

gustafn

Make use of extended functionality of OrderedComposite->orderby

- use integer comparison for "seconds" in participants table

- bumped version number to 5.10.1d33

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
9:37 pm

gustafn

Make use of extended functionality of OrderedComposite->orderby

- Removed manual adding of mixin ::xo::OrderedComposite::IndexCompare

in "toc" includelet and in xowiki::TableWidget->create_from_form_fields

- xowiki::TableWidget->create_from_form_fields:

added type map to allow caller to specify, on which attributes e.g.

a numeric comparison should be used.

- bumped version number to 5.10.1d22

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -4
    • +5
    /openacs-4/packages/xowiki/tcl/table-widget-procs.tcl
9:29 pm

gustafn

OrderedComposite->orderby: added argument "-type"

By the change, one can now specifiy the sorting type for the ordered

composite. The sorting type can be "integer", "real", "index" or

"dictionary" (default "dictionary"). If the sorting type is set to

"index", the mixin ::xo::OrderedComposite::IndexCompare is added

automatically.

Bump version number to 5.10.1d6

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -7
    • +40
    /openacs-4/packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl
7:55 pm

gustafn

rework of ad_decode

- modernize code

- improve performance

- extend regression test

Options
    • -35
    • +26
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -0
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
10:17 am

gustafn

stick with integer for purely nsf-based checks in public code.

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/www/admin/import.tcl
10:03 am

gustafn

Added API call "CrClass ad_proc id_belongs_to_package"

The new API call is useful for checking input validity, i.e.

whether to provided revision_id or item_id belongs to the specified package.

bump version number of xowiki to 5.10.1d21

bump version number of xotcl-core to 5.10.1d5

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -2
    • +23
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -15
    • +3
    /openacs-4/packages/xowiki/www/admin/import.tcl
9:33 am

gustafn

check parent_id more properly

Options
    • -5
    • +24
    /openacs-4/packages/xowiki/www/admin/import.tcl
Tuesday 22 Mar 2022
9:05 pm

gustafn

prefer variable ::acs::rootdir over proc [acs_root_dir]

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-callback-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
9:02 pm

gustafn

improve page contract

Options
    • -5
    • +5
    /openacs-4/packages/xowiki/www/admin/import.tcl
1:34 pm

hectorr

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
1:17 pm

gustafn

Support for extra extra hints texts (feedback, correction hints)

The updated version of the inclass-exam supports now extra hint texts for lecturers and students. These extra information is displayed after the question, and is used either for feedback to the student (e.g. Einsicht) or as information for the grader (evaluation guidelines, esp. useful when multiple graders are involved). It can be controlled via setup what kind of information the question author can provide. The providable feedback is controlled via the feedback level:

Feedback level

- The feedback level can be

* "full": two input fields for feedback for correct and incorrect answers

* "single": single input fields for feedback

* "none": no input field for feedback.

- The feedback level is specified in the forms used in the

pull down menus for creating "New" test items.

- The feedback level is applicable to all test item types

(SC, MC, Text, ShortText, Ordering, Upload, Composite, Pool)

- The predefined setup is as follows:

"single" is used for all item type, except for "Pool" questions (since the feedback

is taken from the replacement question from the Pool)

- Nothing has change here

Correction notes:

- optionally, correction notes can be specified.

Since in the past, the general feedback was not shown to the students,

it was sometimes abused for correction hints for the lecturer.

Therefore, we have now a separate field

- Correction notes can be added to all item types

(SC, MC, Text, ShortText, Ordering, Upload, Composite, Pool) and are

turned on by default (except for Pool).

Visibility of general feedback and correction notes

- general feedback is shown (when provided)

* full exam-protocol is shown

* filtering single question

* filtering single submission (view with revision selection)

* exam-review for students (Einsicht)

- corrections notes are shown (when provided)

* full exam-protocol is shown

* filtering single question

* filtering single submission (view with revision selection)

- when general feedback is not provided, the exam protocol etc. looks as before

- when correction notes are not provided, the exam protocol etc. looks as before

- Negative feedback is provided,

* when percentage is known, and

* percentage is < 50%

- when negative feedback is displayed, the positive feedback is not displayed and vice versa

For composite questions, the system supports hint texts for the full composite question and additional ones for every single part.

Version number bumped to 5.10.1d32

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +3
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -2
    • +4
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -1
    • +1
    /openacs-4/packages/xowf/resources/prototypes/TestItemPoolQuestion.form.page
    • -17
    • +150
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Monday 21 Mar 2022
4:08 pm

antoniop

Document public api

Options
    • -0
    • +5
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
3:58 pm

antoniop

Revert port of downstream feature: the same check can be performed more flexibly via the condition=regexp and condition=match

Options
    • -5
    • +1
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
2:41 pm

antoniop

Port of downstream feature: condition proc on the FormPage checking that a page name respects some regular expression

Options
    • -1
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
12:28 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
12:24 pm

antoniop

Make sure result is defined, small improvements

Options
    • -9
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
12:21 pm

antoniop

Port of old local modification: when mime type is text/plain, feed the content straight to the indexer, rather than render the file as HTML, then convert it again to text in the search indexer

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Sunday 20 Mar 2022
9:06 pm

gustafn

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
8:47 pm

gustafn

file iprange-init.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowf/tcl/iprange-init.tcl
8:47 pm

gustafn

file iprange-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowf/tcl/iprange-procs.tcl
8:47 pm

gustafn

Added support for restricting access to exams based on IP addresses.

In order to avoid the problem that students might participate on exams

intended to be held e.g. on campus from at home, one can now restrict

the access based on IP ranges. It is possible to restrict the access

via multiple range blocks that can be predefined by the sysadmins. One

could predefine e.g. IP range blocks for "Campus LAN", "On Site",

"VPN", etc., which can be selected by lecturers for individual exams.

Every IP range block can be defined via multiple entries of disallowed

and allowed IP ranges, where the addresses can be specified via IPv4

or IPv6 CIDR blocks (e.g. 127.208.0.0/16), or with wild cards or

individual IP addresses. The usage of CIDR blocks requires an update

to the updated version of NaviServer.

The IP restriction is used in the current implementation for

restricting the regular start of the exam (proctored or

non-proctored). Lecturers can still perform test runs for exams with

restricted access.

Bump version number to 5.10.1d31

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +5
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +5
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -1
    • +4
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -0
    • +2
    /openacs-4/packages/xowf/resources/prototypes/select_question.form.page
    • -0
    • +24
    /openacs-4/packages/xowf/tcl/iprange-init.tcl
    • -0
    • +67
    /openacs-4/packages/xowf/tcl/iprange-procs.tcl
    • -1
    • +21
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -0
    • +22
    /openacs-4/packages/xowf/tcl/xowf-form-field-procs.tcl
Friday 18 Mar 2022
10:13 am

antoniop

Revert additional fallbacks, one should take care that ad_conn is invoked correctly

Options
    • -14
    • +3
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
Thursday 17 Mar 2022
10:15 am

antoniop

Provide further fallbacks for ad_conn

Options
    • -3
    • +14
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
Wednesday 16 Mar 2022
4:28 pm

antoniop

Reduce number of queries, improve documentation

Queries could be made even less e.g. by locking and querying the tuples in one statement. However, it would be trickyer to make the code portable.

Options
    • -11
    • +16
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -9
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.xql
3:36 pm

antoniop

Simplify nsv idiom

Options
    • -4
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
3:33 pm

antoniop

Make sure the value we validate is a list

Options
    • -2
    • +2
    /openacs-4/packages/calendar/www/cal-item-new.tcl
2:18 pm

trenner

check that provided signature is a list, otherwise lassign will fail afterwards

Options
    • -1
    • +9
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
2:11 pm

antoniop

Cleanup leftover code

Options
    • -20
    • +1
    /openacs-4/packages/general-comments/lib/comment-add-edit.tcl
2:09 pm

antoniop

Reimplement the add/edit api to use ad_form

Options
    • -0
    • +6
    /openacs-4/packages/general-comments/lib/comment-add-edit.adp
    • -0
    • +141
    /openacs-4/packages/general-comments/lib/comment-add-edit.tcl
    • -0
    • +6
    /openacs-4/packages/general-comments/www/comment-add.adp
    • -38
    • +1
    /openacs-4/packages/general-comments/www/comment-add.tcl
    • -51
    • +0
    /openacs-4/packages/general-comments/www/comment-ae.adp
    • -0
    • +4
    /openacs-4/packages/general-comments/www/comment-edit.adp
    • -44
    • +1
    /openacs-4/packages/general-comments/www/comment-edit.tcl