• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce number of queries, improve documentation

Queries could be made even less e.g. by locking and querying the tuples in one statement. However, it would be trickyer to make the code portable.

Simplify nsv idiom

Make sure the value we validate is a list

check that provided signature is a list, otherwise lassign will fail afterwards

Cleanup leftover code

Reimplement the add/edit api to use ad_form

file comment-add-edit.adp was initially added on branch oacs-5-10.

file comment-edit.adp was initially added on branch oacs-5-10.

file comment-add.adp was initially added on branch oacs-5-10.

file comment-add-edit.tcl was initially added on branch oacs-5-10.

Cleanup trivial remarks, provide the user_id explictly to the permission check

Fix typo

Enforce the mimetype the same in follow up script

Enforce only valid mime types

harden page contract

Make publish_body required, as we already enforce it down the line

    • -2
    • +2
    /openacs-4/packages/news/www/item-create.tcl
Fix more boolean expressions

    • -3
    • +3
    /openacs-4/packages/news/www/item-create-3.tcl
take page contract into account + harden page contract

harden page contract

harden page contract

    • -2
    • +2
    /openacs-4/packages/forums/www/user-history.tcl
prefer global variable over proc

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
deactivate options checking for for role-members

seems currently broken

increase default value of number of potential alternatives to 25

refine form.form and validation errors

harden page contract

Simplify documentation

Fix typo in doc

provide (non-default) message keys for "form.form.page"

align instance variable values of formfield "form" with "textarea" to make subclassing simpler

Fix provide language prefixes for pages in the test