Activity OpenACS/

Change the regexp so that we catch multiple kinds of error pattern indicating the subcommand does not exist: NaviServer and Tcl return sligthly different error messages

- -1
- +1
/openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../00-icanuse-procs.tcl

3:30 pm

antoniop

Extend test to expose that we need a better idiom to detect also NaviServer commands

- -0
- +14
/openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../00-icanuse-procs.tcl

3:17 pm

antoniop

Use a different idiom to detect if a command supports a subcommand, fixing acs-tcl.acs__command_has_subcommand automated test

- -2
- +8
/openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../00-icanuse-procs.tcl

3:16 pm

antoniop

Fix wording

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../00-icanuse-procs.tcl

3:09 pm

antoniop

New test for acs::cmd_has_subcommand exposing how flags at the beginning and end of the error message are not properly recognized

- -0
- +49
/openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../00-icanuse-procs.tcl

3:09 pm

antoniop

More
MAIN:antoniop:20210114140903
deleted 1 file
MAIN

file 00-icanuse-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
- History
- Source
/openacs-4/packages/.../test/00-icanuse-procs.tcl

7:19 pm

gustafn

ensure, that the minimal set of controls is provided, also, when there are hidden form fields

- -6
- +7
/openacs-4/packages/xowiki/tcl/includelet-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../includelet-procs.tcl

7:18 pm

gustafn

improve spelling

- -3
- +4
/openacs-4/packages/xowiki/tcl/form-field-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../form-field-procs.tcl

7:00 pm

gustafn

since the form-field "file" supports the file multiple attribute, the internal representation is as well a list.

this change takes now as file-name for the local renderer as well the first file name list element.

- -5
- +7
/openacs-4/packages/xowf/tcl/test-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-item-procs.tcl

2:39 pm

trenner

add the original filename to the generated url, so that it is also delivered to the user

- -1
- +1
/openacs-4/packages/xowf/tcl/test-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-item-procs.tcl

2:16 pm

antoniop

Keep supporting the previous proc signature, throwing a warning

- -0
- +5
/openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../http-client-procs.tcl

2:10 pm

antoniop

util::http should provide enough fallback via curl already without targeting specific Naviserver versions, use other fallbacks only when no implementation is available

- -23
- +2
/openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../apm-file-procs.tcl
- -2
- +1
/openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../http-client-procs.tcl

1:39 pm

hectorr

Fix webserver version check using 'apm_version_names_compare' for rc versions.

Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest.

As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future.