OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 14
Total Committers: 146
Last Commit: 17:24
Commits this week: 14
Total Lines of Code (LoC): 7,560,967
Net change in LoC this week: 146

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 27 Nov 2020
11:33 am

gustafn

reduce verbosity (set verbose_blocking per default to 0), improve speed of dump creation

Options
    • -26
    • +21
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
10:52 am

gustafn

added example line to ease spotting of the creation of unnamed mutexes

Options
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/tcltrace-init.tcl
10:27 am

gustafn

provide name for mutexes to ease spotting potential locks

Options
    • -4
    • +3
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Thursday 26 Nov 2020
6:03 pm

antoniop

New method to cleanup all data associated with a community in the throttle object:

if a community is deleted when a user is accessing it, some leftover information will be kept in the object. At the next request this will be interpreted as the community having been left and the system will try to track this event into request_monitor_community_activities. Depending on who comes first, we might try to insert a tuple in the table for an object that does not exist anymore.

Hence, we use this method to cleanup all community info before the actual deletion in dotlrn (happening only downstream).

Options
    • -2
    • +18
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Wednesday 25 Nov 2020
10:33 pm

gustafn

allow points computation in cases, where some grading schemes fail.

Before, the grading code was overly conservative and refused to

compute achieved points in such cases

Options
    • -12
    • +19
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
3:35 pm

hectorr

Fix expression logic

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
Tuesday 24 Nov 2020
8:02 pm

gustafn

avoid burst cache hits by using nsvs instead of ns_cache for secret token caching

The problem with the prevision version was that ns_cache has no equivalent

to nsv_array to get in an atomic fashion all key value pairs from the cache.

thefore, for the per-thread caching, a tight loop was used processing

the result of ns_cache_keys. If this was necessary in a high number of

threads, higher lock times were possible (~100ms). The new version

should not face this problem.

Options
    • -26
    • +66
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
7:38 pm

antoniop

Don't be so strict upstream, as here we do not restrict community_key to ltree

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
7:22 pm

antoniop

Constrain further the characters we allow in the community_key: makes sense upstream as this will become part of a URL, but is even more important downstream, as we implement the community_key as a ltree and therefore we are limited in the type of characters we can allow (See https://www.postgresql.org/docs/current/ltree.html)

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
4:40 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
4:36 pm

antoniop

Add missing arguments

Options
    • -2
    • +4
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
4:26 pm

antoniop

Rework dotlrn_community::check_community_key_valid_p so that we check also for the community key to not have spaces

Logics have been moved to private api that might or might not become the preferrable api at some point, as it also returns the specific error message together with the boolean

Options
    • -9
    • +43
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -9
    • +0
    /openacs-4/packages/dotlrn/tcl/community-procs.xql
Monday 23 Nov 2020
10:06 pm

gustafn

use term "Preview" for testing single test items

Options
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowf/lib/edit-interaction.wf
10:00 pm

gustafn

new form-field class: boolean_checkbox

behaves like boolean, but provdes just a single checkbox instead of yes/no radio in "boolean"

the output is full compatible with "boolean".

The boolean_checkbox is used in test-item procs for a more slim correct/incorrect specification

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +2
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -0
    • +3
    /openacs-4/packages/xowf/www/resources/form-generator.css
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -1
    • +24
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
8:45 pm

gustafn

fixed ckeditor form field for inline mode.

use inline mode for editing test items

added a describe funtion for MC items

Options
    • -0
    • +1
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +2
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -5
    • +23
    /openacs-4/packages/xowf/lib/answer-single-question.wf
    • -2
    • +82
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -4
    • +8
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -2
    • +5
    /openacs-4/packages/xowiki/www/resources/xowiki.css
8:18 pm

gustafn

upgrade to CKEditor 4.15.1

Options
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/richtext-ckeditor4.info
    • -3
    • +3
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
8:04 pm

gustafn

move xowiki::test::get_url_from_location to automated testing

handle updaed query-handling in ns_parseurl

remoe dependency from file-storage tests to xowiki

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/acs-automated-testing.info
    • -1
    • +32
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -3
    • +3
    /openacs-4/packages/file-storage/file-storage.info
    • -2
    • +2
    /openacs-4/packages/file-storage/tcl/test/webtest-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -19
    • +9
    /openacs-4/packages/xowiki/tcl/test/test-procs.tcl
4:49 pm

gernst

Package new-portal: additional database indices for tables "portal_element_map", "portal_element_parameters" and "portal_datasource_def_params"; bumped package version to 2.10.0d4

Options
    • -2
    • +2
    /openacs-4/packages/new-portal/new-portal.info
    • -1
    • +8
    /openacs-4/packages/new-portal/sql/oracle/portal-core-create.sql
    • -0
    • +18
    /openacs-4/packages/new-portal/sql/oracle/upgrade/upgrade-2.10.0d3-2.10.0d4.sql
    • -1
    • +8
    /openacs-4/packages/new-portal/sql/postgresql/portal-core-create.sql
    • -0
    • +18
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.10.0d3-2.10.0d4.sql
4:49 pm

gernst

file upgrade-2.10.0d3-2.10.0d4.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/new-portal/sql/oracle/upgrade/upgrade-2.10.0d3-2.10.0d4.sql
    • -0
    • +0
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.10.0d3-2.10.0d4.sql
3:55 pm

antoniop

Whitespace cleanup

Options
    • -5
    • +5
    /openacs-4/packages/acs-subsite/www/register/user-join.tcl
3:55 pm

antoniop

Remove irrelevant comment

Options
    • -3
    • +1
    /openacs-4/packages/acs-subsite/www/register/user-join.tcl
3:55 pm

antoniop

Port of downstream customization: don't lose the return URL when one tries to join a community before login

Options
    • -2
    • +12
    /openacs-4/packages/acs-subsite/www/register/user-join.tcl
3:11 pm

antoniop

Important, although very simple reform in the page-contract filters: do not kill the case in the filter specs, or filters such as "w:oneof(One|Two)" or "locale:oneof(en_US|de_DE)" would not have a chance to match

Note that this makes the contracts stricter with respect to case, which might break obscure use cases...

Options
    • -2
    • +4
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
12:50 pm

gustafn

use "keep_order=true" for test-item selection boxes

Options
    • -1
    • +1
    /openacs-4/packages/xowf/www/prototypes/quiz-select_question.form.page
    • -1
    • +1
    /openacs-4/packages/xowf/www/prototypes/select_question.form.page
12:45 pm

gustafn

candidate_box_select: provide optional the feature to keep the user selected order

The change is fully backward compatible. Per default, the order in the actual

selected values is the same as in the candidate selection box. When

the new parameter "keep_order" is provided, the order of the selected

values is kept as selected by the user.

Options
    • -7
    • +17
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
12:38 pm

gustafn

candidate_box_select: provide per default larger boxed (easer for dnd)

Options
    • -2
    • +4
    /openacs-4/packages/xowiki/www/resources/xowiki.css
Sunday 22 Nov 2020
12:55 am

gustafn

request monitor overhaul:

- new parameter "do_double_click_prevention" (default: on)

When turned off, double click prevention can be selectively

turned off.

- new parameter "monitor_urls" (default: / /register/ /dotlrn/)

track for these URLs performance via minin responsetime plugin

- added upgrade script for removing old parameters

- bump version to 0.60

Options
    • -3
    • +10
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -0
    • +54
    /openacs-4/packages/xotcl-request-monitor/tcl/callback-proc.tcl
    • -25
    • +74
    /openacs-4/packages/xotcl-request-monitor/tcl/callback-procs.tcl
    • -16
    • +25
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
12:55 am

gustafn

file callback-proc.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xotcl-request-monitor/tcl/callback-proc.tcl
Saturday 21 Nov 2020
6:39 pm

gustafn

allow value checkers in ad_procs

Options
    • -7
    • +25
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
5:45 pm

gustafn

avoid to try to return an error to client in request processor when connection was already closed

Options
    • -1
    • +6
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl