• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Collect common definition of an argspec flag in a proc to improve clarity

Introduce a new clock ad_page_contract filter:

this filter enforces that a datestring belongs to one of the clock formats specified in the argspec. By default, this will be %Y-%m-%d.

Cleanup

ad_page/include_contract argspec parsing reform: allow arbitrary characters in the argspec flag parameters

This reform allows to specify an argspec containing pipes, parenthesys and other so far forbidden characters as parameters for a flag. The purpose is to enhance the expressiveness of existing validators (e.g. the oneof validator) and enable new one, for instance, a date validator using a clock format as parameter.

Pipes and parenthesys need to be escaped via the backslash character in the new syntax.

file tcl-documentation-procs.tcl was initially added on branch oacs-5-10.

Whitespace changes

    • -8
    • +8
    /openacs-4/packages/faq/www/one-faq.tcl
Fix array format in message keys

See acs-lang.message__format automated test, where the expected behavior of lang::message::format is documented

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
undo part of last change

unfortunatly, the 0.9.3 issue can't be fixed so simple as hoped. The "-html" flag is necessary for dealing with autoclosed entries.

    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
for orthogonaly, remove "-html" flag from dom parse to avoid a potential top-level <html> element

    • -7
    • +7
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
provide compatibility with tdom 0.9.3

Add @see to deprecated procs

Add @see to deprecated procs

Add @see to deprecated procs

Add @see to deprecated procs

Add @see to deprecated procs

add missing curly brackets

    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Deprecate ad_apply, made obsolete in modern Tcl by the expansion operator "{*}"

Whitespace cleanup

    • -4
    • +4
    /openacs-4/packages/faq/www/one-faq.tcl
Avoid message keys from packages outside the dependency tree, provide a way to customize the proctoring session name

Prefer a message key in the dependency tree of this package

Whitespace cleanup

Use quicker idiom to check for existance

Whitespace cleanup

Whitespace changes

Prefer api to retrieve the approval state of a user

Complete coverage for the notification package

Brutally delete the notification requests before deleting the delivery method (it's fine because it will be rolled back)

Fix issue in the query logics: we actually want to check the owner of the request, there might be multiple requests associated to the same object

Extend coverage, this will expose an api bug