• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add 'acs_subsite_relation_procs' test case, covering 'relation_add', 'relation_remove', 'relation::get_object_one', 'relation::get_object_two', 'relation::get_objects' and 'relation::get_id'

Extend 'category_tree_procs' test case with 'category::relation::add_meta_category' and 'category::relation::get_meta_categories'

    • -1
    • +22
    ./packages/categories/tcl/test/categories-procs.tcl
set default grading scheme to "wi1p" instead of "wi1"

    • -1
    • +1
    ./packages/xowf/tcl/test-item-procs.tcl
Extend 'category_tree_procs' test case with 'category::change_parent'

    • -1
    • +13
    ./packages/categories/tcl/test/categories-procs.tcl
Extend 'category_tree_procs' test case with 'category::count_children'

Replace deprecated 'acs_mail_lite::utils::valid_email_p' with 'util_email_valid_p'

Reuse email validation logic

Deprecate 'acs_mail_lite::utils::valid_email_p', as it is duplicated by 'util_email_valid_p'. It was not deleted because it was a public proc recently turned to private.

    • -14
    • +8
    ./packages/acs-mail-lite/tcl/utils-procs.tcl
Replace regexp for mail validation by the version proposed by mozilla for the email input type validation, and increment the test cases for valid/invalid emails. Thanks to Günter Ernst for the pointers.

    • -3
    • +13
    ./packages/acs-tcl/tcl/utilities-procs.tcl
Fix ancient typo

update covered procs in test case

    • -29
    • +39
    ./packages/xowf/tcl/test/test-item-procs.tcl
- support var args for "aa_log_result" like for "ns_log" and "ad_log"

- make form parsing via xpath more robust

(don't assume, every INPUT has a name, allthough it should)

extend regression test by including participants page during and after exam

    • -1
    • +23
    ./packages/xowf/tcl/test/test-item-procs.tcl
Add 'object_p' test case, covering 'acs_object::object_p'

Add 'string_length_compare' test case, covering 'util::string_length_compare'

Add 'name_to_path' test case, covering 'util::name_to_path'

Add 'util_email_valid_p' test case, covering 'util_email_valid_p'

Increase verbosity

Add 'db_boolean' test case, covering 'db_boolean'

    • -0
    • +18
    ./packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
Add 'ad_future_years_list' test case, covering 'ad_future_years_list'

Add 'host_admin_and_outgoing_sender' test case, covering 'ad_outgoing_sender' and 'ad_host_administrator'

Add 'forum_enable_disable' test case, covering 'forum::enable' and 'forum::disable'

    • -1
    • +50
    ./packages/forums/tcl/test/forums-procs.tcl
add a 10sec grace period to allow typing until the last seconds (but not longer)

    • -1
    • +6
    ./packages/xowf/lib/inclass-exam-answer.wf
Add all whitespace characters between double quotes when converting a dict to hstore

Many thanks to Guenter Ernst for the analysis.

Extended regression test

    • -7
    • +15
    ./packages/xowiki/tcl/xowiki-utility-procs.tcl
    • -3
    • +3
    ./packages/xowiki/tcl/test/api-test-procs.tcl
Add minimal test case for 'attachments::get_package_key'

Add minimal test case for 'dt_midnight_p'

- fixed display of total points in exam protocol: base calculations on total points rather than the points achievable based on progress

- fixed typo in message key

    • -10
    • +16
    ./packages/xowf/tcl/test-item-procs.tcl
Improved handling of autosaved revisions

- reject autosave attempts when time for a student is up

(works for synchronized and non-synchronized exams)

- include submissions with autosaved content in exam protocol (even when state is "initial")

    • -8
    • +23
    ./packages/xowf/lib/inclass-exam-answer.wf
    • -11
    • +34
    ./packages/xowf/tcl/test-item-procs.tcl
Fix typo

    • -1
    • +1
    ./packages/xowiki/tcl/test/api-test-procs.tcl
show personal bulk-notification link only if at least one user can receive the notification

    • -9
    • +12
    ./packages/xowf/tcl/test-item-procs.tcl