• last updated 55 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
query_parameter_return_url is defined on the package

Append the category extra where clause to the others, possibly existing, extra where clauses, only when the with_category flag is specified

fix typo

fix variable name for base_items and reeanble deactivate code

Allow to specify multiple, already computed forms ids

Allow to filter entries also by extra where clause (e.g. for non instance attributes such as the state)

Comment dead code: base_items is set, but never used

improve spelling

  1. … 1 more file in changeset.
improve spacing on inline radio boxes in bootstrap5 (many thanks to Monika Andergassen)

Cleanup leftover variables

Formatting changes

    • -15
    • +26
    ./www/ckeditor-images/thumb-view.tcl
Modernize page contract

Cleanup commented code

Delete obsolete scripts (feature uses since a long time the own object's download method)

Styling improvements for exam answering workflows (many thanks to Monika Andergassen)

- provide explicit text to "next" and "previous" buttons in pagination menu

- align appearance of "next" and "previous" buttons in pagination menu with GitHub

- removed class "input-group" for compound fields to improve appearance

- bumped version number of xowf to 5.10.1d48

  1. … 4 more files in changeset.
Validate field names when these might come directly from the POST request and therefore contain arbitrary text

Add doc to public api

Fix typo in comment

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

  1. … 6 more files in changeset.
Fall back to en_US also when a value for nls_language is there, but empty

Use api to determine whether a field is disabled, as the "disabled" variable will always be set now

Use existing api to tell whether a formfield is disabled or not and to set/unset disabled on a field, handle the case of checkboxes and select fields, where the attribute should not be set whe it is false (e.g. disabled=0 == disabled)

This fixes upstream automated tests on xowiki and xowf

Fixed serious bug killing at least short-text questions in inclass exam

The bug was introduced in [1], by testing for the existence of the

disabled attribute, and when it exists, it was omitting values

reading. The problem is that when form-fields are reset, the

"disabled" attribute is set to 0, leading the exists check to

succeed. In essence, This change sets now the default value of the

form-field to "0", such that it is safe to test it everywhere.

Originally, it was not set by default to save resources (memory and

processing power), but this requires a more careful analysis when

changes happen.

[1] https://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl?r1=1.368.2.125&r2=1.368.2.126

improved error message

make clear, what the name and what the item_id in the message are

use new path xowiki/lib/portlets/ instead of .../www/...

comment method

Port of downstream hotfix: questions defined with an empty scoring might later fail the score calculations

One might consider preventing empty scores altogether via validation

new proc "ad_log_deprecated": unified interface for logging deprecated usages

The existing code used a larger variety of different messages to

denote invocations of deprecated procs and other

artifacts. "ad_log_deprecated" provides a unified interface, and

provides a usage hint what to use instead based on the API-doc

definitions in the log-file.

  1. … 6 more files in changeset.
rename "iconified file" to "thumbnail file"

Improved styling: use boostrap card component for rendering includelets