OpenACS / openacs-4 / packages / xowiki

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 26 Apr
Commits this week: 0
Total Lines of Code (LoC): 29,976
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Aug 2022
8:22 pm

antoniop

Skip processing for all formfields that are defined as disabled:

the browser should not send us these data in the first place.

Options
    • -21
    • +29
    ./xowiki-www-procs.tcl
8:16 pm

antoniop

Extend test: show that even when a field is defined as disabled, a request crafted to carry these fields will get through and the values will be stored

A fix will come shortly, similar to what was done for compound fields

Options
    • -3
    • +15
    ./test/xowiki-test-procs.tcl
Wednesday 13 Jul 2022
1:00 pm

gustafn

undo part of last change

unfortunatly, the 0.9.3 issue can't be fixed so simple as hoped. The "-html" flag is necessary for dealing with autoclosed entries.

Options
    • -5
    • +5
    ./xowiki-procs.tcl
    • -2
    • +2
    ./xowiki-www-procs.tcl
12:41 pm

gustafn

for orthogonaly, remove "-html" flag from dom parse to avoid a potential top-level <html> element

Options
    • -2
    • +2
    ./includelet-procs.tcl
    • -3
    • +3
    ./xowiki-form-procs.tcl
    • -1
    • +1
    ./xowiki-init.tcl
    • -7
    • +7
    ./xowiki-procs.tcl
    • -2
    • +2
    ./xowiki-www-procs.tcl
Wednesday 06 Jul 2022
6:14 pm

gustafn

fix compatibility with tdom 0.9.3

Options
    • -2
    • +2
    ./form-field-procs.tcl
Sunday 26 Jun 2022
9:29 pm

gustafn

fix warning (including some false positives) in regression test

Options
    • -1
    • +1
    ./personal-notification-procs.tcl
    • -4
    • +4
    ./test/api-test-procs.tcl
  3. … 4 more files in changeset.
Saturday 25 Jun 2022
10:52 am

gustafn

we need the upgrade script, since the automatic aler just kicks in, when the constraint does not exist. Antonio was right.

Nevertheless, it would be a nice feature, if the ORM would handle this.

Options
    • -1
    • +14
    ./upgrade/upgrade.tcl
10:25 am

gustafn

remove useless upgrade scripts (xotcl-core does this automatically on reloads)

Options
    • -32
    • +1
    ./upgrade/upgrade.tcl
Friday 24 Jun 2022
5:02 pm

antoniop

Document and enforce expected behavior when Forms are deleted: this is forbidden and returns an error as long as they have instances

Options
    • -0
    • +139
    ./test/xowiki-test-procs.tcl
2:55 pm

antoniop

Follow up of https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20220622174910

In the end we need the upgrade logic, as the ORM will kick in only if the column is just being created

Options
    • -1
    • +15
    ./upgrade/upgrade.tcl
  2. … 1 more file in changeset.
Wednesday 22 Jun 2022
7:49 pm

gustafn

Make page_template foreign key deferrable

This solves the problem of deleting implicitly child-items, which

depend on each other when deleting an item. When deleting an item, the

deletion of child-items in the content repository happens in an

arbitrary order, which could raise fk constraints. Since the deletion

happens in a transaction, the deferring checking of the constraints

helps, since then the constraint violating item is also already

deleted.

There is no update script necessary, since reload alters the

constraint.

Options
    • -2
    • +2
    ./xowiki-procs.tcl
7:48 pm

gustafn

undo recent change, which is not sufficiently general (and solve the issue by db means, next commit)

Options
    • -4
    • +1
    ./package-procs.tcl
    • -57
    • +1
    ./xowiki-callback-procs.tcl
3:56 pm

antoniop

Address the cornercase of form pages having their template stored in the same folder: when deleting items containing such a setup, cleanup these formpages first

Addresses a consequence of https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20220613165033

Options
    • -1
    • +5
    ./package-procs.tcl
    • -1
    • +58
    ./xowiki-callback-procs.tcl
Sunday 19 Jun 2022
5:33 pm

gustafn

remove traces of md5::md5, since ns_md5 is emulated also for AOLserver

Options
    • -7
    • +2
    ./includelet-procs.tcl
  2. … 2 more files in changeset.
Monday 13 Jun 2022
6:50 pm

gustafn

Drop "ON DELETE CASCADE" on page_template, since this might lead to crippled entries in the database.

When someone delets via operations in the database a form, protentially existing

form pages refering to this item might be left in a crippled state.

The cascade operation deletes the revision (xowiki_page_instance), but leaves

the half-crippled item. The problem does not exist over the web interface,

since it does not allow such items to be deleted while form pages exist.

Options
    • -2
    • +2
    ./xowiki-procs.tcl
    • -1
    • +19
    ./upgrade/upgrade.tcl
  3. … 1 more file in changeset.
6:45 pm

gustafn

Add support for menu-entries, where simply a "-link" is provided

Options
    • -1
    • +3
    ./menu-procs.tcl
Thursday 02 Jun 2022
12:00 pm

gustafn

Provide a fix for "dom parse -html ..." for adp tags.

"dom parse -html" has two problems with ADP tags like "<adp:icon ...>":

a) If the tag name contains a colon or underscore, the tag is

treated like plain text, i.e. "<" and ">" are converted into

HTML entities.

b) These tags have to be closed "<adp:icon ...>" is invalid.

Several existomg ADP tags have not closing tag.

Therefore, we resolve the ADP tags before parsing the text by

tdom. There should be some future framework support to do this in

general, but until we have this, resolve this problem here locally.

Options
    • -4
    • +17
    ./xowiki-www-procs.tcl
11:25 am

gustafn

New method "marshall_all_to_file"

This method is similar to "marshall_all", but exports the objects

directly to a file. This can save memory when exporting a large

collection of objects, since the plain "marshall_all" appends to

string, which can get very large, especially due to Tcl's

"double the size when space is needed" policy during "append"

operations.

Options
    • -1
    • +31
    ./import-procs.tcl
Monday 09 May 2022
7:29 pm

gustafn

fix for old-style ad_form based forms with radio or checkbox controls for bootstrap 5

These controls were used with a bootstrap3 classes, which had the consequence

that no input was possible for these fields. Probably, similar changes

are as well necessary in other situations as well.

Options
    • -2
    • +11
    ./form-field-procs.tcl
Friday 06 May 2022
8:36 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./package-procs.tcl
8:36 pm

gustafn

tdom sometimes html-escapes unknown tags

Consider code like

#

# dom parse -simple -html $form doc

# ...

# return [$root asHTML]

Unfortunately, this causes that some tags unknown to tdom

(like <adp:icon>) are converted to escaped tags (&lt; ...).

This can be regarded as a bug. To avoid this problem, we

substitute here the adp_tags in advance. This needs more

investigation in other cases.... The potential harm in this

cases here is very little, but probably, there are other

cases as well where this might harm.

Options
    • -2
    • +17
    ./xowiki-procs.tcl
Thursday 05 May 2022
9:11 am

trenner

escape also brackets

Options
    • -2
    • +2
    ./form-field-procs.tcl
Wednesday 27 Apr 2022
8:57 pm

gustafn

added context_id to excluded vars in copy_content_vars

Options
    • -2
    • +2
    ./xowiki-procs.tcl
Sunday 24 Apr 2022
7:00 pm

gustafn

added download icon for CSV

Options
    • -1
    • +1
    ./table-widget-procs.tcl
  2. … 1 more file in changeset.
10:39 am

gustafn

make regression test more robust with respect to yui rendering

Options
    • -1
    • +1
    ./test/includelet-test-procs.tcl
9:33 am

gustafn

Styling changes for minimal setups

This change is necessary for minimal setups, e.g. for plain installs

during regression test, when no bootstrap packages are available.

- define yui as last-resort fallback for "toolkit"

- handle CSS class composition for YUI as well

(merge of class-specific and item specific CSS classes,

used for color management for publish status button)

- remove underline for publish-status in YUI mode

Options
    • -3
    • +6
    ./package-procs.tcl
    • -3
    • +9
    ./yui-procs.tcl
  3. … 1 more file in changeset.
Thursday 21 Apr 2022
1:34 pm

antoniop

Cleanup dummy commands and objects to avoid cross interactions between tests

Options
    • -2
    • +3
    ./test/xowiki-admin-tests-procs.tcl
  2. … 1 more file in changeset.
Wednesday 20 Apr 2022
8:54 am

antoniop

Cleanup test for deleted api

Options
    • -23
    • +0
    ./test/api-test-procs.tcl
Tuesday 19 Apr 2022
2:29 pm

gustafn

get rid of "xowiki::adp_parse_tags", since this is handled now already in acs-templating

Options
    • -3
    • +3
    ./personal-notification-procs.tcl
    • -2
    • +2
    ./xowiki-procs.tcl
    • -37
    • +1
    ./xowiki-utility-procs.tcl
    • -3
    • +3
    ./xowiki-www-procs.tcl
  5. … 1 more file in changeset.
Friday 15 Apr 2022
7:29 pm

gustafn

do not cache some volatile info in xowiki::file objects

Options
    • -1
    • +2
    ./xowiki-procs.tcl