OpenACS / openacs-4 / packages / xowiki / tcl

xowiki-www-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 10:50
Commits this week: 0
Total Lines of Code (LoC): 3,243
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Aug 2022
11:53 am

gustafn

Fixed serious bug killing at least short-text questions in inclass exam

The bug was introduced in [1], by testing for the existence of the

disabled attribute, and when it exists, it was omitting values

reading. The problem is that when form-fields are reset, the

"disabled" attribute is set to 0, leading the exists check to

succeed. In essence, This change sets now the default value of the

form-field to "0", such that it is safe to test it everywhere.

Originally, it was not set by default to save resources (memory and

processing power), but this requires a more careful analysis when

changes happen.

[1] https://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl?r1=1.368.2.125&r2=1.368.2.126

Options
    • -12
    • +11
    ./xowiki-www-procs.tcl
  2. … 1 more file in changeset.
Sunday 21 Aug 2022
6:46 pm

gustafn

rename "iconified file" to "thumbnail file"

Options
    • -3
    • +3
    ./xowiki-www-procs.tcl
  2. … 3 more files in changeset.
Saturday 20 Aug 2022
5:43 pm

gustafn

Extended functionality of the DropZone widget

- added parameters "label", "disposition" and "file_name_prefix"

for better configurability

- added support for updating the current page with feedback of the

dropped files. This is used e.g. by the online exam in the exam

protocol to display incrementally thumbnails of feedback files.

- change property "uploader" to "disposition", since "uploader" is

somewhat ambiguous. "Disposition" defines, what happens after the

file was uploaded, e.g. whether the content has to be transformed,

etc.

- bumped version number to 5.10.1d35

Options
    • -14
    • +33
    ./xowiki-www-procs.tcl
  2. … 5 more files in changeset.
Wednesday 17 Aug 2022
7:06 pm

gustafn

Generalized handling of local_return_url

I am not fully happy with the handlings of "return_url" in exam workflows.

Maybe this can be reworked in a way such that "local_return_url" is not

neccsessary in the future.

Options
    • -5
    • +4
    ./xowiki-www-procs.tcl
  2. … 1 more file in changeset.
Thursday 11 Aug 2022
8:22 pm

antoniop

Skip processing for all formfields that are defined as disabled:

the browser should not send us these data in the first place.

Options
    • -21
    • +29
    ./xowiki-www-procs.tcl
Wednesday 13 Jul 2022
1:00 pm

gustafn

undo part of last change

unfortunatly, the 0.9.3 issue can't be fixed so simple as hoped. The "-html" flag is necessary for dealing with autoclosed entries.

Options
    • -2
    • +2
    ./xowiki-www-procs.tcl
  2. … 1 more file in changeset.
12:41 pm

gustafn

for orthogonaly, remove "-html" flag from dom parse to avoid a potential top-level <html> element

Options
    • -2
    • +2
    ./xowiki-www-procs.tcl
  2. … 4 more files in changeset.
Thursday 02 Jun 2022
12:00 pm

gustafn

Provide a fix for "dom parse -html ..." for adp tags.

"dom parse -html" has two problems with ADP tags like "<adp:icon ...>":

a) If the tag name contains a colon or underscore, the tag is

treated like plain text, i.e. "<" and ">" are converted into

HTML entities.

b) These tags have to be closed "<adp:icon ...>" is invalid.

Several existomg ADP tags have not closing tag.

Therefore, we resolve the ADP tags before parsing the text by

tdom. There should be some future framework support to do this in

general, but until we have this, resolve this problem here locally.

Options
    • -4
    • +17
    ./xowiki-www-procs.tcl
Tuesday 19 Apr 2022
2:29 pm

gustafn

get rid of "xowiki::adp_parse_tags", since this is handled now already in acs-templating

Options
    • -3
    • +3
    ./xowiki-www-procs.tcl
  2. … 4 more files in changeset.
Thursday 14 Apr 2022
12:11 pm

gustafn

Do not force all validation errors to the end of a form.

Caveat: we might miss some validation errors in cases,

where render_item is not used.... but such cases rarely

exist. Provide an log message to identify such cases

that would require further changes. The advantage of

having potentially the message at the right place

is more important for the time being since this is

a usability issue for large forms.

Options
    • -12
    • +28
    ./xowiki-www-procs.tcl
Tuesday 12 Apr 2022
10:44 am

gustafn

perform adp-tag subsitution also in xowiki footer

Options
    • -3
    • +2
    ./xowiki-www-procs.tcl
Monday 11 Apr 2022
1:33 pm

gustafn

fix misspelled name

Options
    • -2
    • +2
    ./xowiki-www-procs.tcl
Saturday 09 Apr 2022
4:57 pm

gustafn

reduce hard-coded icons

Options
    • -9
    • +7
    ./xowiki-www-procs.tcl
  2. … 2 more files in changeset.
4:55 pm

gustafn

apply parse_adp_tags on full rendered text in www-view

Options
    • -1
    • +2
    ./xowiki-www-procs.tcl
Friday 25 Mar 2022
11:13 am

gustafn

Perform stricter checking of parent_ids

bump version number of xowiki to 5.10.1d22

Options
    • -5
    • +15
    ./xowiki-www-procs.tcl
  2. … 3 more files in changeset.
Tuesday 15 Mar 2022
1:01 pm

gustafn

prefer global variable over proc

Options
    • -2
    • +2
    ./xowiki-www-procs.tcl
  2. … 6 more files in changeset.
Saturday 05 Mar 2022
10:35 am

gustafn

keep avoiding call "value_if_nothing_is_returned_from_form" for disabled field

This change reverts to the previous behavior and is logically sound.

All regression test continue to work. Not clear, why Antonio removed

this call (maybe due to downstream changes, but these should be

sorted out).

Options
    • -6
    • +9
    ./xowiki-www-procs.tcl
Friday 04 Mar 2022
5:06 pm

antoniop

Port of downstream feature: optionally allow to instantiate the items before deletion in order to apply specific class logics

Options
    • -2
    • +14
    ./xowiki-www-procs.tcl
4:24 pm

trenner

execute configure proc after page was created

Options
    • -14
    • +14
    ./xowiki-www-procs.tcl
3:55 pm

antoniop

Treat disabled form fields as they are: fields that the browser would not send to us and need to be treated "internally"

Options
    • -6
    • +2
    ./xowiki-www-procs.tcl
  2. … 1 more file in changeset.
Monday 21 Feb 2022
12:53 pm

gustafn

Added the option to parameterize www-delete and www-toggle-publish-status with return_url

In cases, these www* methods are called programmatically, these can be

now parameterized with an "-return_url" parameter to achieve

e.g. workflow-specific behavior.

Many thanks to Thomas Renner for the analysis on

www-toggle-publish-status.

Version number bumped to 5.10.1d18

Options
    • -6
    • +17
    ./xowiki-www-procs.tcl
  2. … 2 more files in changeset.
Sunday 20 Feb 2022
6:09 pm

gustafn

Modernize code

- use dict instead of Tcl array

- prefer char operations instead of match operations

Options
    • -6
    • +8
    ./xowiki-www-procs.tcl
Tuesday 25 Jan 2022
11:15 pm

gustafn

prefer "string first" over "string match" (the first one is slightly faster)

Options
    • -8
    • +7
    ./xowiki-www-procs.tcl
Saturday 22 Jan 2022
7:10 pm

gustafn

Don't break the page cyclus protocol if not necessary.

There is no need to call ad_script_abort in a situation,

where the local installation is broken.

Options
    • -9
    • +16
    ./xowiki-www-procs.tcl
Sunday 09 Jan 2022
6:23 pm

gustafn

Various small improvements:

- Page->content_header_append/content_header_get: new methods to

include HTML content before the form. One use case ist to include

additional forms this way, since these cannot be included in the

main form of a FormPage. The additional content is displayed in the

www-view method.

- FormPage->create_form_fields_from_names: new convenience function to create

form-fields via their names. The definitions of the named form-fields are

taken from the provided form_constraints. This function is useful when

only a subset of the form-constraints definitions should be used

to create form-fields.

- improve comments

- improve argument checking on parent_id to be able to provide better

error messages

- reduce usage of regexp for performance reasons

- improve spelling

Options
    • -7
    • +27
    ./xowiki-www-procs.tcl
  2. … 2 more files in changeset.
Sunday 02 Jan 2022
5:15 pm

gustafn

minor editing changes

Options
    • -4
    • +7
    ./xowiki-www-procs.tcl
Wednesday 29 Dec 2021
4:41 pm

antoniop

Make error consistent with the already existing check in the content-repository

Options
    • -2
    • +2
    ./xowiki-www-procs.tcl
4:38 pm

antoniop

Handle more gracefully the case, which should not happen on a production system, that the file being downloaded does not exist on the filesystem

Options
    • -1
    • +12
    ./xowiki-www-procs.tcl
Saturday 25 Dec 2021
5:10 pm

gustafn

Added archiving of items, reduced usage of images for icons

When an item is archived, it is not shown to plain users. Internally,

when an item is archived, the publish status is changed to "expired"

and removed from search/syndication. When an item is archived, it can

be brought via "toggle-publish-status" to state "production" again.

Future versions might rename the item in such conditions, but

currently, it is NOT renamed, so one cannot create one more item in

the same folder with the same name.

For realizing this functionality, the includelet "form-usages" accepts

now an additional optional value for "-buttons" named "archive". The

publish status toggle can be used now for switching from

"production"->"ready", "ready"->"production" and

"expired"->"production".

Additionally, the usage of .png images as icons was reduced by CSS

elements for easier styling (e.g., for different themes) and for

reducing less server requests and better responsiveness. In particular

the images for active.png and inactive.png are not necessary any more

and were removed.

Bumped version number to 5.10.1d8 to enforce loading of the message

keys.

Options
    • -3
    • +3
    ./xowiki-www-procs.tcl
  2. … 13 more files in changeset.
Sunday 19 Dec 2021
4:45 pm

gustafn

white-space changes

Options
    • -2
    • +2
    ./xowiki-www-procs.tcl
  2. … 1 more file in changeset.