• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Provide a fix for "dom parse -html ..." for adp tags.

"dom parse -html" has two problems with ADP tags like "<adp:icon ...>":

a) If the tag name contains a colon or underscore, the tag is

treated like plain text, i.e. "<" and ">" are converted into

HTML entities.

b) These tags have to be closed "<adp:icon ...>" is invalid.

Several existomg ADP tags have not closing tag.

Therefore, we resolve the ADP tags before parsing the text by

tdom. There should be some future framework support to do this in

general, but until we have this, resolve this problem here locally.

get rid of "xowiki::adp_parse_tags", since this is handled now already in acs-templating

  1. … 4 more files in changeset.
Do not force all validation errors to the end of a form.

Caveat: we might miss some validation errors in cases,

where render_item is not used.... but such cases rarely

exist. Provide an log message to identify such cases

that would require further changes. The advantage of

having potentially the message at the right place

is more important for the time being since this is

a usability issue for large forms.

perform adp-tag subsitution also in xowiki footer

fix misspelled name

reduce hard-coded icons

  1. … 2 more files in changeset.
apply parse_adp_tags on full rendered text in www-view

Perform stricter checking of parent_ids

bump version number of xowiki to 5.10.1d22

  1. … 3 more files in changeset.
prefer global variable over proc

  1. … 6 more files in changeset.
keep avoiding call "value_if_nothing_is_returned_from_form" for disabled field

This change reverts to the previous behavior and is logically sound.

All regression test continue to work. Not clear, why Antonio removed

this call (maybe due to downstream changes, but these should be

sorted out).

Port of downstream feature: optionally allow to instantiate the items before deletion in order to apply specific class logics

execute configure proc after page was created

Treat disabled form fields as they are: fields that the browser would not send to us and need to be treated "internally"

  1. … 1 more file in changeset.
Added the option to parameterize www-delete and www-toggle-publish-status with return_url

In cases, these www* methods are called programmatically, these can be

now parameterized with an "-return_url" parameter to achieve

e.g. workflow-specific behavior.

Many thanks to Thomas Renner for the analysis on

www-toggle-publish-status.

Version number bumped to 5.10.1d18

  1. … 2 more files in changeset.
Modernize code

- use dict instead of Tcl array

- prefer char operations instead of match operations

prefer "string first" over "string match" (the first one is slightly faster)

Don't break the page cyclus protocol if not necessary.

There is no need to call ad_script_abort in a situation,

where the local installation is broken.

Various small improvements:

- Page->content_header_append/content_header_get: new methods to

include HTML content before the form. One use case ist to include

additional forms this way, since these cannot be included in the

main form of a FormPage. The additional content is displayed in the

www-view method.

- FormPage->create_form_fields_from_names: new convenience function to create

form-fields via their names. The definitions of the named form-fields are

taken from the provided form_constraints. This function is useful when

only a subset of the form-constraints definitions should be used

to create form-fields.

- improve comments

- improve argument checking on parent_id to be able to provide better

error messages

- reduce usage of regexp for performance reasons

- improve spelling

  1. … 2 more files in changeset.
minor editing changes

Make error consistent with the already existing check in the content-repository

Handle more gracefully the case, which should not happen on a production system, that the file being downloaded does not exist on the filesystem

Added archiving of items, reduced usage of images for icons

When an item is archived, it is not shown to plain users. Internally,

when an item is archived, the publish status is changed to "expired"

and removed from search/syndication. When an item is archived, it can

be brought via "toggle-publish-status" to state "production" again.

Future versions might rename the item in such conditions, but

currently, it is NOT renamed, so one cannot create one more item in

the same folder with the same name.

For realizing this functionality, the includelet "form-usages" accepts

now an additional optional value for "-buttons" named "archive". The

publish status toggle can be used now for switching from

"production"->"ready", "ready"->"production" and

"expired"->"production".

Additionally, the usage of .png images as icons was reduced by CSS

elements for easier styling (e.g., for different themes) and for

reducing less server requests and better responsiveness. In particular

the images for active.png and inactive.png are not necessary any more

and were removed.

Bumped version number to 5.10.1d8 to enforce loading of the message

keys.

  1. … 13 more files in changeset.
white-space changes

  1. … 1 more file in changeset.
solve property resolution in form-usages by avoiding lookups from the current item to reduce side effects

CVS: ----------------------------------------------------------------------

fix form field property resolution: in form-usages, default values were overruling the specified properties

revert regression introduced on Aug 07 and factor out common code

New CSS abstraction: xowiki::CSS

Before this change, the application developer was responsible to

initialize the CSS-speficic settings (such as setting default values

for parameter classes). The new object xowiki::CSS is initialized

automatically, when an xowiki class (or one of its subclasses) is

initialized. Furthermore, it provides a per-thread caching to reduce

double work. Furthermore, the xowiki::CSS provides a mapping between

abstract and concrete CSS class names, such that switching between

different CSS toolkits becomes easier (e.g. upgrade from bootstrap 3

to newer versions).

xowiki::CSS initialize ;# make sure, everything is in line with PreferredCSSToolkit

xowiki::CSS clear ;# reset the mapping

xowiki::CSS toolkit ;# return the toolkit name

xowiki::CSS class /classname/ ;# perform CSS class name mapping

The methods "setCSSDefaults" and "preferredCSSToolkit" as deprecated.

The version number was bumped to 5.10.0d81

  1. … 7 more files in changeset.
streamline returnredirect commands

make sure, the provided URL is always properly encoded

  1. … 2 more files in changeset.
Do not urlencode the return URL in every case, but only when this falls back to the current URL from the connection context, normally coming from "ns_conn url" which will return it "raw", as in not encoded for any purpose

URLencode the return URL, or the server might complain for invalid characters (e.g. unencoded umlaut characters)