OpenACS / openacs-4 / packages / xotcl-core

www

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 14 Nov
Commits this week: 0
Total Lines of Code (LoC): 2,166
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 29 Oct
5:37 pm

gustafn

moved xo::getObjectProperty to ::apidoc::get_object_property

Options
    • -3
    • +3
    ./index.tcl
    • -23
    • +23
    ./show-object.tcl
  3. … 8 more files in changeset.
Tuesday 22 Oct
10:48 am

gustafn

improved source code documentation

Options
    • -1
    • +4
    ./show-object.tcl
Thursday 17 Oct
3:01 pm

antoniop

Fix typo

Options
    • -2
    • +1
    ./show-object.tcl
Wednesday 16 Oct
11:21 am

gustafn

Added code to skip suspicious looking query variables

On openacs.org, we are experiencing numerous requests with

multiply very long and strange query variables like in the example

below. So far, it is not clear, whether these requests are the

consequence of a double encoding or a deliberate attack. Many (most)

of the requests contain the query variable names containing the

(decoded) pattern "*amp;*".

This is a relatively new phenomenon. I cannot exclude that this is a

bug introduced lately in OpenACS, or a bug in an external bot, or

whatever. The problem with these query variables is that OpenACS

propagates these further, e.g., when updating query variables in

ad_dimensional, via export_vars, or return_urls.

Since OpenACS never uses these query-variables, these can be safely

skipped, without loosing functionality in OpenACS. It is possible to

construct examples, where skipping such variables can change the

semantics. Therefore, the change introduces a single function

util::suspicious_query_variable where in case of problems, the

skipping feature can be deactivated.

GET /api-doc/proc-browse?amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&type=All&amp%3btype=All&amp%3bamp%3btype=All&amp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=Private&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All HTTP/1.1" 200 62378 "" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/605.1.15 (KHTML, like Gecko; compatible; FriendlyCrawler/1.0) Chrome/120.0.6099.216 Safari/605.1.15" "1729029614.331581 0.109805 0.000434 0.004026 0.215927

Options
    • -1
    • +11
    ./show-object.tcl
  2. … 6 more files in changeset.
Tuesday 08 Oct
5:04 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    ./show-object.tcl
  2. … 7 more files in changeset.
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./index.tcl
    • -0
    • +0
    ./show-class-graph.tcl
    • -0
    • +0
    ./show-object.tcl
  4. … 1462 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -12
    • +27
    ./cache.tcl
    • -3
    • +3
    ./index.tcl
    • -24
    • +32
    ./show-class-graph.tcl
    • -43
    • +23
    ./show-object.tcl
    • -1
    • +3
    ./version-numbers.tcl
    • -47
    • +54
    ./admin/toggle-debug.tcl
  7. … 8094 more files in changeset.
Tuesday 27 Aug
12:06 pm

gustafn

whitespace changes

Options
    • -2
    • +2
    ./show-class-graph.tcl
  2. … 15 more files in changeset.
Wednesday 07 Aug
3:51 pm

gustafn

require login for version numbers, since this reveals internal information

Options
    • -0
    • +2
    ./version-numbers.tcl
Friday 06 Oct 2023
2:09 pm

gustafn

harden page contracts

Options
    • -5
    • +5
    ./cache.tcl
    • -6
    • +6
    ./show-class-graph.tcl
  3. … 21 more files in changeset.
Saturday 26 Nov 2022
6:00 pm

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -7
    • +10
    ./show-class-graph.tcl
  2. … 5 more files in changeset.
Saturday 26 Feb 2022
3:37 pm

gustafn

pass "hide methods" to svg generation

Options
    • -5
    • +3
    ./show-object.tcl
  2. … 1 more file in changeset.
Monday 17 Jan 2022
10:33 am

gustafn

xotcl/chache: added button to flush all caches

Options
    • -3
    • +16
    ./cache.tcl
Monday 29 Nov 2021
2:20 pm

gustafn

remove pipe open (although this is just a fallback file, which is normally not called)

Options
    • -16
    • +22
    ./show-class-graph.tcl
Thursday 07 Oct 2021
1:06 pm

gustafn

reuse util::inline_svg_from_dot in show-object page

Options
    • -36
    • +6
    ./show-object.tcl
Monday 04 Oct 2021
7:18 pm

gustafn

provide a for-free implementation of dot rendering

On sites with a large footprint, the fork might take a while, binging eveything to a hold

Options
    • -9
    • +19
    ./show-object.tcl
  2. … 1 more file in changeset.
4:22 pm

trenner

don't produce unused images

Options
    • -2
    • +2
    ./show-object.tcl
Monday 02 Aug 2021
11:16 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

Options
    • -2
    • +1
    ./show-class-graph.tcl
    • -9
    • +7
    ./show-object.tcl
  3. … 1 more file in changeset.
Wednesday 26 Aug 2020
8:50 pm

gustafn

whitespace cleanup

Options
    • -3
    • +3
    ./index.tcl
    • -3
    • +3
    ./show-class-graph.tcl
    • -1
    • +1
    ./version-numbers.tcl
  4. … 10 more files in changeset.
Saturday 08 Aug 2020
10:08 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./show-class-graph.tcl
    • -2
    • +2
    ./show-object.tcl
  3. … 9 more files in changeset.
Friday 07 Feb 2020
9:44 am

gustafn

whitespace changes and editor hints for all xo* packages

Options
    • -47
    • +54
    ./admin/toggle-debug.tcl
  2. … 15 more files in changeset.
Wednesday 16 Oct 2019
12:24 pm

gustafn

impreve robustness of ad_doc parsing

Options
    • -2
    • +6
    ./show-object.tcl
Friday 09 Aug 2019
9:45 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./show-object.tcl
  2. … 15 more files in changeset.
Saturday 30 Mar 2019
8:32 pm

gustafn

whitespace cleanup

Options
    • -5
    • +5
    ./cache.tcl
8:31 pm

gustafn

avoid double substitution

Options
    • -3
    • +5
    ./cache.tcl
Sunday 10 Mar 2019
10:01 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./show-class-graph.tcl
    • -2
    • +2
    ./show-object.tcl
  3. … 7 more files in changeset.
Friday 01 Mar 2019
11:00 am

antoniop

Replace ad_decode idiom

Options
    • -2
    • +2
    ./show-object.tcl
  2. … 4 more files in changeset.
Sunday 09 Sep 2018
3:11 pm

gustafn

white-space cleanup

Options
    • -12
    • +12
    ./show-object.tcl
3:10 pm

gustafn

improve robustness of output, when dot fails to produce output

Options
    • -2
    • +7
    ./show-object.tcl
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -4
    • +4
    ./show-object.tcl
  2. … 475 more files in changeset.