• last updated 10 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Fixed bug with value-constraints query parameters

Previous versions had a problem with calls like

:query_parameter name:SOMECONSTRAINT

since the implementation clobbered the name variable. Versions of NSF

later than 2022-01-21 support "nsf::parseargs" with the "-asdict"

option, which can use all the nsf::parseargs options and avoids


Added tests of "xo::cc query_parameters" to the regression test suite.

  1. … 1 more file in changeset.
file context-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
update list of checked procs

improve documentation and streamline code

  1. … 2 more files in changeset.
Use built-in "ns_parsequery" instead of manual parsing of query parameters.

Note, that this change might alter query processing, since previously

query parameter without explicit values were treated as boolean values

(like in HTML), now these are treated like "x=" before. The new version is

about 10x faster.

Furthermore, new tests of the regression tests were added for query parameter


  1. … 1 more file in changeset.
file api-test-procs.tcl was initially added on branch oacs-5-10.

fixed description of test file

fix entry in listing of covered procs

improve test coverage

  1. … 2 more files in changeset.
improve test coverage

improve listing of test coverage

    • -12
    • +17
  1. … 5 more files in changeset.
improve listing of test coverage

  1. … 7 more files in changeset.
make listing of tested procs more complete

  1. … 11 more files in changeset.
Fix tested proc name.

::xo::db::Class get_instance_from_db is defined using ad_proc instead of instproc.

Fixes the acs_api_browser_api_get_body test case.

extend test coverage

Remove 'check_xotcl_xocc' test case, as it has served its purpose already

Add 'check_xotcl_xocc' test case, checking for 'xo::cc'.

The intention of this test is to expose the destruction of the '::xo::cc' object, as a side effect of the 'check_xotcl' test. The test will fail if executed after it, and succeed otherwise.

The object destruction affects other tests executed in the same batch, and breaks in particular xowf's 'create_folder_with_page'.

The 'check_xotcl' test runs the 'Serializer all' method, which is calling 'xo::at_cleanup', destroying the '::xo::cc' object.

whitespace cleanup

    • -11
    • +11
  1. … 11 more files in changeset.
make test more robust against extending attributes

improve spelling

  1. … 2 more files in changeset.
prefer "nsf::is object" over ":isobject" or "info commands", since it is faster, more generic and can be used in all contexts

  1. … 10 more files in changeset.
Add a quick run of the basic CRUD operations on ORM to avoid issues when e.g. no particular object member is explicitly supplied

Modifying IP really comes from the item and not from the revision (as normally comes from the automatically generated view ${table_name}i which says so)

Do not return empty context_ids for the test, make sure value will have to change

Test behavior before and after a full fetch, make sure that the chosen context_id is not the previous one

Be stricter in CrItem tests as well

Be stricter and treat known suboptimal behaviors in ORM interface as test failures

Fix xotcl-core cr-items test: modifying IP comes in fact from the cr_item's acs_object (it is also on the revision, but on the items seems to take into account e.g. proxying)

add test cases from the xotcl-core DB tutorial

    • -0
    • +261
file xotcl-core-db-tutorial-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0