• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Cleanup smelly comments and behavior that would be better implemented in xowiki when we will get rid of the ckeditor4 dependency (post 5.10.1 release)

Remove xowiki dependency from CKEditor4

Rationale: CKEditor4 is EOL for its free version and the paid LTS version will be discontinued in December 2026.

We now do not set an explicit default for the preferred richtext editor. Instead, the first richtext-* package that will be installed with check whether a preferred editor was chosen. If not, they will set themselves as the xowiki editor. This should not change the behavior for existing installations already using ckeditor4, or a different editor.

fix ckeditor name from 4->5

Use canonical @return instead of @result

  1. … 1 more file in changeset.
improve spelling

  1. … 10 more files in changeset.
Fix result of get_tag when JSEditorClass is "ClassicEditor"

Use plain tcl "try" instead of "ad_try"

Initial version of ckeditor5 support for acs-templating

Note that this is an initial relase. several features of CKEditor5 are coming soon (easy imaging),

the whole ckeditor5 release is alpha. Some options of the ck4ditor integration

are copied over to ckeditor5, although there is no support yet.

Configuration:

In addition to the richttext widget properties,

https://openacs.org/api-doc/proc-view?proc=template::widget::richtext&source_p=1

the CKEditor 5 allows us to specify a editor class

Note: CKEditor 5 no longer comes with a configuration setting to change its height.

https://stackoverflow.com/questions/46559354/how-to-set-the-height-of-ckeditor-5-classic-editor/46559355#46559355

    • -0
    • +33
    ./richtext-ckeditor5.info
    • -0
    • +88
    ./lib/file-browser.adp
    • -0
    • +27
    ./lib/file-browser.tcl
    • -0
    • +246
    ./tcl/ckfinder-init.tcl
    • -0
    • +224
    ./tcl/ckfinder-procs.tcl
    • -0
    • +1
    ./tcl/richtext-init.tcl
    • -0
    • +389
    ./tcl/richtext-procs.tcl
    • -0
    • +11
    ./www/sitewide-admin/download.tcl
    • -0
    • +20
    ./www/sitewide-admin/index.adp
    • -0
    • +16
    ./www/sitewide-admin/index.tcl