• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
bumped version number from development version to release version

  1. … 93 more files in changeset.
silence regression test warning

Provide a script name for ad_proc

    • -0
    • +13
    ./tcl/test/notifications-test-procs.tcl
simplified exception handling by factoring out redundant code

make use of "ad_unless_script_abort"

    • -9
    • +13
    ./tcl/notifications-security-procs.tcl
    • -18
    • +15
    ./tcl/test/notifications-test-procs.tcl
handle script abort in proc handler

    • -8
    • +19
    ./tcl/test/notifications-test-procs.tcl
improved spelling

  1. … 14 more files in changeset.
Harden page contract

Whitespace changes

Cleanup obsolete variable

Use adp:icon feature to generate a style-aware icon on every theme

bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
improved spelling

  1. … 7 more files in changeset.
put the notification creation in a db_transaction to ensure same subscription is created only once (e.g. double-clicks)

Harden page contract

Harden page contract

improve spelling

  1. … 5 more files in changeset.
prefer usage of parameter::get_from_package_key over plain parameter::get

Fix incorrect HTTP status code on result page

The command "ad_return_error" returns HTTP status code 500 (internal server error).

In this script, this status code was returned in cases, where no notifications

were found for an object. "ad_return_exception_page" is better suited for such

cases.

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

    • -10
    • +18
    ./tcl/notification-callback-procs.tcl
  1. … 13 more files in changeset.
Whitespace cleanup

    • -11
    • +11
    ./tcl/notification-type-procs.tcl
Use quicker idiom to check for existance

Whitespace cleanup

Whitespace changes

Prefer api to retrieve the approval state of a user

    • -2
    • +2
    ./tcl/notifications-security-procs.tcl
    • -14
    • +0
    ./tcl/notifications-security-procs.xql
Complete coverage for the notification package

    • -0
    • +247
    ./tcl/test/notifications-test-procs.tcl
Brutally delete the notification requests before deleting the delivery method (it's fine because it will be rolled back)

    • -0
    • +1
    ./tcl/test/notifications-test-procs.tcl
Fix issue in the query logics: we actually want to check the owner of the request, there might be multiple requests associated to the same object

    • -6
    • +6
    ./tcl/notifications-security-procs.tcl
    • -1
    • +10
    ./tcl/test/notifications-test-procs.tcl
Extend coverage, this will expose an api bug

    • -0
    • +179
    ./tcl/test/notifications-test-procs.tcl
Whitespace changes

Extend coverage

    • -1
    • +27
    ./tcl/test/notifications-test-procs.tcl
Cover more api

    • -0
    • +42
    ./tcl/test/notifications-test-procs.tcl