OpenACS / openacs-4 / packages / file-storage / www

download-archive

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 27 Dec
Commits this week: 0
Total Lines of Code (LoC): 39
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Feb
4:05 pm

antoniop

download-archive reform

File-Storage used to generate downloaded archives in tgz format, to then switch to zip, more user-friendly, in particular outside the Linux world (See https://openacs.org/forums/message-view?message_id=557561). To ease the transition, a couple of parameters and relative API were introduced that would allow to choose the preferred command one should use. During this reform however, default parameter values in the tcl code became inconsistent with those in the info file. Furthermore, the chosen defaults were set as absolute paths to the executable, which is not friendly to non-linux environments, or other scenarios where the "typical" Linux filesystem structure cannot be assumed (e.g. containers, MacOS...).

The only usage of this parameters/api was in fact in the download-archive vuh. In upstream codebase, no package references this file, not even the file-storage itself. Upon review, one could see that the file would also allow to specify a custom download filename via the path, which could be considered questionable. It would also execute the command in a way that once again assumes some form of Linux environment (e.g. invoking bash).

Save for the ability to customize the archive format and the anti-feature of being able to manipulate the archive filename via the path, the script largely relplicates www/download-zip, in a better shape after a few reforms hinted by e.g. penetration tools.

Given the aformentioned considerations, I have decided to make download-archive a simple redirect to download-zip. Specifying the object_id via the path will keep working, while URLs out there expecting the name to change will not fail, but the name will not be modified. The archive format will from now on be assumed to be zip.

Options
    • -57
    • +24
    ./index.vuh
  2. … 4 more files in changeset.
Friday 17 Mar 2023
2:29 pm

antoniop

Deprecate trivial fs::get_archive_extension and inline its only upstream occurrence

Options
    • -2
    • +2
    ./index.vuh
  2. … 1 more file in changeset.
Wednesday 30 Nov 2022
9:18 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -5
    • +3
    ./index.vuh
  2. … 2 more files in changeset.
Tuesday 17 Dec 2019
5:53 pm

antoniop

Deprecate with_finally and with_catch, superseded by e.g. try idioms in tcl 8.6

They would also not comply with OpenACS naming convention

Options
    • -7
    • +2
    ./index.vuh
  2. … 4 more files in changeset.
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -1
    • +7
    ./index.vuh
  2. … 7834 more files in changeset.
Thursday 09 Jun 2016
11:13 am

gustafn

- add editor hints to .vuh files

Options
    • -1
    • +7
    ./index.vuh
  2. … 30 more files in changeset.
Monday 27 Apr 2015
5:28 pm

victorg

Merging back to HEAD all changes that happened in branch oacs-5-8 between tags: vg-merge-oacs-5-8-from-20141027 and vg-merge-oacs-5-8-from-20150427

Options
    • -4
    • +11
    ./index.vuh
  2. … 520 more files in changeset.
Friday 10 Apr 2015
11:52 am

gustafn

- improve robustness of download-archive

Options
    • -3
    • +10
    ./index.vuh
  2. … 2 more files in changeset.
Friday 28 Nov 2014
4:14 pm

gustafn

- replace deprecated ad_require_permission by permission::require_permission in index.vuh files

- replace deprecated ns_tmpnam by ad_tmpname in index.vuh files

Options
    • -3
    • +3
    ./index.vuh
  2. … 3 more files in changeset.
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -4
    • +4
    ./index.vuh
  2. … 2547 more files in changeset.
Tuesday 29 Jul 2014
1:37 pm

gustafn

- use consistently "naturalnum" instead of "integer" when accepting just positive values

Options
    • -2
    • +2
    ./index.vuh
  2. … 33 more files in changeset.
Sunday 08 Sep 2013
10:11 am

gustafn

- modernize tcl

Options
    • -3
    • +3
    ./index.vuh
  2. … 8 more files in changeset.
Thursday 26 May 2005
10:28 am

maltes

Added callbacks for integration with PM. Made sure the package_id is set correctly

Options
    • -1
    • +1
    ./index.vuh
  2. … 61 more files in changeset.
Monday 08 Dec 2003
5:47 pm

lars

Accidentally committed debugging statement

Options
    • -2
    • +1
    ./index.vuh
4:12 pm

lars

Fixed bug #929:

- Added a hint that if you're uploading internally linked files, you should leave title blank

- Verified fix for bug #1051 to allow renaming of files

- Changed link for latest revision on file detail page to use view/... URL instead of download/...

- Verified that you can indeed change the tar command to e.g. gtar, however you must do this on each file-storage instance individually

Options
    • -1
    • +2
    ./index.vuh
  2. … 8 more files in changeset.
Tuesday 06 Aug 2002
3:27 pm

yon

made download-archive and the publish_object_to_file_system api file system

safe, that is, removed file system special characters according to the

'filename' tcl api.

@see http://dev.scriptics.com/man/tcl8.3/TclCmd/filename.htm#M29

Options
    • -3
    • +3
    ./index.vuh
  2. … 1 more file in changeset.
Friday 31 May 2002
9:06 pm

yon

use bash instead of sh

Options
    • -2
    • +2
    ./index.vuh
Wednesday 22 May 2002
7:01 pm

yon

adding a safety check

Options
    • -1
    • +6
    ./index.vuh
  2. … 2 more files in changeset.
6:42 pm

yon

adding "download archive" code; moved some stuff around in publish_to_file_system procs

Options
    • -0
    • +61
    ./index.vuh
  2. … 8 more files in changeset.