• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

Bring test closer to reality

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

  1. … 2 more files in changeset.
Whitespace cleanup

acs::test::user::delete: added flag -delete_created_acs_objects and fix regression test for file-storage

  1. … 5 more files in changeset.
Fixes for Oracle 19c: more fixes of handling of Boolean values

ad_conn provides since a long time a fallback when the package_id is queried outside of a connection context, hence no need for these concerning catches

Make fs::get_file_package_id more robust to cases where the package_id is not set on the object itself: climb up the hierarchy

Reduce divergency between oracle and postgres codebase, bring together identical queries, fix typo in the xql file

    • -33
    • +1
    ./file-storage-rss-procs-oracle.xql
    • -34
    • +2
    ./file-storage-rss-procs-postgresql.xql
Whitespace cleanup

  1. … 1 more file in changeset.
fix typo

Fix typo, increase api coverage

allow to specify max upload size in configuration file in KB or MB

Fix test category, add tested api

Fix typo, write a basic test for the involved api

  1. … 1 more file in changeset.
Fix typo

Make oacs-dav only a weak dependency for file-storage, if the package is not there, just treat it as if the parameter was disabled

  1. … 2 more files in changeset.
perform proper cleanup after the test

Avoid rollback in web tests

Avoid rollback in 'fs_add_file_to_folder' test in particular

Rollback after tests

fix error message

Refactor query to go over the fs hierachy, rather than the permission one, add remarks

Recover logic went missing after refactoring (with some remarks)

break overlong lines

stick to content-repository API instead of duplicating code here.

    • -66
    • +0
    ./file-storage-procs-postgresql.xql
new function: ::content::revision::export_to_filesystem

This change moves functionality from file-storage to acs-content-repository.

all application packages should be free of internals, such as the storage

type. Storage_type should be handeled in the content-repository package.

We are not yet done, there is still more to do in this respect in

the file-storage package.

    • -16
    • +0
    ./file-storage-procs-postgresql.xql
  1. … 5 more files in changeset.
break overlong lines

improve spelling

  1. … 3 more files in changeset.
whitespace changes

  1. … 1 more file in changeset.