• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix cut&paste error

Cleanup debug statements, re-instate safe tmpfile check

Fixes acs-templating automated tests

adp:toggle_button: add "href" (default "#") for use when ... tag="a" ...

Added attributes "tag" and "type" to "adp:toggle_button" to increase applicability

- Bootstrap3 is picky and allows just "<a>" tags for the navigation

buttons, whereas Bootstrap4 and 5 would also allow <button> with

appropriate classes for nav-items and nav-links.

So, use <... tag="a"... > for use of nav buttons with potential

Dropdowns with Bootstrap 3.

- Potential attributes for this tag are:

- "tag" (default "button")

- "toggle"

- "target"

- "type" (default "button")

The attribute "type" is just valid when "tag" is "button".

- Many thanks to Monika Andergassen for the suggestion.

improved spelling

  1. … 2 more files in changeset.
minor changes: fixed typo, ease debugging, ...

Use modern api

Update api to streamline idiom

Update api

  1. … 1 more file in changeset.
Localize error message

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

  1. … 1 more file in changeset.
Gracefully reject invalid lists supplied as a file triple instead of failing and log the occurrence

Do not introduce extra newline in the content when writing to file

Test read/write of files via the templating api:

this will fail because we currently introduce an extra newline in the content

Deprecate template::form::export, superseded by export_vars

Cover additional api

Increase proc coverage

Increase proc coverage

Increase proc coverage, add more interesting values to the test

Test other trivial wrappers

Increase proc coverage

improved support for cluster-wide operations

  1. … 2 more files in changeset.
improve strictness of tests

  1. … 8 more files in changeset.
Replace ad_tmpnam with new tmpfile api, cleanup temporary files

improve spelling

  1. … 2 more files in changeset.
Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

  1. … 7 more files in changeset.
Improved appearance in TRN mode

- don't set "alt" attribute in classic mode by default to the title.

The title is often be provided as a message key, using it twice

causes two edit controls

- in acs-lang, the extra setting of link_html, which provided

the title attribute can be omitted, since adp:icon renders this

by itself.

  1. … 1 more file in changeset.
beautify TRN mode in developer support

in essence, this change switches from CSS icons to <adp:icon>

since in default setup (when no themes/icon sets are installed)

the CSS based rendering was bad. Using <adp:icon> offers

more flexibility and tailorability.

  1. … 3 more files in changeset.
fix wrong icon in "classic" mode (using images)

added warnings/errors in case outdated code is encountered