OpenACS / openacs-4 / packages / acs-tcl

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 71
Last Commit: 26 Apr
Commits this week: 1
Total Lines of Code (LoC): 65,995
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 17 Feb 2021
9:19 am

gustafn

mark functions as private

Options
    • -4
    • +4
    ./apm-procs.tcl
Tuesday 16 Feb 2021
9:59 pm

gustafn

improve listing of test coverage

Options
    • -251
    • +8
    ./test/acs-tcl-test-procs.tcl
    • -0
    • +265
    ./test/db-proc-test-procs.tcl
    • -6
    • +35
    ./test/html-conversion-procs.tcl
  4. … 15 more files in changeset.
6:17 pm

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./test/file-test-procs.tcl
3:19 pm

gustafn

improve listing of test coverage

Options
    • -0
    • +1
    ./test/acs-tcl-test-procs.tcl
  2. … 8 more files in changeset.
Monday 15 Feb 2021
6:53 pm

gustafn

make listing of tested procs more complete

Options
    • -6
    • +22
    ./test/acs-tcl-test-procs.tcl
    • -2
    • +4
    ./test/apm-parameter-test-procs.tcl
    • -0
    • +1
    ./test/application-data-link-procs.tcl
    • -2
    • +8
    ./test/community-core-test-procs.tcl
    • -14
    • +32
    ./test/datamodel-test-procs.tcl
    • -63
    • +69
    ./test/db-proc-test-procs.tcl
    • -7
    • +18
    ./test/doc-check-procs.tcl
    • -6
    • +27
    ./test/file-test-procs.tcl
    • -0
    • +1
    ./test/http-client-procs.tcl
    • -1
    • +4
    ./test/security-procs.tcl
    • -1
    • +2
    ./test/site-nodes-test-procs.tcl
    • -1
    • +2
    ./test/test-membership-rel-procs.tcl
    • -1
    • +3
    ./test/test-permissions-procs.tcl
  14. … 6 more files in changeset.
2:41 pm

gustafn

make listing of tested procs more complete

Options
    • -0
    • +4
    ./test/acs-tcl-test-procs.tcl
    • -0
    • +6
    ./test/navigation-procs.tcl
  3. … 1 more file in changeset.
2:27 pm

gustafn

make listing of tested procs more complete

Options
    • -1
    • +4
    ./test/acs-tcl-test-procs.tcl
    • -1
    • +2
    ./test/object-test-case-procs.tcl
  3. … 5 more files in changeset.
Sunday 14 Feb 2021
10:04 pm

gustafn

make code slightly more regular

Options
    • -15
    • +29
    ./acs-cache-procs.tcl
    • -15
    • +26
    ./test/doc-check-procs.tcl
10:47 am

gustafn

reduce verbosity

Options
    • -3
    • +1
    ./community-core-procs.tcl
Saturday 13 Feb 2021
9:24 pm

gustafn

remove race condition from user/person/party cache management

Options
    • -63
    • +81
    ./community-core-procs.tcl
6:31 pm

gustafn

2 new API functions acs_user::promote_person_to_user and acs_user::demote_user (see issue #3461)

acs_user::promote_person_to_user

Promotes a person/party to an ACS user.

@param person_id the person_id in the acs system that should be promoted to a user.

@param username the username to be used for this user.

Defaults to the person's email

@param password the password to be used for this user.

Defaults to a randomly generated password.

@param authority_id the authority that will be used for the user.

@param locale locale to be used in user preferences.

Defaults to the site wide locale is taken.

@return The user_id of the person promoted to user

@error An error is thrown

if the username is already in use,

or the person_id has no email address,

or if person_id is not in the persons table.

acs_user::demote_user

Demotes an ACS user to a person/party.

This will fail if other tables have content referencing the users

table. It is probably best for tables created in other packages

to reference persons, parties, or acs_objects instead. This proc

could be extended with an option to find all referenced tables and

remove rows referencing this user.

See the following FK relationship in basic OpenACS installations:

TABLE "acs_objects" CONSTRAINT "acs_objects_creation_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id)

TABLE "acs_objects" CONSTRAINT "acs_objects_modifying_user_fk" FOREIGN KEY (modifying_user) REFERENCES users(user_id)

TABLE "ad_locale_user_prefs" CONSTRAINT "ad_locale_user_prefs_users_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "auth_batch_job_entries" CONSTRAINT "auth_batch_job_entries_user_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE SET NULL

TABLE "auth_batch_jobs" CONSTRAINT "auth_batch_jobs_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id) ON DELETE SET NULL

TABLE "cr_news" CONSTRAINT "cr_news_approval_user_fk" FOREIGN KEY (approval_user) REFERENCES users(user_id)

TABLE "email_images" CONSTRAINT "email_images_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "forums_messages" CONSTRAINT "forums_mess_last_poster_fk" FOREIGN KEY (last_poster) REFERENCES users(user_id)

TABLE "forums_messages" CONSTRAINT "forums_mess_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "forums_reading_info" CONSTRAINT "forums_read_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "lang_messages_audit" CONSTRAINT "lang_messages_audit_ou_fk" FOREIGN KEY (overwrite_user) REFERENCES users(user_id)

TABLE "lang_messages" CONSTRAINT "lang_messages_creation_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id)

TABLE "lang_user_timezone" CONSTRAINT "lang_user_timezone_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "notification_replies" CONSTRAINT "notif_repl_from_fk" FOREIGN KEY (from_user) REFERENCES users(user_id)

TABLE "notification_user_map" CONSTRAINT "notif_user_map_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "notifications" CONSTRAINT "notifications_notif_user_fk" FOREIGN KEY (notif_user) REFERENCES users(user_id)

TABLE "notification_requests" CONSTRAINT "notifications_request_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "proctoring_examination_statement_acceptance" CONSTRAINT "proctoring_examination_statement_acceptance_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "user_portraits" CONSTRAINT "user_portraits_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "user_preferences" CONSTRAINT "user_preferences_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "xowiki_tags" CONSTRAINT "xowiki_tags_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(user_id)

Options
    • -9
    • +252
    ./community-core-procs.tcl
Monday 08 Feb 2021
12:47 pm

gustafn

support multiple argument messages for ad_log to improve compatibility with ns_log

Options
    • -4
    • +4
    ./utilities-procs.tcl
Saturday 06 Feb 2021
9:43 pm

gustafn

avoid array notation for per_thread caches to ease flushing

Options
    • -2
    • +2
    ./acs-permissions-procs.tcl
    • -2
    • +2
    ./security-procs.tcl
    • -2
    • +2
    ./site-nodes-procs.tcl
  4. … 3 more files in changeset.
Tuesday 02 Feb 2021
4:36 am

gustafn

mark f::reverse as depreacted. There is no evident reason, why not the built-in "lreverse" is used

Options
    • -2
    • +9
    ./ad-functional-procs.tcl
Monday 01 Feb 2021
11:47 am

gustafn

make end of options explicit

Options
    • -2
    • +2
    ./01-database-procs.tcl
    • -3
    • +3
    ./adp-parser-procs.tcl
    • -2
    • +2
    ./apm-install-procs.tcl
    • -3
    • +3
    ./apm-procs.tcl
    • -3
    • +3
    ./deprecated-procs.tcl
    • -1
    • +1
    ./html-procs.tcl
    • -4
    • +4
    ./install-procs.tcl
    • -4
    • +4
    ./json-procs.tcl
    • -2
    • +2
    ./request-processor-procs.tcl
    • -2
    • +2
    ./stack-trace-procs.tcl
    • -2
    • +2
    ./tcltrace-procs.tcl
    • -33
    • +33
    ./text-html-procs.tcl
    • -23
    • +23
    ./utilities-procs.tcl
    • -17
    • +17
    ./xml-0-sgml-procs.tcl
    • -2
    • +2
    ./xml-1-dom-procs.tcl
  16. … 28 more files in changeset.
Friday 29 Jan 2021
4:40 pm

gustafn

util_return_headers: set default charset for text content (in case none is specified and none is set in the config file) to utf-8 (was iso-8850-1)

Options
    • -2
    • +2
    ./utilities-procs.tcl
4:37 pm

gustafn

util_return_headers: align the behavior under AOLserver with NaviServer

Options
    • -1
    • +4
    ./utilities-procs.tcl
Wednesday 27 Jan 2021
9:24 pm

gustafn

added method "get" for "LockfreeCache" (somewhat similar to nsv_get)

Options
    • -1
    • +25
    ./acs-cache-procs.tcl
Monday 25 Jan 2021
5:43 pm

antoniop

Hack to force user agents logging in via the test api to exhibit a cookie based authentication

Options
    • -2
    • +27
    ./test/security-procs.tcl
Friday 22 Jan 2021
5:46 pm

gustafn

make call more robust in case "location" is not provided via config file

Options
    • -2
    • +2
    ./security-procs.tcl
Friday 15 Jan 2021
11:49 am

gustafn

provide compatibility for Tcl versions before tcl 8.6.2

Options
    • -1
    • +0
    ./test/00-icanuse-procs.tcl
Thursday 14 Jan 2021
10:35 pm

gustafn

Revert to previous strategy of determining available subcommands.

Running the provided subcommand is dangerous, since the command might

have side effects, might require connections, etc.

The feature test for "ns_http run" was incorrect, since it was not

introduced with 4.99.15 (as the comment suggested), but already with

4.99.4 (2017)... but at this time, the command did not return a dict,

which is assumed in the http-client procs. One can use "ns_http stats"

as an indicator for this feature, which was introduced at the time

when "ns_http run" was starting to return dicts as results.

Provide a more precise name for the feature test of ns_http returning

dicts (naming the feature simply "ns_http" is not a good idea, since

the command could of course be used already before the feature change).

Options
    • -14
    • +19
    ./00-icanuse-procs.tcl
    • -1
    • +1
    ./http-client-procs.tcl
    • -1
    • +1
    ./test/00-icanuse-procs.tcl
7:20 pm

gustafn

use 'self' for "security::csp::require object-src" instead of 'none' since the latter is non-incremental

Options
    • -2
    • +2
    ./security-procs.tcl
7:18 pm

gustafn

don't create a cache, which is not needed

Options
    • -5
    • +2
    ./security-init.tcl
3:40 pm

antoniop

Do not improperly rely on apm_version_names_compare to check for NaviServer version number, use a more reliable capability check instead

Options
    • -0
    • +4
    ./00-icanuse-procs.tcl
    • -9
    • +1
    ./http-client-procs.tcl
3:32 pm

antoniop

Change the regexp so that we catch multiple kinds of error pattern indicating the subcommand does not exist: NaviServer and Tcl return sligthly different error messages

Options
    • -1
    • +1
    ./00-icanuse-procs.tcl
3:30 pm

antoniop

Extend test to expose that we need a better idiom to detect also NaviServer commands

Options
    • -0
    • +14
    ./test/00-icanuse-procs.tcl
3:17 pm

antoniop

Use a different idiom to detect if a command supports a subcommand, fixing acs-tcl.acs__command_has_subcommand automated test

Options
    • -2
    • +8
    ./00-icanuse-procs.tcl
3:16 pm

antoniop

Fix wording

Options
    • -2
    • +2
    ./test/00-icanuse-procs.tcl
3:09 pm

antoniop

New test for acs::cmd_has_subcommand exposing how flags at the beginning and end of the error message are not properly recognized

Options
    • -0
    • +49
    ./test/00-icanuse-procs.tcl