OpenACS / openacs-4 / packages / acs-subsite

www

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 66
Last Commit: 08 May
Commits this week: 0
Total Lines of Code (LoC): 25,798
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jan
1:32 pm

antoniop

Improve documentation

Options
    • -0
    • +8
    ./resources/core.js
1:28 pm

antoniop

Cleanuo commented code

Options
    • -9
    • +0
    ./resources/core.js
1:28 pm

antoniop

Whitespace cleanup

Options
    • -2
    • +0
    ./resources/core.js
1:25 pm

antoniop

Move custom calendar widget javascript implementation out of the core.js and into a separate file

In core/maintained packages, this widget is used only by template::widget::textdate (which in turn is used nowhere). For this widget, we can include the relevant code on-demand.

Direct usages found in unsupported packages have been adapted by adding the extra requirement on the fly.

It is unclear if we should keep maintaining a calendar widget in our codebase, however, as the current one still works (kudos to the original author), we do not deprecate it for the time being.

It is also true that a custom widget provides a way to customize the look and feel of date fields, which is otherwise completely delegated to the browser.

Various packages, including the core, provide custom css styling for the current widget.

Options
    • -1603
    • +0
    ./resources/core.js
  2. … 2 more files in changeset.
Tuesday 23 Jan
4:04 pm

antoniop

Fix the idiom used to cut the query parameters from the URL

Options
    • -1
    • +1
    ./resources/core.js
1:07 pm

antoniop

Handle null dates

Options
    • -3
    • +4
    ./resources/core.js
8:39 am

antoniop

Modernize idioms

Options
    • -21
    • +11
    ./resources/core.js
8:26 am

antoniop

Cleanup acs_CopyText and inline the only usage found in the codebase with a modern replacement

The function was using deprecated idioms, see https://developer.mozilla.org/en-US/docs/Web/API/document/execCommand, and "PrivilegeManager" and the "netscape" property, both long discontinued.

On modern browsers, under the correct conditions, the function can be reimplemented via a oneliner (see https://developer.mozilla.org/en-US/docs/Web/API/Clipboard)

Options
    • -36
    • +0
    ./resources/core.js
Monday 22 Jan
7:18 pm

gustafn

provide link to nsstats on startup page on fresh installations (when available)

Options
    • -0
    • +4
    ./index.adp
    • -1
    • +2
    ./index.tcl
6:34 pm

gustafn

fix for containarized applications: don't use configured location unless host-name-map is in place

containeraized applications with the hostnode map will still have a problem, but these are

less frequent. For these, a solution is still pending.

Options
    • -8
    • +21
    ./admin/index.tcl
5:55 pm

antoniop

Shorten idiom

Options
    • -6
    • +3
    ./resources/core.js
5:50 pm

antoniop

Modernize idioms via optional chaining

Options
    • -6
    • +5
    ./resources/core.js
5:36 pm

antoniop

Prefer string interpolation via template literals

Options
    • -2
    • +2
    ./resources/core.js
5:33 pm

antoniop

Cleanup trivial acs_initHtmlArea and inline its only usages in the codebase

Options
    • -7
    • +0
    ./resources/core.js
5:13 pm

antoniop

Cleanup trivial api, nowadays replaceable with a simple oneliner and inline the only usage found upstream

Options
    • -9
    • +0
    ./resources/core.js
  2. … 1 more file in changeset.
5:06 pm

antoniop

Use modern javascript and browser features to simplify the code

Options
    • -16
    • +10
    ./resources/core.js
3:11 pm

antoniop

Use an idiom that does not assume the form field to be a direct child of the form, which may not be true depending on the theme

Options
    • -1
    • +4
    ./resources/core.js
2:49 pm

antoniop

Inline usages of acs_rte* js utilities in unmaintained packages and remove it from core.js

acs_rte* is most likely broken anyway, as nobody seems to define updateRTEs function...

Options
    • -14
    • +0
    ./resources/core.js
2:30 pm

antoniop

Factor richtext-or-file javascript outside of the core.js

This may or not be a step on the road to deprecating this widget, which still sports inline event handlers and is used only by unmaintained packages.

Options
    • -47
    • +0
    ./resources/core.js
  2. … 2 more files in changeset.
Tuesday 24 Oct 2023
9:38 am

antoniop

Make page more robust to situations, more frequest in a test setup, where a short-lived user has issued requests on the system and was recorded as online

Options
    • -4
    • +11
    ./shared/whos-online.tcl
Friday 06 Oct 2023
2:31 pm

gustafn

harden page contracts

Options
    • -2
    • +2
    ./admin/applications/application-delete.tcl
    • -2
    • +2
    ./admin/groups/new.tcl
    • -2
    • +2
    ./admin/parties/new.tcl
    • -3
    • +3
    ./admin/relations/add.tcl
    • -2
    • +2
    ./admin/site-map/package-new.tcl
    • -2
    • +2
    ./admin/users/new.tcl
    • -3
    • +3
    ./permissions/one.tcl
    • -1
    • +1
    ./permissions/perm-include.tcl
    • -2
    • +2
    ./user/basic-info-update.tcl
  10. … 16 more files in changeset.
Monday 07 Aug 2023
4:53 pm

antoniop

template::list bulk-actions feature:

allow to have URL parameters specified in the bulk-action URL, so that the same URL can be used to serve multiple bulk actions differentiated via different flags. The URL parameters override completely every attribute with the same name specified on the form.

Options
    • -5
    • +51
    ./resources/core.js
Thursday 13 Jul 2023
2:48 pm

gustafn

regenerated documetation

Options
    • -4
    • +2
    ./doc/group-admin-pages-acceptance-test.adp
    • -3
    • +3
    ./doc/group-admin-pages-requirements.adp
  3. … 40 more files in changeset.
Monday 03 Jul 2023
6:05 pm

antoniop

Don't assume xotcl api in core packages

Options
    • -3
    • +3
    ./permissions/perm-modify.tcl
Tuesday 06 Jun 2023
2:42 pm

antoniop

Replace deprecated api

Options
    • -3
    • +4
    ./image.vuh
  2. … 1 more file in changeset.
Monday 15 May 2023
12:02 am

gustafn

whitespace changes

Options
    • -4
    • +5
    ./register/logout.tcl
Tuesday 28 Mar 2023
1:20 pm

antoniop

Remove no_alarms_until column

Rationale: the column or the related api is never used in upstream code to check whether notifications should be sent or not or not. The UI to manage the column's value was not linked anywhere. On the instances accessible by me downstream, no tuple was found where this column had a value.

Options
    • -8
    • +0
    ./pvt/set-on-vacation-to-null.adp
    • -29
    • +0
    ./pvt/set-on-vacation-to-null.tcl
    • -24
    • +0
    ./pvt/set-on-vacation-to-null.xql
    • -12
    • +0
    ./pvt/set-on-vacation-until.adp
    • -42
    • +0
    ./pvt/set-on-vacation-until.tcl
    • -11
    • +0
    ./pvt/set-on-vacation-until.xql
  7. … 13 more files in changeset.
11:54 am

antoniop

Avoid fetching the request forum manually

Options
    • -8
    • +12
    ./admin/rel-types/roles/edit.tcl
11:48 am

antoniop

Whitespace and comment cleanup

Options
    • -5
    • +2
    ./admin/rel-types/roles/edit.tcl
11:47 am

antoniop

Cleanup redundant parameter fetching

Options
    • -3
    • +1
    ./admin/attributes/edit-one.tcl