• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix the idiom used to cut the query parameters from the URL

Handle null dates

Modernize idioms

Cleanup acs_CopyText and inline the only usage found in the codebase with a modern replacement

The function was using deprecated idioms, see https://developer.mozilla.org/en-US/docs/Web/API/document/execCommand, and "PrivilegeManager" and the "netscape" property, both long discontinued.

On modern browsers, under the correct conditions, the function can be reimplemented via a oneliner (see https://developer.mozilla.org/en-US/docs/Web/API/Clipboard)

provide link to nsstats on startup page on fresh installations (when available)

fix for containarized applications: don't use configured location unless host-name-map is in place

containeraized applications with the hostnode map will still have a problem, but these are

less frequent. For these, a solution is still pending.

Shorten idiom

Modernize idioms via optional chaining

Prefer string interpolation via template literals

Cleanup trivial acs_initHtmlArea and inline its only usages in the codebase

Cleanup trivial api, nowadays replaceable with a simple oneliner and inline the only usage found upstream

  1. … 1 more file in changeset.
Use modern javascript and browser features to simplify the code

Use an idiom that does not assume the form field to be a direct child of the form, which may not be true depending on the theme

Inline usages of acs_rte* js utilities in unmaintained packages and remove it from core.js

acs_rte* is most likely broken anyway, as nobody seems to define updateRTEs function...

Factor richtext-or-file javascript outside of the core.js

This may or not be a step on the road to deprecating this widget, which still sports inline event handlers and is used only by unmaintained packages.

  1. … 2 more files in changeset.
Make page more robust to situations, more frequest in a test setup, where a short-lived user has issued requests on the system and was recorded as online

harden page contracts

  1. … 16 more files in changeset.
template::list bulk-actions feature:

allow to have URL parameters specified in the bulk-action URL, so that the same URL can be used to serve multiple bulk actions differentiated via different flags. The URL parameters override completely every attribute with the same name specified on the form.

regenerated documetation

    • -4
    • +2
    ./doc/group-admin-pages-acceptance-test.adp
    • -3
    • +3
    ./doc/group-admin-pages-requirements.adp
  1. … 40 more files in changeset.
Don't assume xotcl api in core packages

Replace deprecated api

  1. … 1 more file in changeset.
whitespace changes

Remove no_alarms_until column

Rationale: the column or the related api is never used in upstream code to check whether notifications should be sent or not or not. The UI to manage the column's value was not linked anywhere. On the instances accessible by me downstream, no tuple was found where this column had a value.

  1. … 13 more files in changeset.
Avoid fetching the request forum manually

Whitespace and comment cleanup

Cleanup redundant parameter fetching

Fix typo

improve input validation

harden page contract

perm-include checks already that privs are not empty

Accept package parameter definitions that do not have a "main" section