• last updated 4 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Only allow valid privileges in the privs parameter

restrict substitution in string

Harden page contract

improved spelling

  1. … 4 more files in changeset.
harden page contracts

  1. … 23 more files in changeset.
Don't assume xotcl api in core packages

improve input validation

harden page contract

perm-include checks already that privs are not empty

Reform of permissions UI in acs-subsite:

- use simplified tabular view "perm-include" per default, but

allow user to switch to old list-based view

- show number of inherited permissions by default instead of full list

(list can be long). Admin can switch to full list.

- improved configurability of permissions/one.tcl

* ability to pass privileges to be displayed

* provided flag to show inherited_permissions

* provided flag to show detailed permissions (list view)

- improved configurability of permissions/perm-include.tcl

* provided flag "detailed_permissions_p" to provide access

to the old style interface, where all types of privileges

can be provided to all types of parties

- improved functionality of www/permissions/perm-user-add-include

* added search field for filtering users

- modernized idioms

- improved spelling

- extended internationalization

- bumped version of acs-subsite to 5.10.1d9

    • -1
    • +2
  1. … 8 more files in changeset.
added a saftey-belt to handle empty labels

Deprecate template::util::tcl_to_sql_list, completely replaced by ns_dbquotelist, a native NaviServer command

  1. … 17 more files in changeset.
make end of options explicit

  1. … 17 more files in changeset.
Use template::util::tcl_to_sql_list for proper list element quoting

Go back to using acs_object_name, as not every party will have a name returned from party::name (e.g. rel_segments)

party name api situation is probably less than optimal

whitespace changes

  1. … 51 more files in changeset.
Abort before redirect in case of error

Reduce divergency between oracle and postgres codebase using existing api

Remove obsolete xql files (page is using api already)

Fix test for pseudo-boolean value that stopped to work because of


improve rowcount expressions

  1. … 75 more files in changeset.
Remove divergency between oracle and postgres codebase

  1. … 3 more files in changeset.
Reduce divergency between oracle and postgres codebase

Avoid unnecesary existence checks

Fix typos

  1. … 10 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 473 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 223 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
Rework variable assigning loops (set -> lassign)

  1. … 1 more file in changeset.
remove conditions, which are always true

  1. … 1 more file in changeset.
Fix even more typos

  1. … 29 more files in changeset.