• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Delete leftover page from the old good days:

- it is supposed to test the localization data model, but columns are wrong, so it probably refers to an older version

- similar tests already take place in the appropriate acs-automated-tests framework, so makes little point to fix it or port it

- makes use of deprecated api (e.g. ad_footer)

improve page contracts

improve page_contracts

  1. … 6 more files in changeset.
Use ad_page_contract

  1. … 1 more file in changeset.
Use ad_include_contract

  1. … 1 more file in changeset.
Add remark: this file seems to be a leftover from the old good days

Use ad_include_contract

Whitespace cleanup

Rename string_truncate and string_truncate_middle to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences

As string_truncate_middle was defined in xotcl-request-monitor, bring it to acs-tcl instead

  1. … 11 more files in changeset.
Provide convenience link to default locale (resolves issue #3430)

fix for issue # 3429

move test cases for lc_monetary_currency to acs-outdated, where the definition lives

  1. … 2 more files in changeset.
Trailing whitespace cleanup

Prefer '==' over 'eq' on numeric comparison

  1. … 3 more files in changeset.
Fix regression on enabling/disabling locales

replace deprecated function ad_var_type_check_number_p which was used improperly

Simplify multirow logic using 'template::util::list_to_multirow'

Add the option to unregister (delete permanently the message key from all locales) a message key that has been already marked as deleted. Useful for cleaning up old message keys

file message-unregister.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./message-unregister.adp
file message-unregister.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./message-unregister.tcl
Fix query and logic for retrieving a particular locale stats for acs-lang admin/index page. In particular, messages that do not exist in a certain locale are properly computed in order to calculate deleted and untranslated ones, at the price of executing one query per locale instead of just a big one.

Default deleted_p should be false for non-existing translations

Allow to undelete a message from acs-lang 'edit-localized-message', instead of showing the option to delete it whatever the state is

Refactor acs-lang 'admin/index' page, adding the new columns 'total' and 'deleted' to the listing, and reworking the query so it is faster (53ms -> 7ms), correct (number of messages by state are computed coherently with other acs-lang pages) and gives more information

file index.xql was initially added on branch oacs-5-10.

Refactor acs-lang 'message-list', using a single query for counting the different message states instead of one per state, and simplifying tcl logic

Rework acs-lang 'package-list' query 'packages_locale_status' query (89ms -> 4ms)

Rework acs-lang 'package-list' query 'packages_locale_status_default' query (48ms -> 2ms)

Add deleted column to acs-lang 'package-list', and fixed number of messages depending on status, making it coherent with 'message-list'. Also fixed translated/untranslated count on default locale in 'message-list'. Version bump.

  1. … 3 more files in changeset.
file package-list.xql was initially added on branch oacs-5-10.