• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added categories to the automated test(s).

  1. … 10 more files in changeset.
when doing message lookups in lang::util::localize we need to fetch value of any embedded vars two levels up

merge Lee Denisons fix for bug 1489 to oacs-5-0

Fixed is ad_conn isconnected check - previous check always returned true.

making import procs report errors encountered. Making message::register proc throw error if en_US message doesn't already exist. Adding message::revert proc.

changing the lang_messages_audit table to have a new audit_id integer primary key column. Having the overwrite_date in a composite primary key seemed problematic. Bumping version number of acs-lang to 5.0.1

  1. … 5 more files in changeset.
removing comment about package_id in lang::user::locale proc being preliminary

removing comment about package_id in lang::user::locale proc being preliminary

merge of changes between oacs-5-0-0b4 and oacs-5-0-0-final to HEAD

  1. … 285 more files in changeset.
Added proc to get options-list of enabled locales

changing to always create catalog backup file on export even if one already exists (not sure if this is necessarily the right thing to do, but at least it's what I seem to need most often)

number of processed messages wasn't being counted properly by import_messages proc

changing name of db_dml statement to be more appropriate

merge of changes on oacs-5-0 branch to oacs-5-0-0b4 tag

    • -0
    • +45
    ./lang-catalog-procs-postgresql.xql
    • -13
    • +29
    ./lang-message-procs-postgresql.xql
  1. … 586 more files in changeset.
Adding support for I18N message catalog upgrades. Any import of

messages from catalog files that is done after the initial import is

considered an upgrade. The message import and upgrade logic is

encapsulated in the proc lang::catalog::import_messages (invoked

through lang::catalog::import).

acs-lang package

- Bumping version of package to 5.0.0b5

- Changes to datamodel:

- Adding columns deleted_p, conflict_p, and sync_time to lang_messages table.

- Removed column upgrade_status from lang_message_keys table

- Adding columns deleted_p, sync_time, conflict_p, upgrade_status to lang_messages_audit table

- Changes to lang::catalog Tcl API:

- Added proc lang::catalog::import_messages that encapsulates the logic for import and upgrade of

messages from catalog files to database.

- Changed the lang::catalog::import_from_file and lang::catalog:import procs to use the new import_messages proc.

- Added the upgrade Tcl API test cases that extensively tests through the import_messages proc with both

en_US and de_DE locales.

- Changes to lang::message Tcl API:

- Changed lang::message::register to take new switches upgrade_sync, upgrade_status, and conlfict. Cleaned up the

proc a little and made it construct SQL dynamically.

- Added procs delete, get, and get_element.

- Added the edit proc that is used when editing attributes of a message other than the message text itself. This

proc will not create a new message revision. It is invoked for example by the delete proc.

- Added the count_conflicts proc.

- Changes to admin UI

- New canonical pages for import/export of catalog files that check for site-wide-admin priv

- Made the message delete page use appropriate Tcl API

- Added the message-conflicts page that shows conflicting messages. Linking to this page from

index page, locale-, and package index pages.

acs-admin package

- Removed the import/export messages pages and using the ones in acs-lang package instead.

    • -0
    • +45
    ./lang-catalog-procs-postgresql.xql
    • -13
    • +29
    ./lang-message-procs-postgresql.xql
  1. … 33 more files in changeset.
fixing bug 1019 by making sure message keys are deleted and removed from the cache on package deletion. Moving all package deletion logic into proc. Adding an instruction on the package delete page that the server should be restarted after deletion

  1. … 2 more files in changeset.
bugfix #824: needed to add -user_id switch to some lang::user procs to specify the user for which to get the locale; also had to change the default upvar level of lang::message::lookup from 2 to 1

  1. … 1 more file in changeset.
bugfix #806: flush cache if guest user changes locale

add localized_message to error since otherwise it is quite hard to track down which message has a problem

changed to not perform the check for embedded variables validity for acs-lang.localization-* keys

Lars helped fix the check that variable in non-en_US messages are also in the corresponding en_US message. Replacing old get_missing_embedded_vars proc with the new get_embedded_vars proc and adding a bunch of test cases

fixing unescaped linebreak in warning log statement

make some Notices either warnings or debug and made them more descriptive by generally including the proc name as well bug #1032

  1. … 71 more files in changeset.
changing proc import_from_file so that failing to register one message does not cause the whole file import to fail

Adding check to lang::message::register that non en_US messages don't have invalid embedded variables (that are not present in en_US message)

adding a validity check in proc lang::system::site_wide_locale. If the locale is invalid we log an informative error message and return en_US. The much preferable solution that we should look at is of course a mechanism for validity checks in the UI for changing parameter values.

Better error message when substitution variable doesn't exist

moving code to toggle enable_p for locale into a Tcl proc

  1. … 1 more file in changeset.
changing the acs-lang-init for the Nth time. Only caching is needed now. If we did need to load message keys into the db here it should be in a scheduled proc as we need the keys *before* the server is up

re-adding the loading of message catalog files on server startup. Since loading is only done at package install if acs-lang is already installed and this is not necessarily always the case