OpenACS / openacs-4 / packages / acs-lang

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 25
Last Commit: 05 Jul
Commits this week: 0
Total Lines of Code (LoC): 6,657
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Dec 2003
2:41 pm

peterm

Adding support for I18N message catalog upgrades. Any import of

messages from catalog files that is done after the initial import is

considered an upgrade. The message import and upgrade logic is

encapsulated in the proc lang::catalog::import_messages (invoked

through lang::catalog::import).

acs-lang package

- Bumping version of package to 5.0.0b5

- Changes to datamodel:

- Adding columns deleted_p, conflict_p, and sync_time to lang_messages table.

- Removed column upgrade_status from lang_message_keys table

- Adding columns deleted_p, sync_time, conflict_p, upgrade_status to lang_messages_audit table

- Changes to lang::catalog Tcl API:

- Added proc lang::catalog::import_messages that encapsulates the logic for import and upgrade of

messages from catalog files to database.

- Changed the lang::catalog::import_from_file and lang::catalog:import procs to use the new import_messages proc.

- Added the upgrade Tcl API test cases that extensively tests through the import_messages proc with both

en_US and de_DE locales.

- Changes to lang::message Tcl API:

- Changed lang::message::register to take new switches upgrade_sync, upgrade_status, and conlfict. Cleaned up the

proc a little and made it construct SQL dynamically.

- Added procs delete, get, and get_element.

- Added the edit proc that is used when editing attributes of a message other than the message text itself. This

proc will not create a new message revision. It is invoked for example by the delete proc.

- Added the count_conflicts proc.

- Changes to admin UI

- New canonical pages for import/export of catalog files that check for site-wide-admin priv

- Made the message delete page use appropriate Tcl API

- Added the message-conflicts page that shows conflicting messages. Linking to this page from

index page, locale-, and package index pages.

acs-admin package

- Removed the import/export messages pages and using the ones in acs-lang package instead.

Options
    • -2
    • +4
    ./lang-audit-procs-oracle.xql
    • -2
    • +4
    ./lang-audit-procs-postgresql.xql
    • -2
    • +6
    ./lang-audit-procs.tcl
    • -0
    • +43
    ./lang-catalog-procs-oracle.xql
    • -0
    • +45
    ./lang-catalog-procs-postgresql.xql
    • -130
    • +458
    ./lang-catalog-procs.tcl
    • -2
    • +2
    ./lang-catalog-procs.xql
    • -5
    • +22
    ./lang-message-procs-oracle.xql
    • -13
    • +29
    ./lang-message-procs-postgresql.xql
    • -56
    • +343
    ./lang-message-procs.tcl
    • -11
    • +10
    ./lang-message-procs.xql
    • -2
    • +470
    ./test/acs-lang-test-procs.tcl
  13. … 33 more files in changeset.
Tuesday 25 Nov 2003
1:45 pm

peterm

fixing bug 1019 by making sure message keys are deleted and removed from the cache on package deletion. Moving all package deletion logic into proc. Adding an instruction on the package delete page that the server should be restarted after deletion

Options
    • -1
    • +30
    ./lang-catalog-procs.tcl
    • -2
    • +20
    ./lang-message-procs.tcl
  3. … 2 more files in changeset.
Monday 24 Nov 2003
6:54 pm

timoh

bugfix #824: needed to add -user_id switch to some lang::user procs to specify the user for which to get the locale; also had to change the default upvar level of lang::message::lookup from 2 to 1

Options
    • -8
    • +6
    ./lang-message-procs.tcl
    • -8
    • +25
    ./locale-procs.tcl
  3. … 1 more file in changeset.
4:37 pm

timoh

bugfix #806: flush cache if guest user changes locale

Options
    • -1
    • +4
    ./locale-procs.tcl
Tuesday 11 Nov 2003
1:09 pm

jeffd

add localized_message to error since otherwise it is quite hard to track down which message has a problem

Options
    • -2
    • +2
    ./lang-message-procs.tcl
Thursday 06 Nov 2003
10:02 am

peterm

changed to not perform the check for embedded variables validity for acs-lang.localization-* keys

Options
    • -2
    • +5
    ./lang-message-procs.tcl
Tuesday 04 Nov 2003
11:32 am

peterm

Lars helped fix the check that variable in non-en_US messages are also in the corresponding en_US message. Replacing old get_missing_embedded_vars proc with the new get_embedded_vars proc and adding a bunch of test cases

Options
    • -36
    • +22
    ./lang-message-procs.tcl
    • -8
    • +32
    ./test/acs-lang-test-procs.tcl
Monday 03 Nov 2003
11:50 am

peterm

fixing unescaped linebreak in warning log statement

Options
    • -4
    • +2
    ./lang-util-procs.tcl
Saturday 01 Nov 2003
9:45 am

jeffd

make some Notices either warnings or debug and made them more descriptive by generally including the proc name as well bug #1032

Options
    • -16
    • +16
    ./lang-catalog-procs.tcl
    • -3
    • +1
    ./lang-message-procs.tcl
    • -7
    • +7
    ./lang-util-procs.tcl
    • -8
    • +8
    ./localization-procs.tcl
  5. … 71 more files in changeset.
Wednesday 29 Oct 2003
2:40 pm

peterm

changing proc import_from_file so that failing to register one message does not cause the whole file import to fail

Options
    • -25
    • +31
    ./lang-catalog-procs.tcl
Tuesday 28 Oct 2003
1:25 pm

peterm

Adding check to lang::message::register that non en_US messages don't have invalid embedded variables (that are not present in en_US message)

Options
    • -1
    • +13
    ./lang-message-procs.tcl
11:32 am

peterm

adding a validity check in proc lang::system::site_wide_locale. If the locale is invalid we log an informative error message and return en_US. The much preferable solution that we should look at is of course a mechanism for validity checks in the UI for changing parameter values.

Options
    • -2
    • +11
    ./locale-procs.tcl
Wednesday 22 Oct 2003
6:52 pm

lars

Better error message when substitution variable doesn't exist

Options
    • -2
    • +6
    ./lang-message-procs.tcl
Tuesday 21 Oct 2003
3:55 pm

peterm

moving code to toggle enable_p for locale into a Tcl proc

Options
    • -1
    • +18
    ./locale-procs.tcl
  2. … 1 more file in changeset.
Friday 17 Oct 2003
10:30 am

peterm

changing the acs-lang-init for the Nth time. Only caching is needed now. If we did need to load message keys into the db here it should be in a scheduled proc as we need the keys *before* the server is up

Options
    • -3
    • +3
    ./acs-lang-init.tcl
Thursday 16 Oct 2003
6:25 pm

peterm

re-adding the loading of message catalog files on server startup. Since loading is only done at package install if acs-lang is already installed and this is not necessarily always the case

Options
    • -3
    • +3
    ./acs-lang-init.tcl
    • -1
    • +12
    ./lang-catalog-procs.tcl
    • -0
    • +15
    ./lang-catalog-procs.xql
5:17 pm

peterm

fixing bug introduced on last API cleanup commit

Options
    • -5
    • +5
    ./lang-catalog-procs.tcl
12:50 pm

peterm

cleanup and renaming of import/export procs in lang::catalog namespace. Now there are really only two public procs to know about: lang::catalog::import and lang::catalog::export. Updating all invocations of the procs and test cases. Adding proc lang::message::unregister for deleting message keys - used in test case teardown.

Options
    • -11
    • +1
    ./acs-lang-init.tcl
    • -416
    • +290
    ./lang-catalog-procs.tcl
    • -19
    • +4
    ./lang-catalog-procs.xql
    • -7
    • +29
    ./lang-message-procs.tcl
    • -2
    • +2
    ./lang-util-procs.tcl
    • -82
    • +85
    ./test/acs-lang-test-procs.tcl
  7. … 5 more files in changeset.
Wednesday 15 Oct 2003
4:30 pm

peterm

Because of problem exporting digits in arabic locale (AR_LB with ISO-8859-6) we have now changed to export all catalog files in utf-8 except when ISO-8859-1 can be used. Easiest would be to export all catalog files in utf-8, however, out of fear of hand editing of catalog files messing with the utf-8 encoding we don't. Adding encoding attribute to xml tag of message catalog files. Removing redundant file name prefixing of log statements.

Options
    • -29
    • +33
    ./lang-catalog-procs.tcl
    • -3
    • +2
    ./lang-util-procs.tcl
2:37 pm

peterm

making the util_replace_temporary_tags_with_lookups test case pass again. Wrapping case in rollback. Some cleanup in the tested proc

Options
    • -15
    • +13
    ./lang-util-procs.tcl
    • -70
    • +83
    ./test/acs-lang-test-procs.tcl
1:21 pm

jeffd

memoize the user timezone

Options
    • -2
    • +8
    ./locale-procs.tcl
    • -1
    • +1
    ./locale-procs.xql
10:23 am

peterm

making sure the proper proc is used to re-generate catalog files after automatic message key and lookup generation. Previously the description tags didn't get written to the message files

Options
    • -4
    • +6
    ./lang-util-procs.tcl
Tuesday 14 Oct 2003
9:39 am

lars

Fixed bug #941: lang::conn::timezone fails when not connected

Options
    • -2
    • +6
    ./locale-procs.tcl
    • -1
    • +6
    ./test/acs-lang-test-procs.tcl
Sunday 12 Oct 2003
8:57 am

peterm

adding syntax check of acs-lang.localization-grouping value and falling back on en_US locale in case of invalid syntax (to avoid broken pages)

Options
    • -1
    • +7
    ./localization-procs.tcl
Friday 10 Oct 2003
7:06 pm

peterm

fixing bug 915 by making sure any adp vars (including the noquote ones) are excluded when searching for translatable text. We still allow for embedded adp vars, only, we currently don't allow them to have the noquote instruction, we could add support for that later.

Options
    • -2
    • +14
    ./lang-util-procs.tcl
3:59 pm

frankn

Make lang::user::site_wide_locale_not_cached{} return the system wide

locale for non-registered users, who does not have an ad_locale cookie.

Ensure that the ad_locale cookie never expires. Oops. ;)

Options
    • -3
    • +7
    ./locale-procs.tcl
3:02 pm

frankn

Part of the fix for bug #806: Store non-registered visitors locale

setting in a cookie (and not in a client property).

Options
    • -5
    • +4
    ./locale-procs.tcl
Wednesday 08 Oct 2003
5:39 pm

peterm

removing print statement that seemed superfluous

Options
    • -2
    • +1
    ./lang-catalog-procs.tcl
Wednesday 01 Oct 2003
4:51 pm

lars

Changed message key encoding to not confuse eval or subst

Options
    • -3
    • +3
    ./lang-message-procs.tcl
  2. … 1 more file in changeset.
Tuesday 30 Sep 2003
5:32 pm

peterm

bugfix in xml catalog import proc, variable named charset should have been named mime_charset

Options
    • -3
    • +3
    ./lang-catalog-procs.tcl