• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Pass missing object_id flag

Do not insert object_ids that do not exist in acs_object (leftover group message keys)

Improve sql portability

    • -22
    • +22
    ./tcl/test/acs-lang-localization-procs.tcl
  1. … 6 more files in changeset.
Improve test

    • -8
    • +13
    ./tcl/test/acs-lang-localization-procs.tcl
New test for lang::util::convert_to_i18n pinpointing some expected behaviors of this proc

    • -0
    • +67
    ./tcl/test/acs-lang-localization-procs.tcl
Fix typo

acs-lang reform:

when calling lang::util::convert_to_i18n, do not always register a en_US translation, which will be otherwise always overridden. Instead, let lang::message::register make sure that a en_US message exists and create it only when needed as a fallback. Before, lang::message::register would return an error when e.g. a new message keys was registered for de_DE and no en_US was there. Now the en_US will be just created on the fly.

This does not break current automated tests

Take also care to populate the newly created column with the group ids coming from automatically generated message keys

file upgrade-5.10.0d13-5.10.0d14.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d13-5.10.0d14.sql
Create index on the new lang_message_keys.object_id column

file upgrade-5.10.0d12-5.10.0d13.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
file upgrade-5.10.0d11-5.10.0d12.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
acs-lang reform

Provide an optional object_id which can be used to register message keys that will be bound to the lifecycle of an acs-object. When the object is deleted, so will the message key.

This is useful for groups that automatically define a message key for their pretty name. Tcl api was already aware of this and would cleanup such message keys, but other idioms e.g. stored procedures used to delete groups would leave leftovers behind. These can become relatively numerous on group-intensive systems such as LEARN.

Other future usages for this new feature might be the automatic localization of xowiki FormPage properties.

  1. … 2 more files in changeset.
improve spelling

  1. … 2 more files in changeset.
Cleanup broken tests from the old good days, timezone features in acs-lang are already tested in lang_test__lc_procs

Keep using ad_conn in lang::conn::timezone as set_get_timezone needs to simulate lack of connection and ad_conn allows to override the "real" value

Refactor 'locale_language_fallback' testcase, using 'aa_run_with_teardown' and preventing errors when the 'en_GB' locale is not enabled

    • -20
    • +44
    ./tcl/test/acs-lang-test-procs.tcl
prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 15 more files in changeset.
mprove spelling: move closer to the linux documentation recommendations

    • -1
    • +1
    ./www/admin/export-locale-to-files.tcl
    • -1
    • +1
    ./www/admin/import-locale-from-files.tcl
  1. … 13 more files in changeset.
improve error message

provide a more friendly error message for broken configurations

avoid repeated lookup for the same locale

remove quotes from quoted vars

- simplifying one more expression

- bump version number to 5.10.0d11

reduced the number of mutex locks for message keys lookup by a factor of two by using naviserver commands

use dot instead of colon as separator between package name and cache key to ease readability

  1. … 8 more files in changeset.
acs::per_thread_cache: standardize per-thread caching

- added per-thread cache based on namespaced Tcl variables.

- use per-thread-cache on several occasions

- bump version number of acs-tcl to 5.10.0d34

  1. … 11 more files in changeset.
improve SQL quoting

  1. … 4 more files in changeset.
Update es_ES message keys

    • -0
    • +1
    ./catalog/acs-lang.es_ES.ISO-8859-1.xml
  1. … 1 more file in changeset.
Fix alt text of image