acs-bootstrap-installer

  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
passing "-debug" flag explicitly to nsf::proc

improve comments

    • -4
    • +9
    ./tcl/40-db-query-dispatcher-procs.tcl
improve spelling

reduce the number of locks (nsv-accesses) for OACS_FULLQUERIES by a factor of 3 when NaviServer is used.

OACS_FULLQUERIES is one of the 3 most intensively locked nsv arrays for

busy implementation

    • -20
    • +52
    ./tcl/40-db-query-dispatcher-procs.tcl
improve test coverage

reduce visibility of internal functions

    • -4
    • +4
    ./tcl/40-db-query-dispatcher-procs.tcl
move function db_current_rdbms to acs-bootstrap installer to improve code locality

    • -2
    • +6
    ./tcl/40-db-query-dispatcher-procs.tcl
  1. … 1 more file in changeset.
Cleanup of low-level DB-interace: use dict instead of list with fixed positions

VS: ----------------------------------------------------------------------

    • -28
    • +48
    ./tcl/40-db-query-dispatcher-procs.tcl
  1. … 2 more files in changeset.
Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

  1. … 6 more files in changeset.
added a comment about the usefulness of ad_arg_parser

Fix for issue #3442 to support range types in .xql files

PostgreSQL supports range types since 9.5. When using range types,

square braces have to be used in SQL statements. Since OpenACS uses

always Tcl substitution in .xql files, and OpenACS does NOT allow

backslash substitution in these files, square brackets could not be

escaped and therefore not be used in .xql files so far. This change

allows now a developer to deactivate the substitution by passing

e.g. "-subst none" to the db_* command using the .xql file. Valid

values for "-subst" are "all", "none", "vars", and "commands", default

is "all" which is exactly the behavior of before. Therefore, this

change is fully backward compatible.

    • -3
    • +19
    ./tcl/40-db-query-dispatcher-procs.tcl
  1. … 2 more files in changeset.
reduce the size of the public interface

    • -10
    • +10
    ./tcl/40-db-query-dispatcher-procs.tcl
whitespace changes: break overlong lines

    • -150
    • +176
    ./tcl/40-db-query-dispatcher-procs.tcl
make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages

    • -7
    • +6
    ./tcl/40-db-query-dispatcher-procs.tcl
  1. … 2 more files in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 4 more files in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 3 more files in changeset.
Make proc public (it is used in a test is acs-tcl)

Complies with acs-api-browser.callgraph__bad_calls

    • -2
    • +2
    ./tcl/40-db-query-dispatcher-procs.tcl
Whitespace cleanup

    • -69
    • +69
    ./tcl/40-db-query-dispatcher-procs.tcl
include package key in proc info

mark functions called only internally as private

  1. … 15 more files in changeset.
just avoid tilde substitution, do not perform sanitizing

sanitizing can lead to file name clashes in case the names

without tilde exists, and they are OS specific. The intention

of "ad_file" is just to be a tilde-proof "file" replacement

Sanitize all trailing tildes from the filename, mapping them to the current folder

Fixes acs-bootstrap-installer.ad_file automated test

Make 'ad_file' test case deterministic

Automated test for ad_file exposing a blind spot with files starting with the '~' character

file 00-proc-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/00-proc-procs.tcl
improve spelling

    • -10
    • +12
    ./tcl/40-db-query-dispatcher-procs.tcl
  1. … 2 more files in changeset.
allow value checkers in ad_procs

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

    • -4
    • +4
    ./tcl/40-db-query-dispatcher-procs.tcl
  1. … 53 more files in changeset.
remove calls to deprecated proc acs_lookup_magic_object (use acs_magic_object instead)

  1. … 3 more files in changeset.
Treat callback hooks and implementations as private api