acs-authentication-procs.tcl

  • last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- simplify code

  1. … 3 more files in changeset.
- brace expressions to allow for tcl compilation

- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

  1. … 10 more files in changeset.
- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

  1. … 2 more files in changeset.
- make exists_and_not_null explicit

  1. … 6 more files in changeset.
stub acs_mail_lite::send since ns_sendmail is not always the ultimate transport. (the second one)

stub acs_mail_lite::send since ns_sendmail is not always the ultimate transport.

make test case a bit more informative about failure mode

Running these test twice would lead to errors, due to test users not being

deleted. The tear-down stuff knows how to rollback the database, but caching

is a bit beyond its automated capability at the moment.

Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
Someone changed the local auth implementation to handle the "RetrievePassword"

operation (by e-mailing a note to the user which links to a reset password

page). This is cool. What's not cool is to change the behavior without

running tests on the package and correcting the one that looked for the

local auth implementation to return "not_supported" ...

Added categories to the automated test(s).

  1. … 3 more files in changeset.
Fixed password email change test case - turned out to be interaction between two test cases and the cache

Fixed parameters test case to expose problem with unique constraint/primary key on auth_driver_params on Oracle, and to do a better job of testing the parameters framework

Fixed header of file (said workflow)

auth_password_change proc: stubbing ns_sendmail and checking that email is sent to user on password change.

Tweaking test cases

changing test case to use auth::create_user instead of ad_user_new

Fixed problem with chaning password for a user causing the connection's authentication to change

  1. … 1 more file in changeset.
Show message when test fails

Fixed test cases

  1. … 1 more file in changeset.
- Code reviewed authority UI

- UseEmailForLoginP

- Refactored snapshot_p out of auth_authorities table and into auth_sync_retrieve service contract

- Email account owner on password change

  1. … 12 more files in changeset.
Made local accounts accept and store screen_name

  1. … 5 more files in changeset.
making proc authority::create set default values for not required columns. Also making proc use an update statement for 4 columns not taken by the plsql new function

  1. … 3 more files in changeset.
updating the authority API with the new columns

  1. … 3 more files in changeset.
Removed @author tags, as they didn't get parsed

Batch Sync API mostly complete

  1. … 13 more files in changeset.
*** empty log message ***

Code reviewed the authority API

  1. … 1 more file in changeset.
Code reviewed password management procs

  1. … 4 more files in changeset.