• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use the test machinery to simulate a cookie authentication

Inline sec_login_read_cookie, as it is a private api and would upset the bad calls test

Test auth::verify_account_status and complete coverage of acs-authentication

Test auth::update_local_account

Add auth::sync::job::get_authority_id to an existing test

Test auth::self_registration

Test auth::refresh_login

Cleanup code pasted twice by mistake

Bring more stuff into an existing test

Test for auth::get_user_id and the whole login attempts api

Test auth::get_user_id

Test auth::get_register_authority proc

Fix test name

Test auth::get_all_registration_elements

Test more public api

Test auth::can_admin_system_without_authority_p public api

file authentication-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./authentication-procs.tcl
Test auth::authority::get_sc_impl_columns public api

file authority-procs.tcl was initially added on branch oacs-5-10.

Reduce divergency between oracle and postgres codebase

    • -19
    • +0
    ./acs-authentication-procs-oracle.xql
    • -19
    • +0
    ./acs-authentication-procs-postgresql.xql
  1. … 6 more files in changeset.
Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

  1. … 2 more files in changeset.
fixed bug: exception in test case auth_use_email_for_login_p caused test to terminate

By adding an "ad_try", we can see that the intention to create

a user with no username failed. Probably this was working at some time,

not sure, if it still should.

This is could be a general problem with "aa_run_with_teardown" to

terminate too early in such cases.

improve listing of test coverage

  1. … 16 more files in changeset.
make listing of tested procs more complete

  1. … 17 more files in changeset.
Care about the parameter cache after test case

Set a bunch of test cases to 'production_safe'

Merge 'auth_authority_api' and 'auth_authority_delete' test cases, covering almost the same api

    • -195
    • +122
    ./acs-authentication-procs.tcl
Fix typo

Reduce divergencies between oracle and postgres codebase

    • -10
    • +0
    ./acs-authentication-procs-postgresql.xql
mprove spelling: move closer to the linux documentation recommendations

  1. … 20 more files in changeset.