• last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove backward compatibility check in busy code for versions before 5.1.3 (2004)

The checks for backwards compatibility have on busy sites the highest

hit rates of all entries in the util-memoize cache. Since we require the latest

OpenACS 5.9.* for upgrade to 5.10, this can be removed (17 years later).

https://openacs.org/bugtracker/openacs/bug?format=table&f%5fstate=8&bug%5fnumber=2200

Use the test machinery to simulate a cookie authentication

    • -29
    • +10
    ./tcl/test/authentication-procs.tcl
Inline sec_login_read_cookie, as it is a private api and would upset the bad calls test

    • -1
    • +10
    ./tcl/test/authentication-procs.tcl
Test auth::verify_account_status and complete coverage of acs-authentication

    • -0
    • +57
    ./tcl/test/authentication-procs.tcl
Test auth::update_local_account

    • -0
    • +98
    ./tcl/test/authentication-procs.tcl
Add auth::sync::job::get_authority_id to an existing test

Test auth::self_registration

    • -0
    • +69
    ./tcl/test/authentication-procs.tcl
Test auth::refresh_login

    • -0
    • +36
    ./tcl/test/authentication-procs.tcl
Cleanup code pasted twice by mistake

    • -53
    • +0
    ./tcl/test/authentication-procs.tcl
Bring more stuff into an existing test

    • -4
    • +13
    ./tcl/test/acs-authentication-procs.tcl
Test for auth::get_user_id and the whole login attempts api

    • -0
    • +167
    ./tcl/test/authentication-procs.tcl
Document actual behavior

    • -2
    • +3
    ./tcl/authentication-procs-aolserver.tcl
    • -2
    • +3
    ./tcl/authentication-procs-naviserver.tcl
Test auth::get_user_id

    • -0
    • +53
    ./tcl/test/authentication-procs.tcl
Test auth::get_register_authority proc

    • -0
    • +49
    ./tcl/test/authentication-procs.tcl
Fix test name

Test auth::get_all_registration_elements

    • -0
    • +21
    ./tcl/test/authentication-procs.tcl
Test more public api

    • -0
    • +47
    ./tcl/test/authentication-procs.tcl
Test auth::can_admin_system_without_authority_p public api

    • -0
    • +103
    ./tcl/test/authentication-procs.tcl
file authentication-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/authentication-procs.tcl
Test auth::authority::get_sc_impl_columns public api

file authority-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/authority-procs.tcl
Reduce divergency between oracle and postgres codebase

    • -19
    • +0
    ./tcl/test/acs-authentication-procs-oracle.xql
    • -19
    • +0
    ./tcl/test/acs-authentication-procs-postgresql.xql
    • -2
    • +11
    ./tcl/test/acs-authentication-procs.tcl
  1. … 6 more files in changeset.
fix release dates in .info files

  1. … 82 more files in changeset.
release work

  1. … 204 more files in changeset.
regenerated documentation

  1. … 467 more files in changeset.
bump version numbers of 5.9|5.10 packages to 5.10.0b1

adjust dependencies

  1. … 87 more files in changeset.
improve spelling

    • -2
    • +2
    ./tcl/authentication-procs-naviserver.tcl
  1. … 42 more files in changeset.
Bring the implementation of the "Search" operation of the "auth_search" service contract in line with the operation's definition by correcting the returned value ("username" instead of "user_id") and restricting the search to the local authority.

Streamline idiom: we are only interested in the user ids

Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc