• last updated 2 hours ago
Constraints: committers
Constraints: files
Constraints: dates
improve spelling

  1. … 2 more files in changeset.
Handle acs-mail-lite conf regarding the recipient in the test

Make sure test email is fine even when usernames are emails

Use lowercase letter to append to the fake username, so that if it should be an email, it will still be valid

Fix typo in test

Complete coverage for the ACS Service Contract 'auth_user_info'

Complete coverage of ACS Service Contract 'auth_sync_retrieve' implementations

Test IMS_Enterprise_v_1p1 implementation of the auth_sync_process Service Contract

Rework parameter check:

the way the if was construed would allow e.g.:

1. a value for EmailRegistrationConfirmationToUserP = 'nottrue' to pass the first if, but fail the second.

2. a value EmailRegistrationConfirmationToUserP = 'false' to be "true" in the first if, but not in the second

In fact, if EmailRegistrationConfirmationToUserP should be a boolean, there is no need to further check the other parameters and variables in the second if. This change is not 100% equivalent to the previous code, but makes it clear that EmailRegistrationConfirmationToUserP should be interpreted as a boolean and fixes these inconsistencies.

Make clear that parameters come from the same subsite

Test implementations of ACS Service Contract 'auth_registration'

This exposes a bug in auth::local::registration::Register where the acs-subsite parameter NotifyAdminOfNewRegistrationsP is fetched from the ad_conn package_id, rather than the subsite_id

Fix signature of service contract implementation, that is defined with 3 and not 4 arguments, complete coverage of the auth_password contract local implementation

Complete coverage of the auth_authentication contract 'local' implementation

file local-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 31 more files in changeset.
Specify the empty value correctly in the authentication form fields

fixes for Oracle 19c

  1. … 4 more files in changeset.
fix indentation

Remove backward compatibility check in busy code for versions before 5.1.3 (2004)

The checks for backwards compatibility have on busy sites the highest

hit rates of all entries in the util-memoize cache. Since we require the latest

OpenACS 5.9.* for upgrade to 5.10, this can be removed (17 years later).


Use the test machinery to simulate a cookie authentication

    • -29
    • +10
Inline sec_login_read_cookie, as it is a private api and would upset the bad calls test

    • -1
    • +10
Test auth::verify_account_status and complete coverage of acs-authentication

    • -0
    • +57
Test auth::update_local_account

    • -0
    • +98
Add auth::sync::job::get_authority_id to an existing test

Test auth::self_registration

    • -0
    • +69
Test auth::refresh_login

    • -0
    • +36
Cleanup code pasted twice by mistake

    • -53
    • +0
Bring more stuff into an existing test

    • -4
    • +13
Test for auth::get_user_id and the whole login attempts api

    • -0
    • +167
Document actual behavior

    • -2
    • +3
    • -2
    • +3