OpenACS / openacs-4 / packages

acs-authentication

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 37
Last Commit:
Commits this week: 0
Total Lines of Code (LoC): 11,390
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 27 Nov 2022
7:08 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./tcl/authentication-procs.tcl
    • -1
    • +1
    ./tcl/test/authentication-procs.tcl
    • -4
    • +4
    ./tcl/test/local-procs.tcl
  4. … 2 more files in changeset.
Friday 30 Sep 2022
6:51 pm

antoniop

Handle acs-mail-lite conf regarding the recipient in the test

Options
    • -2
    • +11
    ./tcl/test/local-procs.tcl
3:31 pm

antoniop

Make sure test email is fine even when usernames are emails

Options
    • -3
    • +5
    ./tcl/test/sync-test-procs.tcl
3:19 pm

antoniop

Use lowercase letter to append to the fake username, so that if it should be an email, it will still be valid

Options
    • -2
    • +2
    ./tcl/test/sync-test-procs.tcl
Tuesday 20 Sep 2022
8:40 am

antoniop

Fix typo in test

Options
    • -1
    • +1
    ./tcl/test/local-procs.tcl
Monday 19 Sep 2022
6:44 pm

antoniop

Complete coverage for the ACS Service Contract 'auth_user_info'

Options
    • -0
    • +47
    ./tcl/test/local-procs.tcl
6:29 pm

antoniop

Complete coverage of ACS Service Contract 'auth_sync_retrieve' implementations

Options
    • -2
    • +35
    ./tcl/test/sync-test-procs.tcl
6:14 pm

antoniop

Test IMS_Enterprise_v_1p1 implementation of the auth_sync_process Service Contract

Options
    • -1
    • +213
    ./tcl/test/sync-test-procs.tcl
3:24 pm

antoniop

Rework parameter check:

the way the if was construed would allow e.g.:

1. a value for EmailRegistrationConfirmationToUserP = 'nottrue' to pass the first if, but fail the second.

2. a value EmailRegistrationConfirmationToUserP = 'false' to be "true" in the first if, but not in the second

In fact, if EmailRegistrationConfirmationToUserP should be a boolean, there is no need to further check the other parameters and variables in the second if. This change is not 100% equivalent to the previous code, but makes it clear that EmailRegistrationConfirmationToUserP should be interpreted as a boolean and fixes these inconsistencies.

Options
    • -26
    • +18
    ./tcl/local-procs.tcl
2:57 pm

antoniop

Make clear that parameters come from the same subsite

Options
    • -7
    • +12
    ./tcl/local-procs.tcl
2:55 pm

antoniop

Test implementations of ACS Service Contract 'auth_registration'

This exposes a bug in auth::local::registration::Register where the acs-subsite parameter NotifyAdminOfNewRegistrationsP is fetched from the ad_conn package_id, rather than the subsite_id

Options
    • -0
    • +296
    ./tcl/test/local-procs.tcl
Friday 16 Sep 2022
5:16 pm

antoniop

Fix signature of service contract implementation, that is defined with 3 and not 4 arguments, complete coverage of the auth_password contract local implementation

Options
    • -7
    • +2
    ./tcl/local-procs.tcl
    • -0
    • +98
    ./tcl/test/local-procs.tcl
4:31 pm

antoniop

Complete coverage of the auth_authentication contract 'local' implementation

Options
    • -0
    • +48
    ./tcl/test/local-procs.tcl
4:31 pm

antoniop

file local-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/local-procs.tcl
Monday 29 Aug 2022
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -2
    • +2
    ./tcl/authority-procs.tcl
    • -2
    • +2
    ./tcl/sync-procs.tcl
    • -5
    • +5
    ./tcl/test/sync-test-procs.tcl
  4. … 31 more files in changeset.
Wednesday 20 Apr 2022
10:00 am

antoniop

Specify the empty value correctly in the authentication form fields

Options
    • -2
    • +2
    ./tcl/authentication-procs.tcl
Thursday 10 Feb 2022
10:33 pm

gustafn

fixes for Oracle 19c

Options
    • -2
    • +2
    ./tcl/authentication-procs.tcl
    • -2
    • +2
    ./tcl/test/authentication-procs.tcl
  3. … 4 more files in changeset.
Sunday 05 Dec 2021
5:16 pm

gustafn

fix indentation

Options
    • -2
    • +2
    ./tcl/authority-procs.tcl
Monday 01 Nov 2021
11:41 am

gustafn

Remove backward compatibility check in busy code for versions before 5.1.3 (2004)

The checks for backwards compatibility have on busy sites the highest

hit rates of all entries in the util-memoize cache. Since we require the latest

OpenACS 5.9.* for upgrade to 5.10, this can be removed (17 years later).

https://openacs.org/bugtracker/openacs/bug?format=table&f%5fstate=8&bug%5fnumber=2200

Options
    • -22
    • +6
    ./tcl/authentication-procs.tcl
Thursday 07 Oct 2021
2:37 pm

antoniop

Use the test machinery to simulate a cookie authentication

Options
    • -29
    • +10
    ./tcl/test/authentication-procs.tcl
1:03 pm

antoniop

Inline sec_login_read_cookie, as it is a private api and would upset the bad calls test

Options
    • -1
    • +10
    ./tcl/test/authentication-procs.tcl
Wednesday 06 Oct 2021
4:08 pm

antoniop

Test auth::verify_account_status and complete coverage of acs-authentication

Options
    • -0
    • +57
    ./tcl/test/authentication-procs.tcl
3:16 pm

antoniop

Test auth::update_local_account

Options
    • -0
    • +98
    ./tcl/test/authentication-procs.tcl
2:19 pm

antoniop

Add auth::sync::job::get_authority_id to an existing test

Options
    • -2
    • +16
    ./tcl/test/sync-test-procs.tcl
2:12 pm

antoniop

Test auth::self_registration

Options
    • -0
    • +69
    ./tcl/test/authentication-procs.tcl
1:47 pm

antoniop

Test auth::refresh_login

Options
    • -0
    • +36
    ./tcl/test/authentication-procs.tcl
11:48 am

antoniop

Cleanup code pasted twice by mistake

Options
    • -53
    • +0
    ./tcl/test/authentication-procs.tcl
Tuesday 05 Oct 2021
6:25 pm

antoniop

Bring more stuff into an existing test

Options
    • -4
    • +13
    ./tcl/test/acs-authentication-procs.tcl
6:15 pm

antoniop

Test for auth::get_user_id and the whole login attempts api

Options
    • -0
    • +167
    ./tcl/test/authentication-procs.tcl
5:43 pm

antoniop

Document actual behavior

Options
    • -2
    • +3
    ./tcl/authentication-procs-aolserver.tcl
    • -2
    • +3
    ./tcl/authentication-procs-naviserver.tcl