OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 35
Total Committers: 146
Last Commit: 28 Dec
Commits this week: 35
Total Lines of Code (LoC): 7,561,384
Net change in LoC this week: 37

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 27 Dec
10:22 am

gustafn

Continue working on the install.xml issue.

Options
    • -8
    • +9
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
10:01 am

gustafn

added more debugging info

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
9:29 am

gustafn

undo one more recent change

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
9:15 am

gustafn

undo recent change. This was not the problem

Options
    • -5
    • +1
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
9:00 am

gustafn

added debug statement

Options
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
Thursday 26 Dec
7:25 pm

gustafn

try to get a non-empty context id

Options
    • -3
    • +7
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
6:56 pm

gustafn

added debugging line

Options
    • -1
    • +8
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
6:32 pm

gustafn

Fixed incorrect result handling from ::acs::site_node get_node_id

When

::acs::site_node get_node_id -url /$mount_point

is executed with a non-existing mount point, the node info of the

parent_id is returned. The code assumed that for such cases, the

resulting "object_id" member is empty. Since this affects only the

two action procs

install::xml::action::mount

install::xml::action::mount-existing

i have adjusted the behavior there.

Furthermore, some tests are now less mind-twisted.

Options
    • -13
    • +11
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
12:10 pm

gustafn

strangely, parameter CommDefaultSiteTemplate_p was set on wrong package_id

Before this change, the install from repo on dotlrn led to error below.

this change makes sure, that the used "package_id" is the package_id from dotlrn.

: ERROR: -20000: The specified package 702 AND/OR parameter CommDefaultSiteTemplate_p do not exist in the system

: CONTEXT: PL/pgSQL function apm__id_for_name(integer,character varying) line 13 at RAISE

: PL/pgSQL function apm__set_value(integer,character varying,character varying) line 6 at assignment

oacs-5-10=# select * from apm_packages where package_key like '%dotlrn%';

package_id | package_key | instance_name | default_locale

------------+-------------------------+----------------------------+----------------

1843 | dotlrn-bm | dotLRN Bulk Mail Applet |

1850 | dotlrn-faq | dotLRN FAQ Applet |

1868 | dotlrn-forums | dotLRN Forums Applet |

1886 | dotlrn-fs | dotLRN File Storage Applet |

1933 | dotlrn-news | dotLRN News Applet |

1981 | dotlrn-portlet | dotLRN Portlet |

1998 | dotlrn-assessment | dotLRN Assessment Applet |

2040 | dotlrn-bootstrap3-theme | dotLRN Bootstrap 3 Theme |

oacs-5-10=# select * from apm_packages where package_id = 702;

package_id | package_key | instance_name | default_locale

------------+-------------+------------------------+----------------

702 | acs-subsite | #acs-kernel.Main_Site# |

Options
    • -1
    • +2
    /openacs-4/packages/dotlrn-bootstrap3-theme/tcl/theme-procs.tcl
11:15 am

gustafn

moved theme setting to theme package (dotlrn-bootstrap3-theme)

This make sure that in the loading sequence, the theme is available when one

tries to switch to it.

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
    • -0
    • +2
    /openacs-4/packages/dotlrn-bootstrap3-theme/install.xml
Wednesday 25 Dec
4:34 pm

gustafn

added "dotlrn-bootstrap3-theme" to dependencies to make it installable via "install.xml" for install-from-repository

Options
    • -2
    • +3
    /openacs-4/packages/dotlrn/dotlrn.info
12:04 pm

gustafn

fixed dependencies

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn-bootstrap3-theme/dotlrn-bootstrap3-theme.info
Tuesday 24 Dec
5:27 pm

gustafn

improved log messages

Options
    • -2
    • +3
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
5:18 pm

gustafn

bump maturity from 1 to 2

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn-bootstrap3-theme/dotlrn-bootstrap3-theme.info
Monday 23 Dec
4:56 pm

gustafn

fixed typo in filename of image

Options
    • binary
    /openacs-4/packages/acs-subsite/www/shared/images/recycle16.png
    • binary
    /openacs-4/packages/acs-subsite/www/shared/images/recylce16.png
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
Friday 20 Dec
1:14 pm

antoniop

Cleanup stale sse connections

Options
    • -1
    • +1
    /openacs-4/packages/notifications/tcl/notification-sse-procs.tcl
    • -1
    • +6
    /openacs-4/packages/notifications/tcl/sweep-init.tcl
    • -1
    • +16
    /openacs-4/packages/notifications/tcl/sweep-procs.tcl
Thursday 19 Dec
5:59 pm

antoniop

Introduce a new delivery method for notifications based on Server Sent events

By subscribing to /notifications/sse/subscribe one will receive notifications as JSON messages. This can be used e.g. to update a UI in real time based on events on the system.

Options
    • -2
    • +2
    /openacs-4/packages/notifications/notifications.info
    • -1
    • +63
    /openacs-4/packages/notifications/tcl/apm-callback-procs.tcl
    • -0
    • +245
    /openacs-4/packages/notifications/tcl/notification-sse-procs.tcl
    • -0
    • +10
    /openacs-4/packages/notifications/www/sse/subscribe.tcl
Tuesday 17 Dec
6:32 pm

antoniop

Retrieving the datasource should not depend on the fact that a driver is configured

Options
    • -2
    • +2
    /openacs-4/packages/search/search.info
    • -8
    • +6
    /openacs-4/packages/search/tcl/search-procs.tcl
Monday 16 Dec
1:23 pm

gustafn

bump upstream version number from 7.5.1 to 7.6.0

Options
    • -2
    • +2
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
    • -2
    • +2
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
1:23 pm

gustafn

bump upstream version number from 11.4.8 to 12.0.2

Options
    • -2
    • +2
    /openacs-4/packages/highcharts/highcharts.info
    • -2
    • +2
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
Friday 13 Dec
10:53 am

gustafn

avoid triggering exception, when provided host header field cannot be resolved.

Options
    • -2
    • +8
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
10:40 am

gustafn

avoid error, when page_contract is called without an ns_set and without an open connection

Options
    • -4
    • +8
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
Thursday 12 Dec
11:40 am

gustafn

fixed typo

Options
    • -4
    • +4
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
Thursday 05 Dec
5:13 pm

antoniop

Compute the columns as weel when creating a multirow from a list

Options
    • -2
    • +6
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
5:12 pm

antoniop

Test converting to and from a multirow and a list

The test reveals that when converting a list into a multirow, the columns will not be set correctly

Options
    • -1
    • +53
    /openacs-4/packages/acs-templating/tcl/test/util-procs.tcl
4:34 pm

antoniop

title always exists now, ensure it is not empty instead

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-sc-procs.tcl
Tuesday 03 Dec
9:51 am

antoniop

Fix possible typo

See https://openacs.org/forums/message-view?message_id=7236544

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/groups-body-create.sql
Thursday 28 Nov
12:28 pm

antoniop

Introduce the toolbar parameter at the richtext superclass level, so

that formpages created with editors expecting this spec, like ckeditor4,

will not fail to load using other editors that do not expect it

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
Wednesday 27 Nov
4:55 pm

antoniop

db quote via the api

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
Tuesday 26 Nov
11:40 am

antoniop

Do not omit line breaks when rendering text interactions as textareas, e.g. in exam protocols

Many thanks to Markus Moser

Options
    • -0
    • +1
    /openacs-4/packages/xowf/www/resources/test-item.css