OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Aug
3:10 pm

gustafn

made regression test more robust

The test was failing, when the preferred language in the browser

was not "en". The test is now slightly better, but one should

use CSS classes (or data attributes) to pick the bulk actions

Options
    • -5
    • +26
    /openacs-4/packages/file-storage/tcl/test/webtest-procs.tcl
11:46 am

gustafn

cleanup of cmd '?'

Options
    • -0
    • +1
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
11:36 am

gustafn

fixed resource leak

Options
    • -45
    • +45
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
11:30 am

gustafn

reduced verbosity

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
11:30 am

gustafn

fixed resource leaks

dom trees were not deleted

Options
    • -1
    • +3
    /openacs-4/packages/acs-lang/tcl/lang-catalog-procs.tcl
11:29 am

gustafn

avoided duplicated loading of procs

Options
    • -0
    • +3
    /openacs-4/packages/acs-templating/tcl/parse-procs-aolserver.tcl
    • -0
    • +3
    /openacs-4/packages/acs-templating/tcl/parse-procs-naviserver.tcl
11:28 am

gustafn

moved functionality to automated testing

Options
    • -28
    • +0
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
    • -23
    • +0
    /openacs-4/packages/xotcl-core/tcl/test/zz-final-procs.tcl
11:15 am

gustafn

Added automated testing for resource leaks

- new API function "aa_check_leftovers": This function is typically

called automatically at the end of every test case in

"aa_run_testcase" but it also makes sense to call it manually in

between of test cases.

- set aa_test_end to private (see no reason why this was public)

- bumped to 5.10.1b2

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/acs-automated-testing.info
    • -3
    • +51
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -1
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
10:58 am

gustafn

fixed leaked dom trees

Options
    • -2
    • +6
    /openacs-4/packages/acs-authentication/tcl/sync-procs.tcl
10:41 am

antoniop

Make localurl filter more robust to invalid URLs: fail validation in this case, intead of crashing

Options
    • -5
    • +9
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
10:14 am

gustafn

fixed resource leaks

dom trees were not deleted

Options
    • -4
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
9:53 am

gustafn

ad_dom_sanitize_html: fixed 2 resource leaks

in case of parsing errors in the input string the following structures leaked:

- dom tree

- stuct::tree

Options
    • -38
    • +42
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
8:59 am

gustafn

make sure to delete tdom document

Delete nodes explicitly, otherwise it survives the end of the proc.

Options
    • -2
    • +5
    /openacs-4/packages/acs-tcl/tcl/json-procs.tcl
Monday 19 Aug
7:07 pm

gustafn

Removed memory leaks in the regression test

- new function ::xo::aa_check_leftovers to detect leaks a soon as possible

- made ::xo::stats better reusable by returning a dict

- extended regression test

- bumped xotcl-core to 5.10.1b5

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -6
    • +7
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -23
    • +39
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
    • -0
    • +23
    /openacs-4/packages/xotcl-core/tcl/test/zz-final-procs.tcl
7:07 pm

gustafn

file zz-final-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xotcl-core/tcl/test/zz-final-procs.tcl
4:40 pm

gustafn

Removed warning during startup

Removed reason for protentially confusing warning during startup

Warning: nsf: method <::nx::Class> <-per-object> <init> does not exist

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
3:55 pm

gustafn

reduced verbosity

Options
    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
3:55 pm

gustafn

improved variable naming

Options
    • -12
    • +13
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
3:48 pm

gustafn

Fixed variable names for SQL functions to allow to call these directly from Tcl

---

--- Fix SQL function that were defined with the same number of

--- arguments and the same argument names, but receiving different

--- types (integers vs. timespans). This is fine, as long the

--- functions are only called from SQL and positional arguments. When

--- calling from Tcl, this does not work.

---

--- This change uses in cases, where offsets are specified as

--- intervals the suffix "_interval" for the variable names, keeping

--- the names without this suffix for integer arguments (for Oracle

--- compatibility).

Options
    • -2
    • +2
    /openacs-4/packages/acs-events/acs-events.info
    • -30
    • +22
    /openacs-4/packages/acs-events/sql/postgresql/acs-events-create.sql
    • -29
    • +22
    /openacs-4/packages/acs-events/sql/postgresql/timespan-create.sql
    • -0
    • +184
    /openacs-4/packages/acs-events/sql/postgresql/upgrade/upgrade-0.6.2d7-0.6.2d8.sql
3:48 pm

gustafn

file upgrade-0.6.2d7-0.6.2d8.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-events/sql/postgresql/upgrade/upgrade-0.6.2d7-0.6.2d8.sql
3:42 pm

gustafn

fixed icanuse-test for deleting samesite cookies

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
2:03 pm

antoniop

Drop view before its dependency sequence

Options
    • -1
    • +1
    /openacs-4/packages/edit-this-page/sql/postgresql/edit-this-page-drop.sql
1:59 pm

antoniop

Officially deprecate old alias

Options
    • -3
    • +3
    /openacs-4/packages/edit-this-page/tcl/etp-procs.tcl
1:52 pm

antoniop

Replace deprecated api

Options
    • -2
    • +2
    /openacs-4/packages/edit-this-page/tcl/etp-procs.tcl
    • -1
    • +1
    /openacs-4/packages/edit-this-page/www/etp-edit.tcl
1:50 pm

antoniop

Whitespace changes

Options
    • -698
    • +696
    /openacs-4/packages/edit-this-page/tcl/etp-procs.tcl
    • -6
    • +5
    /openacs-4/packages/edit-this-page/www/etp-edit.tcl
Sunday 18 Aug
7:34 pm

gustafn

fixed bug causing regression test to fail sometimes

The test did not perform a proper cleanup, leaving tmp-objects around

Options
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
5:30 pm

gustafn

reduced verbosity

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
5:25 pm

gustafn

reduced number of warnings during startup

Previously, we had warning of the form

Warning: Multiple definition of _xowf__i_xowf_require_test_instance ....

due to the "init_class" of the test cases.

The problem was solved by defining an explicit class for such cases.

Options
    • -0
    • +10
    /openacs-4/packages/xowf/tcl/test/test-helper-procs.tcl
    • -17
    • +22
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
5:23 pm

gustafn

increased test coverage to >72%

Options
    • -0
    • +8
    /openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
Saturday 17 Aug
7:07 pm

gustafn

More resource-info updates:

- fixed wrong and inconsistent naming of dict members (many thanks to Sebastian Scheder for figuring this out)

- removed duplicated slashes in resource paths

- fixed incorrect paths when CDN is used

- simplified handling of cspMaps

- added test checking consistency of resource-info dicts

Options
    • -10
    • +10
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -0
    • +52
    /openacs-4/packages/acs-tcl/tcl/test/resource-info-procs.tcl
    • -8
    • +6
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -2
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -1
    • +1
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -10
    • +8
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -54
    • +52
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/init-procs.tcl
    • -12
    • +5
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -8
    • +7
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
    • -1
    • +2
    /openacs-4/packages/richtext-xinha/tcl/richtext-procs.tcl
    • -38
    • +16
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl