OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 19
Total Committers: 145
Last Commit: 30 Apr
Commits this week: 19
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 21 Mar 2023
2:44 pm

antoniop

Go ahead and reimplement also lc_time_utc_to_local

Options
    • -16
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
    • -14
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
    • -10
    • +7
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
2:34 pm

antoniop

Reimplement lc_time_local_to_utc using lc_time_tz_convert

Options
    • -11
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
    • -9
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
    • -10
    • +9
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
2:31 pm

antoniop

Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

Options
    • -0
    • +33
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
9:15 am

trenner

harden page contract

perm-include checks already that privs are not empty

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.tcl
Monday 20 Mar 2023
5:07 pm

antoniop

Use UTF-8 emoji HTML entities instead of static images to convert smileys in the forums package

This has the advantage of not requiring a request to serve the images. It also avoids the need to hardcode the image size, as they will be basically treated as fonts.

Options
    • -19
    • +12
    /openacs-4/packages/forums/tcl/messages-format-procs.tcl
    • -10
    • +11
    /openacs-4/packages/forums/www/doc/emoticons.adp
4:35 pm

antoniop

Whitespace cleanup

Options
    • -5
    • +5
    /openacs-4/packages/forums/tcl/messages-format-procs.tcl
4:02 pm

antoniop

Increase proc coverage, deprecate proc in the process

Options
    • -2
    • +11
    /openacs-4/packages/forums/tcl/messages-procs.tcl
    • -6
    • +101
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
3:15 pm

antoniop

Test cornercase behavior

Options
    • -2
    • +3
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
3:11 pm

hectorr

Whitespace changes

Options
    • -3
    • +3
    /openacs-4/packages/xowiki-portlet/xowiki-portlet.info
2:58 pm

antoniop

Make Service Contract implementations private

Options
    • -5
    • +11
    /openacs-4/packages/forums/tcl/forum-reply-procs.tcl
2:53 pm

antoniop

Hardcode the word "Page" in the message keys as the German localization does

Many thanks to Markus Moser for reporting the inconsistency

Options
    • -2
    • +2
    /openacs-4/packages/xowiki-portlet/xowiki-portlet.info
    • -1
    • +1
    /openacs-4/packages/xowiki-portlet/catalog/xowiki-portlet.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowiki-portlet/catalog/xowiki-portlet.es_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowiki-portlet/catalog/xowiki-portlet.it_IT.ISO-8859-1.xml
2:39 pm

antoniop

Deprecate forum::new_questions_allow and forum::new_questions_deny, one should use forum::edit, which will also track the change, or just inline the query instead

Options
    • -2
    • +6
    /openacs-4/packages/forums/tcl/forums-callback-procs.tcl
    • -3
    • +11
    /openacs-4/packages/forums/tcl/forums-procs.tcl
2:28 pm

antoniop

Deprecate forum::new_questions_allowed_p and replace occurrences

Options
    • -4
    • +2
    /openacs-4/packages/forums/lib/message/threads-chunk.tcl
    • -2
    • +8
    /openacs-4/packages/forums/tcl/forums-procs.tcl
    • -5
    • +1
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
2:17 pm

antoniop

Increase proc coverage

Options
    • -9
    • +44
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
2:04 pm

antoniop

Make faq::notification_delivery::do_notification private

Options
    • -1
    • +1
    /openacs-4/packages/faq/tcl/q-and-a-procs.tcl
1:58 pm

antoniop

Use better idioms to cleanup the user

Options
    • -9
    • +5
    /openacs-4/packages/tlf-survey/tcl/test/tlf-survey-test-procs.tcl
1:34 pm

antoniop

Provide an api to create a new FAQ, so that Create+Read of an FAQ can be tested

Options
    • -0
    • +23
    /openacs-4/packages/faq/tcl/faq-procs-oracle.xql
    • -0
    • +21
    /openacs-4/packages/faq/tcl/faq-procs-postgresql.xql
    • -0
    • +33
    /openacs-4/packages/faq/tcl/faq-procs.tcl
    • -0
    • +23
    /openacs-4/packages/faq/tcl/test/faq-procs.tcl
    • -13
    • +0
    /openacs-4/packages/faq/www/admin/faq-new-2-postgresql.xql
    • -19
    • +4
    /openacs-4/packages/faq/www/admin/faq-new-2.tcl
1:34 pm

antoniop

file faq-procs-oracle.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/faq/tcl/faq-procs-oracle.xql
1:34 pm

antoniop

file faq-procs-postgresql.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/faq/tcl/faq-procs-postgresql.xql
12:48 pm

antoniop

Go straight to the database skipping the many trivial stored procedures, this reduces divergency between Oracle and Postgres

Options
    • -47
    • +0
    /openacs-4/packages/acs-tcl/tcl/membership-rel-procs-oracle.xql
    • -47
    • +0
    /openacs-4/packages/acs-tcl/tcl/membership-rel-procs-postgresql.xql
    • -10
    • +18
    /openacs-4/packages/acs-tcl/tcl/membership-rel-procs.tcl
12:46 pm

antoniop

feed_parser::test::parse_feed is also used by the news-aggregator package, make it public again, document this and claim its coverage

Options
    • -1
    • +5
    /openacs-4/packages/feed-parser/tcl/test/feed-parser-test-procs.tcl
    • -0
    • +1
    /openacs-4/packages/news-aggregator/tcl/test/news-aggregator-test-procs.tcl
11:33 am

antoniop

Make test api private

Options
    • -1
    • +1
    /openacs-4/packages/feed-parser/tcl/test/feed-parser-test-procs.tcl
11:31 am

antoniop

Deprecate feed_parser::sort_result, trivial wrapper over lreverse used only internally

Options
    • -2
    • +7
    /openacs-4/packages/feed-parser/tcl/feed-parser-procs.tcl
11:24 am

antoniop

Deprecate trivial wrapper of HTTP client api

Options
    • -1
    • +7
    /openacs-4/packages/feed-parser/tcl/feed-parser-procs.tcl
Friday 17 Mar 2023
6:47 pm

antoniop

Return after a response was given to the client

Many thanks to Markus Moser

Options
    • -0
    • +1
    /openacs-4/packages/caldav/tcl/caldav-procs.tcl
5:47 pm

antoniop

Move api in a namespace to comply with automated tests

Options
    • -10
    • +12
    /openacs-4/packages/schema-browser/tcl/schema-browser-procs-oracle.tcl
    • -15
    • +17
    /openacs-4/packages/schema-browser/tcl/schema-browser-procs-postgresql.tcl
    • -3
    • +3
    /openacs-4/packages/schema-browser/www/index.tcl
5:42 pm

antoniop

Document public api

Options
    • -1
    • +3
    /openacs-4/packages/schema-browser/tcl/schema-browser-procs-oracle.tcl
    • -1
    • +3
    /openacs-4/packages/schema-browser/tcl/schema-browser-procs-postgresql.tcl
5:36 pm

antoniop

Update page to current practices, using the schema browser for cross compatibility

Options
    • -22
    • +0
    /openacs-4/packages/schema-browser/www/trigger-oracle.xql
    • -22
    • +0
    /openacs-4/packages/schema-browser/www/trigger-postgresql.xql
    • -0
    • +10
    /openacs-4/packages/schema-browser/www/trigger.adp
    • -29
    • +12
    /openacs-4/packages/schema-browser/www/trigger.tcl
5:02 pm

antoniop

As it turns out, even caching only by request has consequences e.g. when one installs xolp from scratch

Disabl caching and prepare the statement instead

Options
    • -4
    • +10
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
4:15 pm

antoniop

Fix english

Options
    • -6
    • +6
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl