OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 145
Last Commit: 17 May
Commits this week: 3
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 18 Feb 2022
2:17 pm

antoniop

Enlarge images to fullscreen when one clicks on them

Options
    • -0
    • +34
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
2:05 pm

gustafn

remove one more case where assumption was that permission returns int

Options
    • -2
    • +3
    /openacs-4/packages/acs-developer-support/tcl/test/acs-developer-support-procs.tcl
1:56 pm

gustafn

Make use of util::file_content_check and check also in other cases

This change also covers the case, where the checkmark for uploading

zip files was added marked in "upload file". It will also report

errors which were silently swalled before.

Bumped version number to 5.10.1d1

Options
    • -3
    • +3
    /openacs-4/packages/file-storage/file-storage.info
    • -3
    • +17
    /openacs-4/packages/file-storage/www/file-add.tcl
    • -5
    • +3
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
1:37 pm

gustafn

util::file_content_check: new utility for checking content of a file

Check whether the provided file is of the requested type.

This function is more robust and protable than relying on

external programs and their output, but it does not work on

all possible file types. It checks a few common cases that

could lead to problems otherwise, like when uploading archives.

Bump version to 5.10.1d9

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -2
    • +40
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -0
    • +24
    /openacs-4/packages/acs-tcl/tcl/test/utilities-procs.tcl
1:34 pm

gustafn

minor changes: don't complain about postgres internal constraint names, provide hints for oversizing

Options
    • -11
    • +33
    /openacs-4/packages/acs-tcl/tcl/test/datamodel-test-procs.tcl
1:30 pm

antoniop

Don't set height explicitly

Options
    • -1
    • +0
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
1:21 pm

antoniop

Fix filtering condition, improve doc

Options
    • -1
    • +8
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
1:14 pm

antoniop

Explicitly set the :plugin <variable>

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
12:50 pm

gustafn

more cases, use same testing idiom for permissions everywhere, break overlong lines

Options
    • -10
    • +16
    /openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
12:45 pm

gustafn

fix test cases

Options
    • -14
    • +14
    /openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
12:36 pm

gustafn

revert last change of Antonio, since this kills Oracle again

It is not clear, which code needs integer as results for Boolean results.

If there is such code, it should handle this requirement locally.

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
11:16 am

antoniop

Include the supplied text_id among the fields we should replace

Options
    • -3
    • +3
    /openacs-4/packages/richtext-xinha/tcl/richtext-procs.tcl
11:14 am

antoniop

Support the extraPlugins attribute the same as the CKEditor4 richtext formfield, as some places in xowiki assume it

Options
    • -2
    • +5
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
10:58 am

trenner

provide value attribute

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/version-delete.tcl
10:42 am

antoniop

Reintroduce cast to integer using a portable idiom

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
10:29 am

antoniop

Prefer cached API

Options
    • -6
    • +5
    /openacs-4/packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl
Thursday 17 Feb 2022
9:28 pm

gustafn

improve input validation

Options
    • -1
    • +3
    /openacs-4/packages/notifications/www/request-new.tcl
9:19 pm

gustafn

added validator for zip files

Options
    • -2
    • +25
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
9:19 pm

gustafn

Fixes for Oracle 19c: more fixes of handling of Boolean values

Options
    • -5
    • +5
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
7:28 pm

antoniop

Significant improvements on the proctoring display UI to help the review process of proctored artifacts:

- user can flag artifacts as OK or to be reviewed

- user can add and delete comments on the single artifacts

- user can filter artifacts by "verified/not verified" "flagged/not flagged" and "all". A counter is displayed showing how many over the total number are being displayed

- interface will update as before when new pictures come in from an ongoing exam

- interface has been designed "mobile first" and with minimal, mostly graphical dependencies, to Bootstrap

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -0
    • +8
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +8
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +8
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -53
    • +438
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -10
    • +21
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
    • -0
    • +103
    /openacs-4/packages/proctoring-support/www/review.tcl
7:28 pm

antoniop

file review.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/review.tcl
4:20 pm

gustafn

Fixes for Oracle 19c: fix data types and interval calculation

Options
    • -8
    • +6
    /openacs-4/packages/acs-templating/sql/oracle/captcha-create.sql
3:17 pm

antoniop

Don't use expressions for the default value, apparently a nono in Oracle

See e.g. https://docs.oracle.com/javadb/10.8.3.0/ref/rrefsqlj30540.html#rrefsqlj30540__sqlj64478

Options
    • -2
    • +7
    /openacs-4/packages/acs-templating/sql/oracle/captcha-create.sql
    • -2
    • +1
    /openacs-4/packages/acs-templating/sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
2:19 pm

gustafn

reduce dependency on adp-level during rendering but get the information directly from the containing objects

Options
    • -11
    • +30
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
11:41 am

gustafn

Fixes for Oracle 19c: added missing Oracle support

Options
    • -19
    • +72
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
11:37 am

gustafn

Fixes for Oracle 19c: consistenly rely on uppercasing of the schema names in the called functions

Options
    • -16
    • +4
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:36 am

gustafn

Fixes for Oracle 19c: uppercase consistently in schema queries

All names in the schema data model are in Oracle in uppercase.

Options
    • -8
    • +8
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
11:27 am

gustafn

Fixes for Oracle 19c: fixed more cases with Problems with Boolean data types

This fixes e.g. the following problem

[16/Feb/2022:20:55:19][3908.7fa5364fa700][-conn:oacs-5-10-0:default:1:9-] Error: SQL(): nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

: SQL: BEGIN :1 := util.foreign_key_exists(table_name => :table_name,column => :column,reftable => :reftable,refcolumn => :refcolumn); END;

[16/Feb/2022:20:55:19][3908.7fa5364fa700][-conn:oacs-5-10-0:default:1:9-] Notice: ### db_with_handle returned error <nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

Options
    • -173
    • +113
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
Wednesday 16 Feb 2022
8:55 pm

gustafn

Fixes for Oracle 19c: output potential errors after command

Options
    • -1
    • +4
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
8:22 pm

gustafn

Fixes for Oracle 19c:

- added special rules for DML differences in Oracle ("MODIFY" option in ALTER TABLE)

- fixed call of ns_pg_bind in Oracle applications

- fixed call of an SQL function returning a table

Options
    • -6
    • +43
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl